Mirrors/task
1
0
Fork 0
mirror of https://github.com/go-task/task.git synced 2026-08-29 10:08:27 +02:00
Code Issues Packages Projects Releases Wiki Activity

perf: reuse buffer when hashing source files for checksums (#2925)

Browse Source
This commit is contained in:
Valentin Maerten
2026-08-03 22:30:20 +02:00
committed by GitHub
parent 5ecb94796d
commit 651aa44f50
2 changed files with 14 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
internal/fingerprint/sources_checksum.go
View File

@@ -88,6 +88,10 @@ func (*ChecksumChecker) Kind() string {
return "checksum"
}
// readerOnly hides any WriterTo/ReaderFrom implementation of the wrapped
// reader, forcing io.CopyBuffer to use the caller-provided buffer.
type readerOnly struct{ io.Reader }
func (c *ChecksumChecker) checksum(t *ast.Task) (string, error) {
sources, err := Globs(t.Dir, t.Sources, t.ShouldUseGitignore())
if err != nil {
@@ -101,14 +105,18 @@ func (c *ChecksumChecker) checksum(t *ast.Task) (string, error) {
if _, err := io.CopyBuffer(h, strings.NewReader(filepath.Base(f)), buf); err != nil {
return "", err
}
f, err := os.Open(f)
file, err := os.Open(f)
if err != nil {
return "", err
}
if _, err = io.CopyBuffer(h, f, buf); err != nil {
// Wrap the file in a plain io.Reader so io.CopyBuffer cannot take the
// (*os.File).WriteTo fast path, which ignores buf and allocates a fresh
// 32KiB buffer for every file. Reusing buf keeps this loop allocation-free.
if _, err = io.CopyBuffer(h, readerOnly{file}, buf); err != nil {
file.Close()
return "", err
}
f.Close()
file.Close()
}
hash := h.Sum128()