From 1eeb7d5cf90570077eb9ee12ca687bf69ce28a80 Mon Sep 17 00:00:00 2001
From: Pete Davison <pd93.uk@outlook.com>
Date: Sat, 2 Dec 2023 01:00:32 +0000
Subject: [PATCH] fix: dynamic vars break with for because of fast-compiled
 tasks

---
 variables.go | 31 ++++++++++++++++++-------------
 1 file changed, 18 insertions(+), 13 deletions(-)

diff --git a/variables.go b/variables.go
index 7ec7f013..21da2315 100644
--- a/variables.go
+++ b/variables.go
@@ -156,19 +156,24 @@ func (e *Executor) compiledTask(call taskfile.Call, evaluateShVars bool) (*taskf
 				if cmd.For.Var != "" {
 					if vars != nil {
 						v := vars.Get(cmd.For.Var)
-						switch value := v.Value.(type) {
-						case string:
-							if cmd.For.Split != "" {
-								list = asAnySlice(strings.Split(value, cmd.For.Split))
-							} else {
-								list = asAnySlice(strings.Fields(value))
-							}
-						case []any:
-							list = value
-						default:
-							return nil, errors.TaskfileInvalidError{
-								URI: origTask.Location.Taskfile,
-								Err: errors.New("var must be a delimiter-separated string or a list"),
+						// If the variable is dynamic, then it hasn't been resolved yet
+						// and we can't use it as a list. This happens when fast compiling a task
+						// for use in --list or --list-all etc.
+						if v.Value != nil && v.Sh == "" {
+							switch value := v.Value.(type) {
+							case string:
+								if cmd.For.Split != "" {
+									list = asAnySlice(strings.Split(value, cmd.For.Split))
+								} else {
+									list = asAnySlice(strings.Fields(value))
+								}
+							case []any:
+								list = value
+							default:
+								return nil, errors.TaskfileInvalidError{
+									URI: origTask.Location.Taskfile,
+									Err: errors.New("var must be a delimiter-separated string or a list"),
+								}
 							}
 						}
 					}