From ea42793532bd87ecbcd3deebcd021fc135d328b9 Mon Sep 17 00:00:00 2001
From: Sidney Alcantara <sidney@sidney.me>
Date: Mon, 24 Feb 2020 11:22:36 +1100
Subject: [PATCH] fix SideDrawerEditor not triggering side drawer open

---
 www/src/components/Table/editors/SideDrawerEditor.tsx | 4 ++--
 www/src/components/Table/formatters/FinalColumn.tsx   | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/www/src/components/Table/editors/SideDrawerEditor.tsx b/www/src/components/Table/editors/SideDrawerEditor.tsx
index ead5b2cb..a1a6fb26 100644
--- a/www/src/components/Table/editors/SideDrawerEditor.tsx
+++ b/www/src/components/Table/editors/SideDrawerEditor.tsx
@@ -12,12 +12,12 @@ import { useFiretableContext } from "contexts/firetableContext";
  * Use for cells that do not support any type of in-cell editing.
  */
 const SideDrawerEditor = React.forwardRef(
-  (props: EditorProps<any, any>, ref) => {
+  ({ column, row }: EditorProps<any, any>, ref) => {
     const { sideDrawerOpen, setSideDrawerOpen } = useFiretableContext();
 
     useEffect(() => {
       if (!sideDrawerOpen && setSideDrawerOpen) setSideDrawerOpen(true);
-    }, []);
+    }, [column?.key, row?.id]);
 
     return (
       <div
diff --git a/www/src/components/Table/formatters/FinalColumn.tsx b/www/src/components/Table/formatters/FinalColumn.tsx
index 0520d348..c8458d1a 100644
--- a/www/src/components/Table/formatters/FinalColumn.tsx
+++ b/www/src/components/Table/formatters/FinalColumn.tsx
@@ -47,7 +47,7 @@ export const useFinalColumnStyles = makeStyles(theme =>
 export default function FinalColumn({ row }: FormatterProps) {
   const { tableActions } = useFiretableContext();
   const shiftPress = useKeyPress("Shift");
-  console.log(shiftPress);
+
   return (
     <Grid container spacing={1}>
       <Grid item>