From 28f6ea519f22589965def134db46794b13ae28bf Mon Sep 17 00:00:00 2001
From: Bobby Wang <bofei@mail.com>
Date: Thu, 29 Dec 2022 20:57:18 +0930
Subject: [PATCH] column logs: only allow logging view for
 connector/action/default value/derivative

---
 src/components/ColumnMenu/ColumnMenu.tsx        | 14 +++++++++++---
 .../CloudLogsModal/CloudLogsModal.tsx           | 17 +++++++++++++----
 2 files changed, 24 insertions(+), 7 deletions(-)

diff --git a/src/components/ColumnMenu/ColumnMenu.tsx b/src/components/ColumnMenu/ColumnMenu.tsx
index 99b168aa..7dff465e 100644
--- a/src/components/ColumnMenu/ColumnMenu.tsx
+++ b/src/components/ColumnMenu/ColumnMenu.tsx
@@ -318,7 +318,15 @@ export default function ColumnMenu({
       },
       disabled: !isConfigurable,
     },
-    {
+  ];
+
+  if (
+    column?.config?.defaultValue?.type === "dynamic" ||
+    [FieldType.action, FieldType.derivative, FieldType.connector].includes(
+      column.type
+    )
+  ) {
+    configActions.push({
       key: "logs",
       label: altPress ? "Logs" : "Logs…",
       icon: <LogsIcon />,
@@ -330,8 +338,8 @@ export default function ColumnMenu({
           column: [column.key],
         });
       },
-    },
-  ];
+    });
+  }
 
   // TODO: Generalize
   const handleEvaluateAll = async () => {
diff --git a/src/components/TableModals/CloudLogsModal/CloudLogsModal.tsx b/src/components/TableModals/CloudLogsModal/CloudLogsModal.tsx
index 93c2a8af..2b835e3a 100644
--- a/src/components/TableModals/CloudLogsModal/CloudLogsModal.tsx
+++ b/src/components/TableModals/CloudLogsModal/CloudLogsModal.tsx
@@ -43,6 +43,7 @@ import {
   cloudLogFiltersAtom,
 } from "@src/atoms/tableScope";
 import { cloudLogFetcher } from "./utils";
+import { FieldType } from "@src/constants/fields";
 
 export default function CloudLogsModal({ onClose }: ITableModalProps) {
   const [projectId] = useAtom(projectIdAtom, projectScope);
@@ -312,13 +313,21 @@ export default function CloudLogsModal({ onClose }: ITableModalProps) {
                   <MultiSelect
                     multiple
                     aria-label={"Column"}
-                    options={Object.entries(tableSchema.columns ?? {}).map(
-                      ([key, config]) => ({
+                    options={Object.entries(tableSchema.columns ?? {})
+                      .filter(
+                        ([key, config]) =>
+                          config?.config?.defaultValue?.type === "dynamic" ||
+                          [
+                            FieldType.action,
+                            FieldType.derivative,
+                            FieldType.connector,
+                          ].includes(config.type)
+                      )
+                      .map(([key, config]) => ({
                         label: config.name,
                         value: key,
                         type: config.type,
-                      })
-                    )}
+                      }))}
                     value={cloudLogFilters.column ?? []}
                     onChange={(v) =>
                       setCloudLogFilters((prev) => ({ ...prev, column: v }))