mirror of
https://github.com/makeplane/plane.git
synced 2026-09-01 19:48:42 +02:00
7564480cf7
* fix: resolve React Doctor errors and restore its PR baseline The React Doctor check on PR #9160 reported 266 issues across 130 files. Most of that is a reporting artifact: the workflow's `actions/checkout` step used the default shallow clone, so React Doctor had no merge base to diff against and fell back to listing every pre-existing issue in every changed file rather than only what the PR introduced. Add `fetch-depth: 0` so the comparison works. Also point the `push` trigger at `preview` — the repo's default branch — instead of `main`, which does not exist here, so the health-score trend never ran. Fix the 7 genuine errors it surfaced: - use-keypress: `callback` sat in the effect deps while every one of the 10 call sites passes an inline arrow, so the document listener was torn down and re-added on every render. Latch the callback in a ref and key the subscription on `key` alone. This clears `no-effect-with-fresh-deps` at create-root.tsx:102 and create-project-modal.tsx:64 at the source. - estimates/points/preview: the dblclick listener was added with no cleanup, so listeners accumulated on every toggle. Add the matching removeEventListener. - issues/header, calendar/issue-block, pages/editor/editor-body: guard `window` reads that run during render with `typeof window !== "undefined"`, matching the pattern already used elsewhere in web and admin. The editor case previously relied on the surrounding try/catch swallowing a ReferenceError on the server. Also clears the five pre-existing oxlint warnings in calendar/issue-block that the repo's `--deny-warnings` pre-commit gate blocks on once the file is touched: rename a shadowed `issue` parameter, and mark two presentational wrapper divs with `role="presentation"` — CustomMenu already wraps the first in a real <button>, and the second exists only to stop click propagation to the surrounding ControlLink. Verified: `turbo run check:types --filter=web` passes (11/11 tasks), `oxlint --deny-warnings` reports 0 warnings and 0 errors on the changed files. Claude-Session: https://claude.ai/code/session_01Hrr1nfNBiyC256drHM8BbT * fix: import EditorAIMenu directly instead of through the ai barrel The only issue React Doctor reports against this branch. `./ai` re-exports both menu.tsx and ask-pi-menu.tsx, so importing through it pulls the ask-pi menu into the page editor bundle for a symbol that lives in menu.tsx. Pre-existing on preview rather than introduced here, but it is a one-line fix in a file this branch already touches. Claude-Session: https://claude.ai/code/session_01Hrr1nfNBiyC256drHM8BbT * fix: address CodeRabbit review on the React Doctor branch - react-doctor.yml: set persist-credentials: false on checkout. The token otherwise stays in .git/config for the third-party millionco/react-doctor step that runs next. fetch-depth: 0 has already fetched every ref the merge-base diff needs, and the action authenticates to the API through its own credentials, so nothing depends on the persisted git credential. - calendar/issue-block: pass workspaceSlug?.toString() to handleRedirection. The param is typed string | undefined and line 89 of the same file already optional-chains it; this call site would have thrown on a missing route param. Pre-existing, but it is on a line this branch already touches. Declined the two SSR/hydration findings: apps/web sets ssr: false in react-router.config.ts and ships a client-only bundle, so there is no server render to diverge from. The typeof window guards satisfy the React Doctor rule but are defensive only. Claude-Session: https://claude.ai/code/session_01Hrr1nfNBiyC256drHM8BbT
73 lines
3.5 KiB
YAML
73 lines
3.5 KiB
YAML
# React Doctor — finds security, performance, correctness, accessibility,
|
|
# bundle-size, and architecture issues in React codebases.
|
|
#
|
|
# Docs: https://www.react.doctor/ci
|
|
# Source: https://github.com/millionco/react-doctor
|
|
|
|
name: React Doctor
|
|
|
|
on:
|
|
pull_request:
|
|
types: [opened, synchronize, reopened, ready_for_review]
|
|
# Scans `preview` on every push so you get a health-score trend on the
|
|
# default branch — useful for tracking the overall number commit-by-commit
|
|
# and catching regressions that slipped past PR review. PR-specific steps
|
|
# (the sticky summary comment) are skipped automatically on `push` events.
|
|
# Comment this block out if you only want PR-time scans.
|
|
push:
|
|
branches: [preview]
|
|
|
|
permissions:
|
|
# `actions/checkout` needs this to read the repo source.
|
|
contents: read
|
|
# Two uses: (1) reads the PR's changed-file list so the scan only checks
|
|
# what the PR touched (faster, scoped to the diff), and (2) posts/updates
|
|
# the sticky React Doctor summary comment on the PR. Downgrade `write` to
|
|
# `read` to keep the changed-file scan but disable comment posting.
|
|
pull-requests: write
|
|
# The sticky-comment step uses GitHub's `issues.createComment` /
|
|
# `issues.updateComment` endpoints — those are the same APIs that back PR
|
|
# comments (PRs are issues under the hood). Not exercised on `push`
|
|
# events, so safe to drop if you only run on `main`.
|
|
issues: write
|
|
# Lets the action publish a commit status with the score + error/warning
|
|
# counts (links to the run). This is how a `push` to `main` surfaces its
|
|
# result, since the PR comment is skipped off pull requests. Drop it to
|
|
# disable the status (or set `commit-status: false` below).
|
|
statuses: write
|
|
|
|
# Cancels any in-flight scan for the same PR (or branch, on push) the moment
|
|
# a new commit arrives, so reviewers only ever see the latest run.
|
|
concurrency:
|
|
group: react-doctor-${{ github.event.pull_request.number || github.ref }}
|
|
cancel-in-progress: true
|
|
|
|
jobs:
|
|
react-doctor:
|
|
runs-on: ubuntu-latest
|
|
steps:
|
|
- uses: actions/checkout@v5
|
|
with:
|
|
# React Doctor diffs the changed files against the merge base so it
|
|
# only reports what the PR introduces. The default shallow checkout
|
|
# has no merge base, which makes it fall back to listing every
|
|
# pre-existing issue in every changed file.
|
|
fetch-depth: 0
|
|
# Don't leave the workflow token in .git/config for the third-party
|
|
# action that runs next. fetch-depth: 0 has already fetched every ref
|
|
# it needs, and it talks to the API through its own credentials.
|
|
persist-credentials: false
|
|
|
|
- uses: millionco/react-doctor@v2
|
|
# Common configuration knobs — uncomment any to override the default.
|
|
# Full reference: https://www.react.doctor/ci
|
|
# with:
|
|
# blocking: warning # Gate level: "error" (default) | "warning" | "none" (advisory)
|
|
# scope: full # On PRs, scan the whole project instead of just changed files
|
|
# comment: false # Disable the sticky PR summary comment
|
|
# review-comments: false # Disable inline review comments on changed lines
|
|
# commit-status: false # Disable the commit status (score + counts, links to the run)
|
|
# version: "0.4.0" # Pin to a specific react-doctor version instead of "latest"
|
|
# directory: apps/web # Scan a sub-directory (default: ".")
|
|
# project: "web,admin" # In a monorepo, scan specific workspace project(s)
|