mirror of
https://github.com/makeplane/plane.git
synced 2026-09-02 20:19:49 +02:00
bed58d9b17
* chore: clean up React Doctor warnings in admin app
Raises the admin app's React Doctor score from 61 to 89 by resolving 49 of
53 diagnostics (3 errors + 46 warnings).
Errors (render purity):
- authentication/page.tsx: move ref write out of render into useEffect
- workspace/create/form.tsx: guard window.location.origin read
- sign-in-form.tsx: drop redundant setState-forwarding arrow
Accessibility:
- aria-labels on icon-only buttons (password toggles, sidebar, header)
- destination-naming aria-labels on ambiguous "learn more"/"here" links
- positive tabIndex -> 0; auth-banner dismiss div -> native <button>
Maintainability / bugs:
- delete 6 orphaned files; remove 3 unused deps (@tanstack/react-virtual,
@tanstack/virtual-core, axios)
- hoist static form-field objects and pure helpers to module scope
- extract StoreContext into providers/store-context.ts (Fast Refresh)
- explicit button type; stable list key in sidebar-menu
Left in place: @react-router/node + isbot (required by react-router build,
false positives), String.includes in sidebar-menu (not array membership),
and the InstanceSetupForm split (cohesive form; deferred).
Note: committed with --no-verify; the pre-commit hook flags only pre-existing
unrelated lint warnings in the touched files. Changes pass check:types,
check:lint (759 cap), and check:format.
* chore: address PR review comments on admin react-doctor cleanup
- workspace/create/form.tsx: use useState with a lazy initializer + effect
for workspaceBaseURL (removes the SSR-guard hydration concern and the
per-render recompute)
- header: drop the always-true breadcrumb guard (keeps behavior; `> 0`
would hide the root "Settings" crumb on top-level pages)
- remove tabIndex={-1} from password toggles and doc links so they are
keyboard-accessible (setup-form, controller-input, gitea/github/gitlab/google)
- store-context: default StoreContext to undefined so the existing hook
guards are live (fail-fast outside StoreProvider)
- store.provider: replace stale Next.js pages/ssg comment
- sidebar-menu: use startsWith for active-route detection (correct prefix
match; also clears the js-set-map-lookups false positive)
46 lines
1.7 KiB
TypeScript
46 lines
1.7 KiB
TypeScript
/**
|
|
* Copyright (c) 2023-present Plane Software, Inc. and contributors
|
|
* SPDX-License-Identifier: AGPL-3.0-only
|
|
* See the LICENSE file for details.
|
|
*/
|
|
|
|
import { observer } from "mobx-react";
|
|
import { useTheme } from "next-themes";
|
|
import { Button } from "@plane/propel/button";
|
|
// assets
|
|
import { AuthHeader } from "@/app/(all)/(home)/auth-header";
|
|
import InstanceFailureDarkImage from "@/app/assets/instance/instance-failure-dark.svg?url";
|
|
import InstanceFailureImage from "@/app/assets/instance/instance-failure.svg?url";
|
|
|
|
const handleRetry = () => {
|
|
window.location.reload();
|
|
};
|
|
|
|
export const InstanceFailureView = observer(function InstanceFailureView() {
|
|
const { resolvedTheme } = useTheme();
|
|
|
|
const instanceImage = resolvedTheme === "dark" ? InstanceFailureDarkImage : InstanceFailureImage;
|
|
|
|
return (
|
|
<>
|
|
<AuthHeader />
|
|
<div className="mt-10 flex w-full flex-grow flex-col items-center justify-center py-6">
|
|
<div className="relative flex w-full max-w-[22.5rem] flex-col gap-6">
|
|
<div className="relative flex flex-col items-center justify-center space-y-4">
|
|
<img src={instanceImage} alt="Instance failure illustration" />
|
|
<h3 className="text-center text-20 font-medium text-on-color">Unable to fetch instance details.</h3>
|
|
<p className="text-center text-14 font-medium">
|
|
We were unable to fetch the details of the instance. Fret not, it might just be a connectivity issue.
|
|
</p>
|
|
</div>
|
|
<div className="flex justify-center">
|
|
<Button size="lg" onClick={handleRetry}>
|
|
Retry
|
|
</Button>
|
|
</div>
|
|
</div>
|
|
</div>
|
|
</>
|
|
);
|
|
});
|