* fix: resolve React Doctor errors and restore its PR baseline
The React Doctor check on PR #9160 reported 266 issues across 130 files.
Most of that is a reporting artifact: the workflow's `actions/checkout`
step used the default shallow clone, so React Doctor had no merge base to
diff against and fell back to listing every pre-existing issue in every
changed file rather than only what the PR introduced. Add `fetch-depth: 0`
so the comparison works. Also point the `push` trigger at `preview` — the
repo's default branch — instead of `main`, which does not exist here, so
the health-score trend never ran.
Fix the 7 genuine errors it surfaced:
- use-keypress: `callback` sat in the effect deps while every one of the
10 call sites passes an inline arrow, so the document listener was torn
down and re-added on every render. Latch the callback in a ref and key
the subscription on `key` alone. This clears `no-effect-with-fresh-deps`
at create-root.tsx:102 and create-project-modal.tsx:64 at the source.
- estimates/points/preview: the dblclick listener was added with no
cleanup, so listeners accumulated on every toggle. Add the matching
removeEventListener.
- issues/header, calendar/issue-block, pages/editor/editor-body: guard
`window` reads that run during render with `typeof window !== "undefined"`,
matching the pattern already used elsewhere in web and admin. The editor
case previously relied on the surrounding try/catch swallowing a
ReferenceError on the server.
Also clears the five pre-existing oxlint warnings in calendar/issue-block
that the repo's `--deny-warnings` pre-commit gate blocks on once the file
is touched: rename a shadowed `issue` parameter, and mark two presentational
wrapper divs with `role="presentation"` — CustomMenu already wraps the
first in a real <button>, and the second exists only to stop click
propagation to the surrounding ControlLink.
Verified: `turbo run check:types --filter=web` passes (11/11 tasks),
`oxlint --deny-warnings` reports 0 warnings and 0 errors on the changed files.
Claude-Session: https://claude.ai/code/session_01Hrr1nfNBiyC256drHM8BbT
* fix: import EditorAIMenu directly instead of through the ai barrel
The only issue React Doctor reports against this branch. `./ai` re-exports
both menu.tsx and ask-pi-menu.tsx, so importing through it pulls the
ask-pi menu into the page editor bundle for a symbol that lives in
menu.tsx. Pre-existing on preview rather than introduced here, but it is
a one-line fix in a file this branch already touches.
Claude-Session: https://claude.ai/code/session_01Hrr1nfNBiyC256drHM8BbT
* fix: address CodeRabbit review on the React Doctor branch
- react-doctor.yml: set persist-credentials: false on checkout. The token
otherwise stays in .git/config for the third-party millionco/react-doctor
step that runs next. fetch-depth: 0 has already fetched every ref the
merge-base diff needs, and the action authenticates to the API through
its own credentials, so nothing depends on the persisted git credential.
- calendar/issue-block: pass workspaceSlug?.toString() to handleRedirection.
The param is typed string | undefined and line 89 of the same file already
optional-chains it; this call site would have thrown on a missing route
param. Pre-existing, but it is on a line this branch already touches.
Declined the two SSR/hydration findings: apps/web sets ssr: false in
react-router.config.ts and ships a client-only bundle, so there is no
server render to diverge from. The typeof window guards satisfy the
React Doctor rule but are defensive only.
Claude-Session: https://claude.ai/code/session_01Hrr1nfNBiyC256drHM8BbT
* refactor: migrate constants (fetch-keys) from apps/web to @plane/constants
* refactor: migrate constants (ai, calenda, gaant) from apps/web to @plane/constants
* refactor: migrate constants (sidebar, favorites) from apps/web to @plane/constants
* refactor: migrate constants (editor) from apps/web to @plane/constants
* refactor: migrate constants (plans) from apps/web to @core/components
* resolved lint errors
* fix: resolve coderabbit comments
* refactor: resolve coderabbit comments
* refactor: migrate hooks (use-file-size) from web/app/ce to web/app/core
* refactor: migrate hooks (use-notification-preview) from web/app/ce to web/app/core
* refactor: migrate hooks (use-timeline-chart) from web/app/ce to web/app/core
* refactor: migrate hooks (use-page, use-page-store) from web/app/ce to web/app/core
* refactor: migrate hooks (app-rail, indexes) from web/app/ce to web/app/core
* refactor: migrate hooks (use-page-flag) from web/app/ce to web/app/core
* refactor: migrate hooks (use-editor-flagging) from web/app/ce to web/app/core
* refactor: migrate hooks (use-filters-operator-configs) from web/app/ce to web/app/core
* refactor: migrate hooks (use-additional-editor-mention) from web/app/ce to web/app/core
* refactor: migrate hooks (use-additional-favorite-item-details) from web/app/ce to web/app/core
* refactor: migrate hooks (use-extended-editor-extensions, use-pages-pane-extensions) from web/app/ce to web/app/core
* refactor: migrate hooks (use-work-items-filters-config) from web/app/ce to web/app/core
* refactor: migrate hooks (use-extended-editor-config) from web/app/ce to web/app/core
* refactor: migrate hooks (use-bulk-operations) from web/app/ce to web/app/core
* refactor: migrate hooks (use-debounced-duplicate-issues) from web/app/ce to web/app/core
* refactor: migrate hooks (use-issue-properties) from web/app/ce to web/app/core
* refactor: migrate hooks (use-workspace-issue-properties) from web/app/ce to web/app/core
* refactor: delete hook (use-issue-embed) from web/app/ce
* fix: coderabbit comments
* fix: React doctor comments
* fix: import structure for hooks
* refactor: remove command palette & sidebar components and related files from web/app/ce
* refactor: update analytics tab imports and add new analytics tab components
* feat: add project, work item, and workspace level modals for enhanced user interaction
* refactor: replace WorkspaceActiveCyclesRoot with WorkspaceActiveCyclesUpgrade and remove obsolete components
* refactor: migrate app-rail HOC to core components and remove obsolete index file
* refactor: remove unused automation components and simplify layout structure
* refactor: update import paths for CommonProjectBreadcrumbs and add new breadcrumb components
* refactor: update import path for WorkItemDetailRoot and add new work item detail component
* refactor: remove obsolete comments index file and introduce CommentBlock component in core
* refactor: update import paths for common components and introduce new ExtendedAppHeader, GlobalModals, and SubscriptionPill components
* refactor: remove obsolete index file and add MaintenanceMessage and InboxSourcePill components
* refactor: remove obsolete cycle components and introduce new cycle-related components in core
* refac: moved de-dupe directory to core
* refactor: add new desktop components and update import paths for sidebar functionality
* refactor: remove obsolete index file and introduce new version number and product updates components in core
* refactor: add EpicModal component and update import paths in issue layouts
* refactor: add HomePageHeader and HomePeekOverviewsRoot components, update import paths in home and issues sections
* refactor: remove obsolete home index file, update import paths for relation options in issue detail components, and introduce new activity helper functions
* refactor: remove AdditionalFilterValueInput from legacy path and reintroduce it in core filter value input component
* refactor: remove legacy workspace-notifications index file and introduce new notification components in core
* refactor: remove legacy license components and update import paths for PaidPlanUpgradeModal
* refactor: remove legacy navigation components and update import paths for navigation items in core
* refactor: introduce onboarding tour components and update import paths for tour-related files
* refactor: remove legacy theme switcher component and update import paths in profile settings
* refactor: update import paths for workflow components and introduce new workflow-related files in core
* refactor: remove legacy estimate components and introduce new estimate-related files in core
* refactor: remove legacy gantt-chart components and introduce new core components for gantt-chart functionality
* refactor: remove legacy helper components and introduce new access control and publish components in core
* refactor: introduce billing components and update import paths for billing-related files in core
* refactor: introduce new members components and update import paths for workspace members functionality
* refactor: update import paths for workspace components and introduce new workspace-related files
* refactor: remove deprecated components and clean up import paths across various modules
* refactor: remove unused components and clean up import paths across various modules
* refactor: remove unused sidebar components and update import paths in workspace notifications
* refactor: introduce new estimate, billing, and notification card components while updating import paths across various modules
* refactor: remove unused estimate and billing components, update import paths, and streamline workspace notification card structure
* refactor: update import paths for project components and remove unused files in the projects module
* refactor: remove unused power-k components and update import paths in the command palette module
* refactor: remove unused issue components and update import paths across the issues module
* refactor: remove unused mentions components and update import paths in the editor module
* refactor: remove unused components and update import paths across the pages module
* refactor: update type imports for issue properties in issue modal context
* fix: oxfmt
* fix: PR checks
* [GIT-254] Refactor: Store consolidation to @core/store (#9271)
* refactor: remove unused store files and update import paths across the application
* refactor: remove unused store files and update import paths across the core module
* refactor: remove unused issue filter and store files, and update import paths in the core module
* refactor: update import paths for timeline store files and introduce new base timeline store
* refactor: remove deprecated root store file and update import paths across the application
* refactor: update import paths for store files and correct root store type references
* refactor: standardize import comments and remove 'plane-web' artifacts across various components
* fix: CodeRabbit comments
* fix: format
* refactor: update TypeScript configuration and improve sorting method in TabNavigationRoot component
* refactor: replace toSorted with sort method for navigation item sorting in TabNavigationRoot component
---------
Co-authored-by: Rahulcheryala <rahulcheryala2004@gmail.com>
Co-authored-by: Prateek Shourya <prateekshourya29@gmail.com>
* refactor: replace isomorphic-dompurify with sanitize-html
* dompurify fixes
* more fixes with fallback and title
* build
---------
Co-authored-by: Prateek Shourya <prateekshourya29@gmail.com>
* [WEB-5559] improve: chat support functionality and remove Intercom provider
- Added ChatSupportModal component for chat support integration.
- Replaced IntercomProvider with ChatSupportModal in AppProvider.
- Introduced useChatSupport hook to manage chat support state and actions.
- Updated help commands to utilize chat support instead of Intercom.
- Removed obsolete Intercom-related components and hooks.
* refactor: lazy load ChatSupportModal in AppProvider
* [WEB-5501] refactor: optimize component structures and improve hooks
- Updated type definitions in AppProvider to use React.ReactNode for children.
- Enhanced HomePeekOverviewsRoot by using MobX observer and integrating issue detail hook.
- Optimized ContentOverflowWrapper to prevent unnecessary re-renders by adjusting useEffect dependencies.
- Updated DashboardQuickLinks to include necessary dependencies in useCallback.
- Refactored GlobalShortcutsProvider to utilize refs for context and handler management, improving performance.
- Changed useCurrentTime to update every minute instead of every second.
- Refactored outside click hooks to use useCallback for better performance.
- Improved IntercomProvider and PostHogProvider to prevent multiple initializations using refs.
* refactor: simplify conditional rendering in HomePeekOverviewsRoot component
* refactor: improve outside click detection in sidebar and peek overview hooks
* refactor: enhance IntercomProvider and PostHogProvider with hydration state management
- Add jscodeshift-based codemod to convert arrow function components to function declarations
- Support React.FC, observer-wrapped, and forwardRef components
- Include comprehensive test suite covering edge cases
- Add npm script to run transformer across codebase
- Target only .tsx files in source directories, excluding node_modules and declaration files
* [WEB-5459] chore: updates after running codemod
---------
Co-authored-by: sriramveeraghanta <veeraghanta.sriram@gmail.com>
* feat: add project shortcut in command palette
* feat: global project switcher shortcut
* refactor: generalize command palette entity handling
* feat: extend command palette navigation
* feat: add issue shortcut to command palette
* feat: add modular project selection for cycle navigation
* chore: add reusable command palette utilities
* fix: update key sequence handling to use window methods for timeout management
* fix: build errors
* chore: minor ux copy improvements
* feat: implement a new command registry and renderer for enhanced command palette functionality
* feat: introduce new command palette components and enhance search functionality
* feat: enhance command palette components with improved initialization and loading indicators
* feat: Implement new command palette architecture with multi-step commands, context-aware filtering, and reusable components. Add comprehensive documentation and integration guides. Enhance command execution with a dedicated executor and context provider. Introduce new command types and improve existing command definitions for better usability and maintainability.
* refactor: hook arguments
* refactor: folder structure
* refactor: update import paths
* fix: context prop drilling
* refactor: update search components
* refactor: create actions
* chore: add type to pages
* chore: init contextual actions
* refactor: context based actions code split
* chore: module context-based actions
* refactor: streamline command execution flow and enhance multi-step handling in command palette
* refactor: remove placeholder management from command execution and implement centralized placeholder mapping
* chore: cycle context based actions
* refactor: simplify command execution by consolidating selection steps and adding page change handling
* chore: added more options to work item contextual actions
* chore: page context actions
* refactor: update step type definitions and enhance page mapping for command execution
* feat: implement Command Palette V2 with global shortcuts and enhanced context handling
* refactor: power k v2
* refactor: creation commands
* feat: add navigation utility for Power K context handling
* feat: implement comprehensive navigation commands for Power K
* refactor: work item contextual actions
* fix: build errors
* refactor: remaining contextual actions
* refactor: remove old code
* chore: update placeholder
* refactor: enhance command registry with observable properties and context-aware shortcut handling
* refactor: improve command filtering logic in CommandPaletteModal
* chore: context indicator
* chore: misc actions
* style: shortcut badge
* feat: add open entity actions and enhance navigation commands for Power K
* refactor: rename and reorganize Power K components for improved clarity and structure
* refactor: update CommandPalette components and streamline global shortcuts handling
* refactor: adjust debounce timing in CommandPaletteModal for improved responsiveness
* feat: implement shortcuts modal and enhance command registry for better shortcut management
* fix: search implemented
* refactor: search results code split
* refactor: search results code split
* feat: introduce creation and navigation command modules for Power K, enhancing command organization and functionality
* chore: update menu logos
* refactor: remove unused PowerKOpenEntityActionsExtended component from command palette
* refactor: search menu
* fix: clear context on backspace and manual clear
* refactor: rename creation command keys for consistency and clarity in Power K
* chore: added intake in global search
* chore: preferences menu
* chore: removed the empty serach params
* revert: command palette changes
* cleanup
* refactor: update command IDs to use underscores for consistency across Power K components
* refactor: extended context based actions
* chore: modal command item status props
* refactor: replace CommandPalette with CommandPaletteProvider in settings and profile layouts
* refactor: update settings menu to use translated labels instead of i18n labels
* refactor: update command titles to use translation keys for creation actions
* refactor: update navigation command titles to use translation keys for consistency
* chore: minor cleanup
* chore: misc commands added
* chore: code split for no search results command
* chore: state menu items for work item context based commands
* chore: add more props to no search results command
* chore: add more props to no search results command
* refactor: remove shortcut key for create workspace command
* Refactor command palette to use PowerK store
- Replaced instances of `useCommandPalette` with `usePowerK` across various components, including `AppSearch`, `CommandModal`, and `CommandPalette`.
- Introduced `PowerKStore` to manage modal states and commands, enhancing the command palette functionality.
- Updated modal handling to toggle `PowerKModal` and `ShortcutsListModal` instead of the previous command palette modals.
- Refactored related components to ensure compatibility with the new store structure and maintain functionality.
* Refactor PowerK command handling to remove context dependency
- Updated `usePowerKCommands` and `usePowerKCreationCommands` to eliminate the need for a context parameter, simplifying their usage.
- Adjusted related command records to utilize the new structure, ensuring consistent access to command configurations.
- Enhanced permission checks in creation commands to utilize user project roles for better access control.
* chore: add context indicator
* chore: update type import
* chore: migrate toast implementation from @plane/ui to @plane/propel/toast across multiple command files
* refactor: power k modal wrapper and provider
* fix: type imports
* chore: update creation command shortcuts
* fix: page context commands
* chore: update navigation and open command shortcuts
* fix: work item standalone page modals
* fix: context indicator visibility
* fix: potential error points
* fix: build errors
* fix: lint errors
* fix: import order
---------
Co-authored-by: Vihar Kurama <vihar.kurama@gmail.com>
Co-authored-by: Prateek Shourya <prateekshourya29@gmail.com>
Co-authored-by: NarayanBavisetti <narayan3119@gmail.com>
* [WEB-5134] refactor: update `web` ESLint configuration and refactor imports to use type imports
- Enhanced ESLint configuration by adding new rules for import consistency and type imports.
- Refactored multiple files to replace regular imports with type imports for better clarity and performance.
- Ensured consistent use of type imports across the application to align with TypeScript best practices.
* refactor: standardize type imports across components
- Updated multiple files to replace regular imports with type imports for improved clarity and consistency.
- Ensured adherence to TypeScript best practices in the rich filters and issue layouts components.
* fix(lint): get ci passing again
* chore(ci): run lint before build
* chore(ci): exclude web app from build check for now
The web app takes too long and causes CI to timeout. Once we
improve we will reintroduce.
* fix: formating of files
* fix: adding format to ci
---------
Co-authored-by: sriramveeraghanta <veeraghanta.sriram@gmail.com>
