From 4b815f3769a9be5e55513d1c87c13d0d4791cc09 Mon Sep 17 00:00:00 2001 From: Bavisetti Narayan <72156168+NarayanBavisetti@users.noreply.github.com> Date: Wed, 23 Oct 2024 21:04:10 +0530 Subject: [PATCH] fix: issue attachment uploads (#5904) --- apiserver/plane/app/views/asset/v2.py | 9 ++++++--- apiserver/plane/app/views/issue/attachment.py | 3 ++- apiserver/plane/space/views/asset.py | 3 ++- 3 files changed, 10 insertions(+), 5 deletions(-) diff --git a/apiserver/plane/app/views/asset/v2.py b/apiserver/plane/app/views/asset/v2.py index 76a9351ea5..1f3f9e6a25 100644 --- a/apiserver/plane/app/views/asset/v2.py +++ b/apiserver/plane/app/views/asset/v2.py @@ -209,7 +209,8 @@ class UserAssetsV2Endpoint(BaseAPIView): # update the attributes asset.attributes = request.data.get("attributes", asset.attributes) # save the asset - asset.save(created_by=request.user) + asset.created_by = request.user + asset.save() return Response(status=status.HTTP_204_NO_CONTENT) def delete(self, request, asset_id): @@ -459,7 +460,8 @@ class WorkspaceFileAssetEndpoint(BaseAPIView): # update the attributes asset.attributes = request.data.get("attributes", asset.attributes) # save the asset - asset.save(created_by=request.user) + asset.created_by = request.user + asset.save() return Response(status=status.HTTP_204_NO_CONTENT) def delete(self, request, slug, asset_id): @@ -690,7 +692,8 @@ class ProjectAssetEndpoint(BaseAPIView): # update the attributes asset.attributes = request.data.get("attributes", asset.attributes) # save the asset - asset.save(created_by=request.user) + asset.created_by = request.user + asset.save() return Response(status=status.HTTP_204_NO_CONTENT) @allow_permission([ROLE.ADMIN, ROLE.MEMBER, ROLE.GUEST]) diff --git a/apiserver/plane/app/views/issue/attachment.py b/apiserver/plane/app/views/issue/attachment.py index 2ec40f5b80..48b80c6cb8 100644 --- a/apiserver/plane/app/views/issue/attachment.py +++ b/apiserver/plane/app/views/issue/attachment.py @@ -253,9 +253,10 @@ class IssueAttachmentV2Endpoint(BaseAPIView): # Update the attachment issue_attachment.is_uploaded = True + issue_attachment.created_by = request.user # Get the storage metadata if not issue_attachment.storage_metadata: get_asset_object_metadata.delay(str(issue_attachment.id)) - issue_attachment.save(created_by=request.user) + issue_attachment.save() return Response(status=status.HTTP_204_NO_CONTENT) diff --git a/apiserver/plane/space/views/asset.py b/apiserver/plane/space/views/asset.py index 631866d557..372be2548c 100644 --- a/apiserver/plane/space/views/asset.py +++ b/apiserver/plane/space/views/asset.py @@ -169,7 +169,8 @@ class EntityAssetEndpoint(BaseAPIView): # update the attributes asset.attributes = request.data.get("attributes", asset.attributes) # save the asset - asset.save(created_by=request.user) + asset.created_by = request.user + asset.save() return Response(status=status.HTTP_204_NO_CONTENT) def delete(self, request, anchor, pk):