From ed6dd3704317799d7b499346113b6ed64082814d Mon Sep 17 00:00:00 2001 From: Anmol Singh Bhatia <121005188+anmolsinghbhatia@users.noreply.github.com> Date: Wed, 1 May 2024 18:36:11 +0530 Subject: [PATCH] fix: module sub-header empty state validation (#4329) --- web/components/modules/modules-list-view.tsx | 14 +++++++++++++- .../projects/[projectId]/modules/index.tsx | 8 +------- 2 files changed, 14 insertions(+), 8 deletions(-) diff --git a/web/components/modules/modules-list-view.tsx b/web/components/modules/modules-list-view.tsx index 36de22d6c9..6a82fddd43 100644 --- a/web/components/modules/modules-list-view.tsx +++ b/web/components/modules/modules-list-view.tsx @@ -4,7 +4,13 @@ import { useRouter } from "next/router"; // components import { ListLayout } from "@/components/core/list"; import { EmptyState } from "@/components/empty-state"; -import { ModuleCardItem, ModuleListItem, ModulePeekOverview, ModulesListGanttChartView } from "@/components/modules"; +import { + ModuleCardItem, + ModuleListItem, + ModulePeekOverview, + ModuleViewHeader, + ModulesListGanttChartView, +} from "@/components/modules"; import { CycleModuleBoardLayout, CycleModuleListLayout, GanttLayoutLoader } from "@/components/ui"; // constants import { EmptyStateType } from "@/constants/empty-state"; @@ -67,6 +73,12 @@ export const ModulesListView: React.FC = observer(() => { return ( <> +
+
+ Module name +
+ +
{displayFilters?.layout === "list" && (
diff --git a/web/pages/[workspaceSlug]/projects/[projectId]/modules/index.tsx b/web/pages/[workspaceSlug]/projects/[projectId]/modules/index.tsx index cecaf01f19..22973347f6 100644 --- a/web/pages/[workspaceSlug]/projects/[projectId]/modules/index.tsx +++ b/web/pages/[workspaceSlug]/projects/[projectId]/modules/index.tsx @@ -7,7 +7,7 @@ import { TModuleFilters } from "@plane/types"; import { PageHead } from "@/components/core"; import { EmptyState } from "@/components/empty-state"; import { ModulesListHeader } from "@/components/headers"; -import { ModuleAppliedFiltersList, ModuleViewHeader, ModulesListView } from "@/components/modules"; +import { ModuleAppliedFiltersList, ModulesListView } from "@/components/modules"; // types // hooks import ModulesListMobileHeader from "@/components/modules/moduels-list-mobile-header"; @@ -57,12 +57,6 @@ const ProjectModulesPage: NextPageWithLayout = observer(() => { <>
-
-
- Module name -
- -
{calculateTotalFilters(currentProjectFilters ?? {}) !== 0 && (