From b68396a4b2d808c19378954f06406e29ca0a2d15 Mon Sep 17 00:00:00 2001 From: Surya Prashanth Date: Fri, 11 Apr 2025 01:42:53 +0530 Subject: [PATCH] [WEB-3831] chore: add validation for project_id in cycle serializer #6908 --- apiserver/plane/api/serializers/cycle.py | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/apiserver/plane/api/serializers/cycle.py b/apiserver/plane/api/serializers/cycle.py index c828195d2d..ba22e25f9d 100644 --- a/apiserver/plane/api/serializers/cycle.py +++ b/apiserver/plane/api/serializers/cycle.py @@ -39,7 +39,15 @@ class CycleSerializer(BaseSerializer): data.get("start_date", None) is not None and data.get("end_date", None) is not None ): - project_id = self.initial_data.get("project_id") or self.instance.project_id + project_id = self.initial_data.get("project_id") or ( + self.instance.project_id + if self.instance and hasattr(self.instance, "project_id") + else None + ) + + if not project_id: + raise serializers.ValidationError("Project ID is required") + is_start_date_end_date_equal = ( True if str(data.get("start_date")) == str(data.get("end_date"))