Mirrors/plane
1
0
Fork 0
mirror of https://github.com/makeplane/plane.git synced 2025-12-23 23:29:37 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix: web-view action permission, logs, archive issue, and more (#2356)

Browse Source 
* fix: web-view

* feat: select module

* dev: select cycle & module

* fix: permissions, logs and archive issue

* fix: logs for issue select

fix: hard-coded web-view validation

* fix: attachment confirm delete workflow

* fix: typo

* fix: logging link instead of redirecting to the link

* fix: made editor height 100%

* style: due-date select

* fix: update comment not working

* fix: changed button text

style: spacing

* fix: due date select not working for today's date

* fix: typography

* fix: spacing in select parent
This commit is contained in:
Dakshesh Jain
2023-10-12 12:28:36 +05:30
committed by GitHub
parent 58ea4d6ec9
commit 892a30c3a8
33 changed files with 2322 additions and 515 deletions
Download Patch File Download Diff File Expand all files Collapse all files

41
web/components/web-view/issue-link-list.tsx
View File

@@ -16,7 +16,7 @@ import issuesService from "services/issues.service";
import { Link as LinkIcon, Plus, Pencil, X } from "lucide-react";
// components
import { Label, WebViewModal, CreateUpdateLinkForm } from "components/web-view";
import { Label, WebViewModal, CreateUpdateLinkForm, DeleteConfirmation } from "components/web-view";
// ui
import { SecondaryButton } from "components/ui";
@@ -39,12 +39,13 @@ export const IssueLinks: React.FC<Props> = (props) => {
const [isOpen, setIsOpen] = useState(false);
const [selectedLink, setSelectedLink] = useState<string | null>(null);
const [deleteSelected, setDeleteSelected] = useState<string | null>(null);
const router = useRouter();
const { workspaceSlug, projectId } = router.query;
const handleDeleteLink = async (linkId: string) => {
if (!workspaceSlug || !projectId || !issueDetails) return;
if (!workspaceSlug || !projectId || !issueDetails || !allowed) return;
const updatedLinks = issueDetails.issue_link.filter((l) => l.id !== linkId);
@@ -56,7 +57,7 @@ export const IssueLinks: React.FC<Props> = (props) => {
await issuesService
.deleteIssueLink(workspaceSlug as string, projectId as string, issueDetails.id, linkId)
.then((res) => {
.then(() => {
mutate(ISSUE_DETAILS(issueDetails.id));
})
.catch((err) => {
@@ -85,6 +86,18 @@ export const IssueLinks: React.FC<Props> = (props) => {
/>
</WebViewModal>
<DeleteConfirmation
title="Delete Link"
content="Are you sure you want to delete this link?"
isOpen={!!deleteSelected}
onCancel={() => setDeleteSelected(null)}
onConfirm={() => {
if (!deleteSelected || !allowed) return;
handleDeleteLink(deleteSelected);
setDeleteSelected(null);
}}
/>
<Label>Links</Label>
<div className="mt-1 space-y-[6px]">
{links?.map((link) => (
@@ -92,14 +105,18 @@ export const IssueLinks: React.FC<Props> = (props) => {
key={link.id}
className="px-3 border border-custom-border-200 rounded-[4px] py-2 flex justify-between items-center bg-custom-background-100"
>
<Link href={link.url}>
<a target="_blank" className="text-custom-text-200 truncate">
<span>
<LinkIcon className="w-4 h-4 inline-block mr-1" />
</span>
<span>{link.title}</span>
</a>
</Link>
<button
type="button"
onClick={() => {
console.log("link", link.url);
}}
className="text-custom-text-200 truncate"
>
<span>
<LinkIcon className="w-4 h-4 inline-block mr-1" />
</span>
<span>{link.title || link.metadata?.title || link.url}</span>
</button>
{allowed && (
<div className="flex gap-2 items-center">
<button
@@ -114,7 +131,7 @@ export const IssueLinks: React.FC<Props> = (props) => {
<button
type="button"
onClick={() => {
handleDeleteLink(link.id);
setDeleteSelected(link.id);
}}
>
<X className="w-[18px] h-[18px] text-custom-text-400" />