From 533384f6f35736851a3ef2285ee9bb3737671e3e Mon Sep 17 00:00:00 2001 From: Prateek Shourya Date: Thu, 26 Dec 2024 14:05:43 +0530 Subject: [PATCH] fix: handle errors when cycle dates are updated to inactive (#2027) --- .../cycles/active-cycle/progress-header.tsx | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/web/ee/components/cycles/active-cycle/progress-header.tsx b/web/ee/components/cycles/active-cycle/progress-header.tsx index 3ccbd21cd0..dfb502d7ad 100644 --- a/web/ee/components/cycles/active-cycle/progress-header.tsx +++ b/web/ee/components/cycles/active-cycle/progress-header.tsx @@ -5,7 +5,7 @@ import { format, parseISO, startOfToday } from "date-fns"; // types import { ArrowRight, CalendarDays } from "lucide-react"; // icons -import { TCycleProgress } from "@plane/types"; +import { ICycle, TCycleProgress } from "@plane/types"; import { ControlLink, Loader } from "@plane/ui"; import { CycleListItemAction } from "@/components/cycles"; // helpers @@ -21,7 +21,7 @@ type Props = { workspaceSlug: string; projectId: string; cycleId: string; - cycleDetails: any; + cycleDetails: ICycle; progressLoader: boolean; }; @@ -35,7 +35,7 @@ export const CycleProgressHeader: FC = (props: Props) => { const createdByDetails = cycleDetails.created_by ? getUserDetails(cycleDetails.created_by) : undefined; const progressToday = progress && progress.find((d) => d.date === format(startOfToday(), "yyyy-MM-dd")); // handlers - const handleControlLinkClick = (e: React.MouseEvent) => { + const handleControlLinkClick = () => { router.push(`/${workspaceSlug}/projects/${projectId}/cycles/${cycleDetails.id}`, {}, { showProgressBar: false }); }; @@ -59,10 +59,9 @@ export const CycleProgressHeader: FC = (props: Props) => { {/* Duration */}
- {format(parseISO(cycleDetails.start_date), "MMM dd, yyyy")} - + {cycleDetails.start_date && {format(parseISO(cycleDetails.start_date), "MMM dd, yyyy")}} - {format(parseISO(cycleDetails.end_date), "MMM dd, yyyy")} + {cycleDetails.end_date && {format(parseISO(cycleDetails.end_date), "MMM dd, yyyy")}}
{/* created by */} {createdByDetails && }