From 041f2b16c3adf0fc376e2e83a6b1edb2b9d73182 Mon Sep 17 00:00:00 2001 From: Akshita Goyal <36129505+gakshita@users.noreply.github.com> Date: Mon, 12 Aug 2024 19:12:35 +0530 Subject: [PATCH 1/2] [WEB-1986] chore: Build Fix, project page import (#5356) * chore: seperated project components for CE * chore: splitted the code for project creation form * fix: code structure optimization * fix: project page root moved * fix: synced with preview * fix: component splitting and refactoring * fix: build error * fix: import error --- .../(projects)/projects/(detail)/archives/page.tsx | 2 +- web/app/[workspaceSlug]/(projects)/projects/(list)/page.tsx | 2 +- web/ce/components/projects/page.tsx | 4 +--- web/core/components/project/root.tsx | 2 ++ 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/web/app/[workspaceSlug]/(projects)/projects/(detail)/archives/page.tsx b/web/app/[workspaceSlug]/(projects)/projects/(detail)/archives/page.tsx index b9b78bd5f4..ac6e5c3cd9 100644 --- a/web/app/[workspaceSlug]/(projects)/projects/(detail)/archives/page.tsx +++ b/web/app/[workspaceSlug]/(projects)/projects/(detail)/archives/page.tsx @@ -1,4 +1,4 @@ -import ProjectPageRoot from "@/plane-web/components/projects/page"; +import { ProjectPageRoot } from "@/plane-web/components/projects/page"; const ProjectsPage = () => ; export default ProjectsPage; diff --git a/web/app/[workspaceSlug]/(projects)/projects/(list)/page.tsx b/web/app/[workspaceSlug]/(projects)/projects/(list)/page.tsx index b9b78bd5f4..ac6e5c3cd9 100644 --- a/web/app/[workspaceSlug]/(projects)/projects/(list)/page.tsx +++ b/web/app/[workspaceSlug]/(projects)/projects/(list)/page.tsx @@ -1,4 +1,4 @@ -import ProjectPageRoot from "@/plane-web/components/projects/page"; +import { ProjectPageRoot } from "@/plane-web/components/projects/page"; const ProjectsPage = () => ; export default ProjectsPage; diff --git a/web/ce/components/projects/page.tsx b/web/ce/components/projects/page.tsx index 960c597300..a44ab7df40 100644 --- a/web/ce/components/projects/page.tsx +++ b/web/ce/components/projects/page.tsx @@ -1,5 +1,3 @@ import Root from "@/components/project/root"; -const ProjectPageRoot = () => ; - -export default ProjectPageRoot; +export const ProjectPageRoot = () => ; diff --git a/web/core/components/project/root.tsx b/web/core/components/project/root.tsx index ab3d821fe6..ad649b5de6 100644 --- a/web/core/components/project/root.tsx +++ b/web/core/components/project/root.tsx @@ -60,6 +60,8 @@ const Root = observer(() => { useEffect(() => { if (pathname.includes("/archives")) { updateDisplayFilters(workspaceSlug.toString(), { archived_projects: true }); + } else { + updateDisplayFilters(workspaceSlug.toString(), { archived_projects: false }); } }, [pathname]); return ( From 4792c1cdf564ce3c19664a0ff905c80cc86910d2 Mon Sep 17 00:00:00 2001 From: Aaryan Khandelwal <65252264+aaryan610@users.noreply.github.com> Date: Mon, 12 Aug 2024 19:17:10 +0530 Subject: [PATCH 2/2] fix: project modal shortcut (#5353) --- .../command-palette/command-palette.tsx | 18 +++--- .../project/create-project-modal.tsx | 63 +++++-------------- .../project/create/project-create-buttons.tsx | 2 +- 3 files changed, 29 insertions(+), 54 deletions(-) diff --git a/web/core/components/command-palette/command-palette.tsx b/web/core/components/command-palette/command-palette.tsx index 099d53f909..7427fabee8 100644 --- a/web/core/components/command-palette/command-palette.tsx +++ b/web/core/components/command-palette/command-palette.tsx @@ -212,7 +212,6 @@ export const CommandPalette: FC = observer(() => { toggleCreatePageModal, toggleCreateProjectModal, toggleCreateViewModal, - toggleShortcutModal, ] ); @@ -261,15 +260,18 @@ export const CommandPalette: FC = observer(() => { if ( Object.keys(shortcutsList.global).includes(keyPressed) && ((!projectId && performAnyProjectCreateActions()) || performProjectCreateActions()) - ) + ) { shortcutsList.global[keyPressed].action(); + } // workspace authorized actions else if ( Object.keys(shortcutsList.workspace).includes(keyPressed) && workspaceSlug && performWorkspaceCreateActions() - ) + ) { + e.preventDefault(); shortcutsList.workspace[keyPressed].action(); + } // project authorized actions else if ( Object.keys(shortcutsList.project).includes(keyPressed) && @@ -283,16 +285,18 @@ export const CommandPalette: FC = observer(() => { } }, [ - performAnyProjectCreateActions, - performProjectCreateActions, - performProjectBulkDeleteActions, - performWorkspaceCreateActions, copyIssueUrlToClipboard, isAnyModalOpen, + platform, + performAnyProjectCreateActions, + performProjectBulkDeleteActions, + performProjectCreateActions, + performWorkspaceCreateActions, projectId, setTrackElement, shortcutsList, toggleCommandPaletteModal, + toggleShortcutModal, toggleSidebar, workspaceSlug, ] diff --git a/web/core/components/project/create-project-modal.tsx b/web/core/components/project/create-project-modal.tsx index 6fbe08cbcb..b5e44fe404 100644 --- a/web/core/components/project/create-project-modal.tsx +++ b/web/core/components/project/create-project-modal.tsx @@ -1,5 +1,6 @@ -import { useEffect, Fragment, FC, useState } from "react"; -import { Dialog, Transition } from "@headlessui/react"; +import { useEffect, FC, useState } from "react"; +// ui +import { EModalPosition, EModalWidth, ModalCore } from "@plane/ui"; // components import { CreateProjectForm } from "@/plane-web/components/projects/create/root"; import { TProject } from "@/plane-web/types/projects"; @@ -38,49 +39,19 @@ export const CreateProjectModal: FC = (props) => { }; return ( - - - -
- - -
-
- - - {currentStep === EProjectCreationSteps.CREATE_PROJECT && ( - - )} - {currentStep === EProjectCreationSteps.FEATURE_SELECTION && ( - - )} - - -
-
-
-
+ + {currentStep === EProjectCreationSteps.CREATE_PROJECT && ( + + )} + {currentStep === EProjectCreationSteps.FEATURE_SELECTION && ( + + )} + ); }; diff --git a/web/core/components/project/create/project-create-buttons.tsx b/web/core/components/project/create/project-create-buttons.tsx index 8816a54540..7eac095835 100644 --- a/web/core/components/project/create/project-create-buttons.tsx +++ b/web/core/components/project/create/project-create-buttons.tsx @@ -12,7 +12,7 @@ const ProjectCreateButtons: React.FC = (props) => { } = useFormContext(); return ( -
+