Mirrors/plane
1
0
Fork 0
mirror of https://github.com/makeplane/plane.git synced 2026-08-29 10:08:51 +02:00
Code Issues Packages Projects Releases Wiki Activity

fix: remove redundant Fragment wrapper around comboButton in dropdowns (#9694)

Browse Source 
Combobox.Button as={Fragment} requires its child to be a single real
element. Wrapping the button ternary in <>...</> made the child a
Fragment instance itself, which @headlessui/react v2 rejects with
"Passing props on Fragment!" at runtime. Dropping the wrapper fixes
priority, estimate, intake-state, member, module, cycle, state, and
project dropdowns.
This commit is contained in:
Atul Tameshwari
2026-08-27 14:54:18 +05:30
committed by GitHub
parent 1a76f29c79
commit 302f09b5b9
8 changed files with 16 additions and 48 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
apps/web/core/components/dropdowns/cycle/index.tsx
View File

@@ -83,9 +83,7 @@ export const CycleDropdown = observer(function CycleDropdown(props: Props) {
handleClose(); handleClose();
}; };
const comboButton = ( const comboButton = button ? (
<>
{button ? (
<button <button
ref={setReferenceElement} ref={setReferenceElement}
type="button" type="button"
@@ -130,9 +128,7 @@ export const CycleDropdown = observer(function CycleDropdown(props: Props) {
)} )}
</DropdownButton> </DropdownButton>
</button> </button>
)} );
</>
);
return ( return (
<ComboDropDown <ComboDropDown

8
apps/web/core/components/dropdowns/estimate.tsx
View File

@@ -159,9 +159,7 @@ export const EstimateDropdown = observer(function EstimateDropdown(props: Props)
handleClose(); handleClose();
}; };
const comboButton = ( const comboButton = button ? (
<>
{button ? (
<button <button
ref={setReferenceElement} ref={setReferenceElement}
type="button" type="button"
@@ -214,9 +212,7 @@ export const EstimateDropdown = observer(function EstimateDropdown(props: Props)
)} )}
</DropdownButton> </DropdownButton>
</button> </button>
)} );
</>
);
return ( return (
<ComboDropDown <ComboDropDown

8
apps/web/core/components/dropdowns/intake-state/base.tsx
View File

@@ -135,9 +135,7 @@ export const WorkItemStateDropdownBase = observer(function WorkItemStateDropdown
handleClose(); handleClose();
}; };
const comboButton = ( const comboButton = button ? (
<>
{button ? (
<button <button
ref={setReferenceElement} ref={setReferenceElement}
type="button" type="button"
@@ -197,9 +195,7 @@ export const WorkItemStateDropdownBase = observer(function WorkItemStateDropdown
)} )}
</DropdownButton> </DropdownButton>
</button> </button>
)} );
</>
);
return ( return (
// oxlint-disable-next-line jsx_a11y/no-static-element-interactions // oxlint-disable-next-line jsx_a11y/no-static-element-interactions

8
apps/web/core/components/dropdowns/member/base.tsx
View File

@@ -108,9 +108,7 @@ export const MemberDropdownBase = observer(function MemberDropdownBase(props: TM
} }
}; };
const comboButton = ( const comboButton = button ? (
<>
{button ? (
<button <button
ref={setReferenceElement} ref={setReferenceElement}
type="button" type="button"
@@ -159,9 +157,7 @@ export const MemberDropdownBase = observer(function MemberDropdownBase(props: TM
)} )}
</DropdownButton> </DropdownButton>
</button> </button>
)} );
</>
);
return ( return (
<ComboDropDown <ComboDropDown

8
apps/web/core/components/dropdowns/module/base.tsx
View File

@@ -111,9 +111,7 @@ export const ModuleDropdownBase = observer(function ModuleDropdownBase(props: TM
} }
}, [isOpen, isMobile]); }, [isOpen, isMobile]);
const comboButton = ( const comboButton = button ? (
<>
{button ? (
<button <button
ref={setReferenceElement} ref={setReferenceElement}
type="button" type="button"
@@ -171,9 +169,7 @@ export const ModuleDropdownBase = observer(function ModuleDropdownBase(props: TM
/> />
</DropdownButton> </DropdownButton>
</button> </button>
)} );
</>
);
return ( return (
<ComboDropDown <ComboDropDown

8
apps/web/core/components/dropdowns/priority.tsx
View File

@@ -398,9 +398,7 @@ export function PriorityDropdown(props: Props) {
? BackgroundButton ? BackgroundButton
: TransparentButton; : TransparentButton;
const comboButton = ( const comboButton = button ? (
<>
{button ? (
<button <button
ref={setReferenceElement} ref={setReferenceElement}
type="button" type="button"
@@ -440,9 +438,7 @@ export function PriorityDropdown(props: Props) {
renderToolTipByDefault={renderByDefault} renderToolTipByDefault={renderByDefault}
/> />
</button> </button>
)} );
</>
);
return ( return (
<ComboDropDown <ComboDropDown

8
apps/web/core/components/dropdowns/project/base.tsx
View File

@@ -174,9 +174,7 @@ export const ProjectDropdownBase = observer(function ProjectDropdownBase(props:
} }
}; };
const comboButton = ( const comboButton = button ? (
<>
{button ? (
<button <button
ref={setReferenceElement} ref={setReferenceElement}
type="button" type="button"
@@ -219,9 +217,7 @@ export const ProjectDropdownBase = observer(function ProjectDropdownBase(props:
)} )}
</DropdownButton> </DropdownButton>
</button> </button>
)} );
</>
);
return ( return (
<ComboDropDown <ComboDropDown

8
apps/web/core/components/dropdowns/state/base.tsx
View File

@@ -136,9 +136,7 @@ export const WorkItemStateDropdownBase = observer(function WorkItemStateDropdown
handleClose(); handleClose();
}; };
const comboButton = ( const comboButton = button ? (
<>
{button ? (
<button <button
ref={setReferenceElement} ref={setReferenceElement}
type="button" type="button"
@@ -199,9 +197,7 @@ export const WorkItemStateDropdownBase = observer(function WorkItemStateDropdown
)} )}
</DropdownButton> </DropdownButton>
</button> </button>
)} );
</>
);
return ( return (
// oxlint-disable-next-line jsx_a11y/no-static-element-interactions // oxlint-disable-next-line jsx_a11y/no-static-element-interactions