From 25eb727eb957d8d00d3fece284a455cef3dd7bd6 Mon Sep 17 00:00:00 2001 From: sriram veeraghanta Date: Mon, 13 Jan 2025 14:33:59 +0530 Subject: [PATCH] fix: error handling for workspace invite bg task (#6385) --- .../plane/bgtasks/workspace_invitation_task.py | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/apiserver/plane/bgtasks/workspace_invitation_task.py b/apiserver/plane/bgtasks/workspace_invitation_task.py index c0b945e62b..a8bd0d7d03 100644 --- a/apiserver/plane/bgtasks/workspace_invitation_task.py +++ b/apiserver/plane/bgtasks/workspace_invitation_task.py @@ -16,9 +16,9 @@ from plane.utils.exception_logger import log_exception @shared_task -def workspace_invitation(email, workspace_id, token, current_site, invitor): +def workspace_invitation(email, workspace_id, token, current_site, inviter): try: - user = User.objects.get(email=invitor) + user = User.objects.get(email=inviter) workspace = Workspace.objects.get(pk=workspace_id) workspace_member_invite = WorkspaceMemberInvite.objects.get( @@ -26,7 +26,7 @@ def workspace_invitation(email, workspace_id, token, current_site, invitor): ) # Relative link - relative_link = f"/workspace-invitations/?invitation_id={workspace_member_invite.id}&email={email}&slug={workspace.slug}" + relative_link = f"/workspace-invitations/?invitation_id={workspace_member_invite.id}&email={email}&slug={workspace.slug}" # noqa: E501 # The complete url including the domain abs_url = str(current_site) + relative_link @@ -42,7 +42,7 @@ def workspace_invitation(email, workspace_id, token, current_site, invitor): ) = get_email_configuration() # Subject of the email - subject = f"{user.first_name or user.display_name or user.email} has invited you to join them in {workspace.name} on Plane" + subject = f"{user.first_name or user.display_name or user.email} has invited you to join them in {workspace.name} on Plane" # noqa: E501 context = { "email": email, @@ -78,11 +78,9 @@ def workspace_invitation(email, workspace_id, token, current_site, invitor): ) msg.attach_alternative(html_content, "text/html") msg.send() - logging.getLogger("plane").info("Email sent succesfully") - + logging.getLogger("plane").info("Email sent successfully") return - except (Workspace.DoesNotExist, WorkspaceMemberInvite.DoesNotExist) as e: - log_exception(e) + except (Workspace.DoesNotExist, WorkspaceMemberInvite.DoesNotExist): return except Exception as e: log_exception(e)