From 18d0f39697c2453854622cadee79c70132255dc2 Mon Sep 17 00:00:00 2001 From: Saurabh Kumar <70131915+Saurabhkmr98@users.noreply.github.com> Date: Fri, 11 Jul 2025 19:23:46 +0530 Subject: [PATCH] [SILO-386] Fix modules not getting attached to WI #3649 --- apps/silo/src/etl/migrator/migrator.ts | 25 +++++++------------------ apps/silo/src/helpers/cache-keys.ts | 2 -- 2 files changed, 7 insertions(+), 20 deletions(-) diff --git a/apps/silo/src/etl/migrator/migrator.ts b/apps/silo/src/etl/migrator/migrator.ts index e7bf81626f..80d87e9063 100644 --- a/apps/silo/src/etl/migrator/migrator.ts +++ b/apps/silo/src/etl/migrator/migrator.ts @@ -18,7 +18,6 @@ import { IMPORT_JOB_PLANE_ISSUE_PROPERTIES_CACHE_KEY, IMPORT_JOB_PLANE_ISSUE_PROPERTY_OPTIONS_CACHE_KEY, IMPORT_JOB_PLANE_ISSUE_TYPES_CACHE_KEY, - IMPORT_JOB_PLANE_MODULES_CACHE_KEY, IMPORT_JOB_FIRST_PAGE_PUSHED_CACHE_KEY, } from "@/helpers/cache-keys"; import { IMPORT_JOB_KEYS_TTL_IN_SECONDS } from "@/helpers/constants"; @@ -57,7 +56,6 @@ export async function migrateToPlane(job: TImportJob, data: PlaneEntities[], met // Create the data required for the workspace let planeLabels: ExIssueLabel[] = []; let planeUsers: PlaneUser[] = []; - let planeModules: { id: string; issues: string[] }[] = []; let planeIssueTypes: ExIssueType[] = []; let planeIssueProperties: ExIssueProperty[] = []; let planeIssuePropertiesOptions: ExIssuePropertyOption[] = []; @@ -129,7 +127,6 @@ export async function migrateToPlane(job: TImportJob, data: PlaneEntities[], met const issueTypesCacheKey = IMPORT_JOB_PLANE_ISSUE_TYPES_CACHE_KEY(job.id); const issuePropertiesCacheKey = IMPORT_JOB_PLANE_ISSUE_PROPERTIES_CACHE_KEY(job.id); const issuePropertyOptionsCacheKey = IMPORT_JOB_PLANE_ISSUE_PROPERTY_OPTIONS_CACHE_KEY(job.id); - const modulesCacheKey = IMPORT_JOB_PLANE_MODULES_CACHE_KEY(job.id); const store = Store.getInstance(); @@ -148,11 +145,6 @@ export async function migrateToPlane(job: TImportJob, data: PlaneEntities[], met logger.info(`Found cached issue property options`, { jobId: job.id }); planeIssuePropertiesOptions = JSON.parse(cachedIssuePropertyOptions); } - const cachedModules = await store.get(modulesCacheKey); - if (cachedModules) { - logger.info(`Found cached modules`, { jobId: job.id }); - planeModules = JSON.parse(cachedModules); - } const triggerIssueTypeStep = isIssueTypeFeatureEnabled && (!cachedIssueTypes || !cachedIssueProperties || !cachedIssuePropertyOptions); @@ -385,16 +377,13 @@ export async function migrateToPlane(job: TImportJob, data: PlaneEntities[], met ); // ------------------- Module Creation -------------------- - if (!cachedModules) { - planeModules = await createAllModules( - job.id, - modules as ExModule[], - planeClient, - job.workspace_slug, - job.project_id - ); - await store.set(modulesCacheKey, JSON.stringify(planeModules), IMPORT_JOB_KEYS_TTL_IN_SECONDS); - } + const planeModules = await createAllModules( + job.id, + modules as ExModule[], + planeClient, + job.workspace_slug, + job.project_id + ); // ------------------- Issue Type Cache Storage -------------------- if the issue type step is triggered if (triggerIssueTypeStep) { diff --git a/apps/silo/src/helpers/cache-keys.ts b/apps/silo/src/helpers/cache-keys.ts index 2846a864b5..455c557e48 100644 --- a/apps/silo/src/helpers/cache-keys.ts +++ b/apps/silo/src/helpers/cache-keys.ts @@ -24,8 +24,6 @@ export const IMPORT_JOB_PLANE_ISSUE_PROPERTIES_CACHE_KEY = (jobId: string) => export const IMPORT_JOB_PLANE_ISSUE_PROPERTY_OPTIONS_CACHE_KEY = (jobId: string) => `silo:import_job_plane_issue_property_options_${jobId}`; -export const IMPORT_JOB_PLANE_MODULES_CACHE_KEY = (jobId: string) => `silo:import_job_plane_modules_${jobId}`; - export const IMPORT_JOB_PLANE_MEMBERS_CACHE_KEY = (jobId: string) => `silo:import_job_plane_members_${jobId}`; export const IMPORT_JOB_FIRST_PAGE_PUSHED_CACHE_KEY = (jobId: string) => `silo:import_job_first_page_pushed_${jobId}`;