From 14601d0f362fd2480ef8bcdb47eedda5af03be0d Mon Sep 17 00:00:00 2001 From: sriram veeraghanta Date: Sat, 30 Aug 2025 22:50:49 +0530 Subject: [PATCH] fix: base url standardization --- packages/services/src/project-publish/core.service.ts | 7 +++---- packages/services/src/project-publish/extended.service.ts | 6 +++--- packages/services/src/project-publish/index.ts | 3 ++- packages/services/src/project-view/core.service.ts | 2 +- packages/services/src/project-view/extended.service.ts | 4 ++-- packages/services/src/project-view/index.ts | 5 +++-- packages/services/src/project/index.ts | 2 +- packages/services/src/state/index.ts | 5 +++-- 8 files changed, 18 insertions(+), 16 deletions(-) diff --git a/packages/services/src/project-publish/core.service.ts b/packages/services/src/project-publish/core.service.ts index 2c3878d85b..fc6ab70499 100644 --- a/packages/services/src/project-publish/core.service.ts +++ b/packages/services/src/project-publish/core.service.ts @@ -1,4 +1,3 @@ -import { API_BASE_URL } from "@plane/constants"; import { TProjectPublishSettings } from "@plane/types"; import { APIService } from "../api.service"; @@ -8,9 +7,9 @@ import { APIService } from "../api.service"; * @extends {APIService} * @remarks This service is only available for plane core */ -export class CoreProjectPublishService extends APIService { - constructor(BASE_URL?: string) { - super(BASE_URL || API_BASE_URL); +export abstract class CoreProjectPublishService extends APIService { + constructor(BASE_URL: string) { + super(BASE_URL); } async retrieve(workspaceSlug: string, projectID: string): Promise { diff --git a/packages/services/src/project-publish/extended.service.ts b/packages/services/src/project-publish/extended.service.ts index 85b12d0a6d..91e9d829f4 100644 --- a/packages/services/src/project-publish/extended.service.ts +++ b/packages/services/src/project-publish/extended.service.ts @@ -1,7 +1,7 @@ import { CoreProjectPublishService } from "./core.service"; -export class ExtendedProjectPublishService extends CoreProjectPublishService { - constructor() { - super(); +export abstract class ExtendedProjectPublishService extends CoreProjectPublishService { + constructor(baseUrl: string) { + super(baseUrl); } } diff --git a/packages/services/src/project-publish/index.ts b/packages/services/src/project-publish/index.ts index 0a950f071e..b502886d0f 100644 --- a/packages/services/src/project-publish/index.ts +++ b/packages/services/src/project-publish/index.ts @@ -1,7 +1,8 @@ +import { API_BASE_URL } from "@plane/constants"; import { ExtendedProjectPublishService } from "./extended.service"; export class ProjectPublishService extends ExtendedProjectPublishService { constructor() { - super(); + super(API_BASE_URL); } } diff --git a/packages/services/src/project-view/core.service.ts b/packages/services/src/project-view/core.service.ts index e6797fd926..0c4cdba3bb 100644 --- a/packages/services/src/project-view/core.service.ts +++ b/packages/services/src/project-view/core.service.ts @@ -1,7 +1,7 @@ import { IProjectView } from "@plane/types"; import { APIService } from "../api.service"; -export class ProjectViewService extends APIService { +export class CoreProjectViewService extends APIService { constructor(baseUrl: string) { super(baseUrl); } diff --git a/packages/services/src/project-view/extended.service.ts b/packages/services/src/project-view/extended.service.ts index a49c89a735..4a10a14df7 100644 --- a/packages/services/src/project-view/extended.service.ts +++ b/packages/services/src/project-view/extended.service.ts @@ -1,6 +1,6 @@ -import { ProjectViewService } from "./core.service"; +import { CoreProjectViewService } from "./core.service"; -export class ExtendedProjectViewService extends ProjectViewService { +export class ExtendedProjectViewService extends CoreProjectViewService { constructor(baseUrl: string) { super(baseUrl); } diff --git a/packages/services/src/project-view/index.ts b/packages/services/src/project-view/index.ts index 7b3ed08b37..4294a932f7 100644 --- a/packages/services/src/project-view/index.ts +++ b/packages/services/src/project-view/index.ts @@ -1,7 +1,8 @@ +import { API_BASE_URL } from "@plane/constants"; import { ExtendedProjectViewService } from "./extended.service"; export class ProjectViewService extends ExtendedProjectViewService { - constructor(baseUrl: string) { - super(baseUrl); + constructor(baseUrl?: string) { + super(baseUrl || API_BASE_URL); } } diff --git a/packages/services/src/project/index.ts b/packages/services/src/project/index.ts index 61cd5313e3..bba2968493 100644 --- a/packages/services/src/project/index.ts +++ b/packages/services/src/project/index.ts @@ -3,6 +3,6 @@ import { ExtendedProjectService } from "./extended.service"; export class ProjectService extends ExtendedProjectService { constructor() { - super(API_BASE_URL || ""); + super(API_BASE_URL); } } diff --git a/packages/services/src/state/index.ts b/packages/services/src/state/index.ts index b945b7121e..10cb01d788 100644 --- a/packages/services/src/state/index.ts +++ b/packages/services/src/state/index.ts @@ -1,7 +1,8 @@ +import { API_BASE_URL } from "@plane/constants"; import { ExtendedStateService } from "./extended.service"; export class StateService extends ExtendedStateService { - constructor(baseUrl: string) { - super(baseUrl); + constructor() { + super(API_BASE_URL); } }