Mirrors/notesnook
1
0
Fork 0
mirror of https://github.com/streetwriters/notesnook.git synced 2026-05-18 05:05:36 +02:00
Code Issues Packages Projects Releases Wiki Activity
15,086 Commits 533 Branches 376 Tags
master
Commit Graph

874 Commits

Author SHA1 Message Date
01zulfi
ed38bb6299 editor: fix crash in backspace handler (#9740) 
* editor: fix crash in backspace handler
* replace nextNode with .nodeAfter

Signed-off-by: 01zulfi <85733202+01zulfi@users.noreply.github.com>

* editor: fix position of node when deleting nextNode

---------

Signed-off-by: 01zulfi <85733202+01zulfi@users.noreply.github.com>
Co-authored-by: Abdullah Atta <abdullahatta@streetwriters.co>
 2026-04-28 09:08:31 +05:00
Ammar Ahmed
92c1ca7b6f mobile: fix configure toolbar do not render properly on adding/removing groups (#9699) 
* editor: make editor tools object a function

Required for string localization to work properly

* mobile: fix tools and groups do not re-render properly on changing preset or adding tools

* mobile: fix empty toast message shows on removing tools from group
 2026-04-14 22:46:41 +05:00
01zulfi
71088fca99 editor: handle crash on inserting incorrect syntax in math nodes (#9690) 
* editor: handle crash on inserting incorrect syntax in math nodes
Signed-off-by: 01zulfi <85733202+01zulfi@users.noreply.github.com>

* editor: fix 'math error' text shown on newly empty math node
Signed-off-by: 01zulfi <85733202+01zulfi@users.noreply.github.com>
 2026-04-13 20:35:57 +05:00
01zulfi
d6f7f0c0be editor: fix crash when app is unlocked after a relock (#9698) 
Signed-off-by: 01zulfi <85733202+01zulfi@users.noreply.github.com>
 2026-04-13 20:35:16 +05:00
Abdullah Atta
ae82a8c0a0 editor: only allow resizing column from resize handle 2026-04-06 23:49:04 +05:00
Abdullah Atta
71b03a90dd editor: disable scroll during column resize 2026-04-06 21:01:25 +05:00
Abdullah Atta
728e50cd13 editor: fix awkward selection behaviour in table cells 
this includes fixes to multiple UX bugs:

1. scroll now stops when user starts cell selection
2. moving cell selection to either edge auto scrolls the table
3. text selection does not trigger cell selection
 2026-04-06 21:00:23 +05:00
01zulfi
092f15406c editor: fix table column toolbar not showing in correct position (#9583) 
* editor: fix table column toolbar not showing in correct position
* also scroll to the newly created column if it is not visible

Signed-off-by: 01zulfi <85733202+01zulfi@users.noreply.github.com>

* editor: use tr.scrollIntoView instead of manually adjusting position on new column
Signed-off-by: 01zulfi <85733202+01zulfi@users.noreply.github.com>

* editor: add tr.scrollIntoView() for table's selectRow()
Signed-off-by: 01zulfi <85733202+01zulfi@users.noreply.github.com>

---------

Signed-off-by: 01zulfi <85733202+01zulfi@users.noreply.github.com>
 2026-03-31 13:28:03 +05:00
01zulfi
f9738168e5 editor: fix callout first heading being collapsed/expanded if clicked towards right of it (#9547) 
Signed-off-by: 01zulfi <85733202+01zulfi@users.noreply.github.com>
 2026-03-30 20:15:03 +05:00
01zulfi
46f5a2d7a7 editor: check for permission before pasting images (#9587) 
Signed-off-by: 01zulfi <85733202+01zulfi@users.noreply.github.com>
 2026-03-26 23:19:31 +05:00
Abdullah Atta
558beaf216 desktop: fix error 153 in youtube embeds (#9510) 
* desktop: fix error 153 in youtube embeds

* editor: update @social-embed/lib
 2026-03-20 16:47:44 +05:00
01zulfi
d5fa9fd02b editor: remove vertical offset on link hover popup (#9487) 
Signed-off-by: 01zulfi <85733202+01zulfi@users.noreply.github.com>
 2026-03-19 09:47:51 +05:00
01zulfi
5185273b38 editor: sandbox clip iframe (#9521) 
* editor: sandbox clip iframe
Signed-off-by: 01zulfi <85733202+01zulfi@users.noreply.github.com>

* editor: render webclips via bloburl with strict sandboxing

---------

Co-authored-by: Abdullah Atta <abdullahatta@streetwriters.co>
 2026-03-17 09:15:57 +05:00
Abdullah Atta
ffafd2e787 editor: fix marks lost on node split 2026-03-05 12:26:59 +05:00
Abdullah Atta
8500c971eb editor: fix font family not reflected in toolbar 2026-03-05 12:26:59 +05:00
Copilot
d5bf8a6e3c editor: fix backticks create inline code even with Markdown Shortcuts disabled (#9415) 2026-03-02 10:29:21 +05:00
Copilot
26a9086d96 editor: fix TOC active heading detection (#9413) 
* Initial plan

* fix: compute heading offsets relative to editor root for correct TOC highlighting

Headings inside callout blocks had incorrect `offsetTop` values because
`offsetTop` is relative to the nearest positioned ancestor (the callout),
not the editor root. This caused the TOC to highlight wrong sections.

Fix: walk the `offsetParent` chain from the heading up to the editor
content element, accumulating `offsetTop` values to get the correct
absolute position within the editor.

Co-authored-by: thecodrr <7473959+thecodrr@users.noreply.github.com>

* editor: ignore callouts from toc

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: thecodrr <7473959+thecodrr@users.noreply.github.com>
Co-authored-by: Abdullah Atta <abdullahatta@streetwriters.co>
 2026-03-02 09:34:53 +05:00
Ammar Ahmed
f778d83316 editor: prevent audio element request attachment data multiple times 2026-02-26 10:53:32 +05:00
Abdullah Atta
d635c1a056 Merge pull request #9364 from streetwriters/editor/audio-playback 
editor: support audio attachment playback
 2026-02-24 11:06:50 +05:00
Abdullah Atta
8c74324ff8 editor: handle attachments based on mime type 2026-02-24 10:29:58 +05:00
01zulfi
f2230eb39b editor: disallow inserting empty embed urls/code (#9392) 
Signed-off-by: 01zulfi <85733202+01zulfi@users.noreply.github.com>
 2026-02-24 09:50:38 +05:00
Abdullah Atta
ab900ae5da editor: various fixes and improvements related to audio widget 2026-02-24 09:36:47 +05:00
Abdullah Atta
5d922d934c Merge branch 'master' into beta 2026-02-21 10:36:37 +05:00
Abdullah Atta
656f87e3c6 editor: fix crash if embed url is invalid or empty 2026-02-21 10:30:18 +05:00
01zulfi
add1b8a68a editor: support audio attachment playback 
Co-authored-by: Hamish <133548095+Hamster45105@users.noreply.github.com>
Signed-off-by: 01zulfi <85733202+01zulfi@users.noreply.github.com>
 2026-02-18 11:24:45 +05:00
01zulfi
50136e3689 editor: use last set code language as default (#7086) 
Co-authored-by: Abdullah Atta <abdullahatta@streetwriters.co>
 2026-02-12 13:49:52 +05:00
01zulfi
e87f5e5f89 editor: escape html in twitter embed src (#9326) 
Signed-off-by: 01zulfi <85733202+01zulfi@users.noreply.github.com>
 2026-02-10 12:33:56 +05:00
01zulfi
994060cce2 editor: allow attaching image as file (#8752) 
* editor: allow attaching image as file
Signed-off-by: 01zulfi <85733202+01zulfi@users.noreply.github.com>

* web: fix image previews for regular attachments

* mobile: allow images to be added as attachment without preview

* web: minor refactor
Signed-off-by: 01zulfi <85733202+01zulfi@users.noreply.github.com>

---------

Co-authored-by: Ammar Ahmed <ammarahmed6506@gmail.com>
 2026-02-02 10:26:03 +05:00
Abdullah Atta
1d8a958eaf editor: update test snapshots 2026-01-26 13:07:35 +05:00
01zulfi
60df472d53 editor: fix search scroll not working on switching editors or opening new editor (#8061) 
* editor: fix search scroll not working on switching editors or opening new editor
Signed-off-by: 01zulfi <85733202+01zulfi@users.noreply.github.com>

* editor: initialize search right after editor is created
Signed-off-by: 01zulfi <85733202+01zulfi@users.noreply.github.com>
 2026-01-19 11:59:48 +05:00
01zulfi
076cea6d6d editor: add scrollbar to color picker (#8065) 
Signed-off-by: 01zulfi <85733202+01zulfi@users.noreply.github.com>
 2026-01-16 19:22:08 +05:00
01zulfi
bfedc1f43e editor: replace simplebar with simple css styling (#9085) 
Signed-off-by: 01zulfi <85733202+01zulfi@users.noreply.github.com>
 2026-01-16 14:24:11 +05:00
Abdullah Atta
1025c4ec6e editor: minor refactors 2026-01-16 11:17:49 +05:00
Abdullah Atta
c44f9f685d editor: parse csv directly to prosemirror nodes 2026-01-16 11:17:33 +05:00
Ammar Ahmed
ee139463d2 mobile: export table to csv 2026-01-16 10:58:17 +05:00
01zulfi
2cf7f0cc27 editor: add options to export/import table <> csv 
Signed-off-by: 01zulfi <85733202+01zulfi@users.noreply.github.com>
 2026-01-16 10:58:17 +05:00
01zulfi
09cba1a1df editor: fix youtube embeds erroring with code 153 (#9180) 
* web: add referer header with content origin
* youtube embeds aren't working without adding this header

Signed-off-by: 01zulfi <85733202+01zulfi@users.noreply.github.com>

* editor: use corsHost for youtube embeds

* editor: make youtube embed detection more robust

* web: remove referrer meta tag

---------

Signed-off-by: 01zulfi <85733202+01zulfi@users.noreply.github.com>
Co-authored-by: Ammar Ahmed <ammarahmed6506@gmail.com>
Co-authored-by: Abdullah Atta <abdullahatta@streetwriters.co>
 2026-01-15 19:22:46 +05:00
01zulfi
966673dfd1 editor: add clear current node keyboard shortcut (#7272) 
Signed-off-by: 01zulfi <85733202+01zulfi@users.noreply.github.com>
 2026-01-15 10:38:33 +05:00
Abdullah Atta
7e87cf7fdc Merge pull request #9170 from streetwriters/editor/fix-line-height-css-issues 
editor: fix icons not aligning in outline,task,check lists & callouts because of custom line height
 2026-01-14 13:52:36 +05:00
01zulfi
22a6271423 editor: fix duplicate block-id on splitting node (#9198) 
Signed-off-by: 01zulfi <85733202+01zulfi@users.noreply.github.com>
 2026-01-14 10:56:31 +05:00
01zulfi
e0c31d6fdd editor: fix icons not aligning in outline,task,check lists & callouts because of custom line height 
Signed-off-by: 01zulfi <85733202+01zulfi@users.noreply.github.com>
 2026-01-07 14:05:57 +05:00
Abdullah Atta
fa0a5afa63 Merge pull request #9113 from streetwriters/editor/collapsible-headings-perf 
editor: improve collapsible heading performance
 2026-01-02 09:43:06 +05:00
01zulfi
b881b236a0 editor: export & use AttributeUpdate interface 
Signed-off-by: 01zulfi <85733202+01zulfi@users.noreply.github.com>
 2026-01-01 15:23:27 +05:00
01zulfi
50666c1307 editor: add a collapsible heading test case 
Signed-off-by: 01zulfi <85733202+01zulfi@users.noreply.github.com>
 2025-12-31 15:33:21 +05:00
01zulfi
200c9bd9eb editor: improve checks to not unecessary call toggle fn in heading update plugin 
Signed-off-by: 01zulfi <85733202+01zulfi@users.noreply.github.com>
 2025-12-31 15:01:14 +05:00
01zulfi
5c21c0a498 global: support day format options & $day$ title format & /day command 
Signed-off-by: 01zulfi <85733202+01zulfi@users.noreply.github.com>
 2025-12-31 14:54:44 +05:00
01zulfi
7a12fd701e editor: batch update hidden attribute when toggling headings 
Signed-off-by: 01zulfi <85733202+01zulfi@users.noreply.github.com>
 2025-12-30 16:53:02 +05:00
01zulfi
8298900f76 editor: support ctrl+c for images (#8386) 
* editor: support ctrl+c for images
Signed-off-by: 01zulfi <85733202+01zulfi@users.noreply.github.com>

* editor: add test for copy image functionality
Signed-off-by: 01zulfi <85733202+01zulfi@users.noreply.github.com>
 2025-12-30 13:46:24 +05:00
01zulfi
255677d98e editor: improve headingUpdatePlugin performance 
Signed-off-by: 01zulfi <85733202+01zulfi@users.noreply.github.com>
 2025-12-29 14:23:16 +05:00
01zulfi
41094c80d5 editor: add move line up/down keybinding (#7078) 
* editor: add move line up/down keybinding
Signed-off-by: 01zulfi <85733202+01zulfi@users.noreply.github.com>

* docs: update keyboard shortcuts

* editor: add missing changes

* editor: add move parent node up/down keyboard shortcut
Signed-off-by: 01zulfi <85733202+01zulfi@users.noreply.github.com>

* editor: refactor moveNode fn && add a test case
Signed-off-by: 01zulfi <85733202+01zulfi@users.noreply.github.com>

* editor: improve move node logic
Signed-off-by: 01zulfi <85733202+01zulfi@users.noreply.github.com>

---------

Co-authored-by: Abdullah Atta <abdullahatta@streetwriters.co>
 2025-12-23 12:39:30 +05:00