* core: fix quoted & repeated tag/color filters in search query
* fix extra quotes being added for multi word tag/color filter
* fix multiple tag/color filters not working
Signed-off-by: 01zulfi <85733202+01zulfi@users.noreply.github.com>
* core: prevent db.lookup.notesWithHighlighting from mutating the passed in selector
The FilteredSelector passed into notesWithHighlighting was being mutated. This wasn't an issue in the apps/web because a fresh selector was passed in for every query. But on apps/mobile, the same selector is reused for every query on the search page.
The bug only became apparent when passing in a query like `tag:one`, then after the results came in, continuing the query: `tag:one tag:two`. This only showed results from tag:one since the selector was mutated by the previous lookup.
The mutation happens in FilteredSelector's where method. So, the bug is fixed by cloning the selector before the where method call in notesWithHighlighting.
Signed-off-by: 01zulfi <85733202+01zulfi@users.noreply.github.com>
---------
Signed-off-by: 01zulfi <85733202+01zulfi@users.noreply.github.com>
* mobile: pass value for items when searching on main screen to match other screens' pattern
Signed-off-by: Suyadi <afsuyadi@gmail.com>
* core: guard notesWithHighlighting against an undefined notes selector.
Signed-off-by: Suyadi <afsuyadi@gmail.com>
* core: add regression test for notesWithHighlighting crash.
Signed-off-by: Suyadi <afsuyadi@gmail.com>
* core: revert changes after feedback
Signed-off-by: Suyadi <afsuyadi@gmail.com>
* mobile: ensure type: "note" will make items become mandatory.
Signed-off-by: Suyadi <afsuyadi@gmail.com>
* core: remove tests after feedback
Signed-off-by: Suyadi <afsuyadi@gmail.com>
* core: do not throw error if inboxitemshistory table already exists during migration
* core: add ensure column check to avoid `column already exists` errors
---------
Co-authored-by: Abdullah Atta <abdullahatta@streetwriters.co>
* use user format preferences for dates in inbox module
* delete all failed inbox items when inbox is disabled
* improve error message for failed validation case
Signed-off-by: 01zulfi <85733202+01zulfi@users.noreply.github.com>
* after saving new keys, we didn't clear the cache so getInboxKeys() was still returning old keys
* remove unnecessary JSON.stringify on private key in saveInboxKeys()
Signed-off-by: 01zulfi <85733202+01zulfi@users.noreply.github.com>
* core: handle different issue report responses
* web: better handling for issue report responses
* mobile: update issue report dialog to show correct info of where issue is reported
* mobile: close sheet on clicking "done"
* web: do not include email in issue success dialog
---------
Co-authored-by: Ammar Ahmed <ammarahmed6506@gmail.com>
