Mirrors/notesnook
1
0
Fork 0
mirror of https://github.com/streetwriters/notesnook.git synced 2025-12-24 15:39:44 +01:00
Code Issues Packages Projects Releases Wiki Activity
14,413 Commits 426 Branches 343 Tags
editor/readonly-table-fixes
Commit Graph

3650 Commits

Author SHA1 Message Date
Abdullah Atta
5962f059ce editor: remove table view 2025-11-27 12:03:43 +05:00
01zulfi
4991bdf689 editor: readonly table fixes 
* fix tables not hiding under collapsed headings in readonly view
* allow column resizing in readonly view
* fix scrollbar not showing in readonly view

Signed-off-by: 01zulfi <85733202+01zulfi@users.noreply.github.com>
 2025-11-27 11:56:52 +05:00
01zulfi
573b24f28f editor: fix heading align (#8996) 
this reverts all the custom layout based on divs & spans and moves back to using pseudo element for the expand/collapse icon.

There were a few problems with the previous logic:

1. We had to write custom logic for text alignment (not a huge deal but it could cause bugs down the line)
2. Aligning the icon properly was hit or miss. We were using flex which meant for multi line headings, the icon appeared way to the left instead of right next to the end of the heading.
3. The styling css for the previous logic was MASSIVE and handled lots of cases which meant more maintenance burden for us.

The new logic is simpler:

1. Use `::after` pseudo element for the expand/collapse icon. This works very nicely on Android.
2. Use selection range on the heading to compute bounding rects for each line. It's a bit hacky but works for both LTR & RTL headings.

---------

Signed-off-by: 01zulfi <85733202+01zulfi@users.noreply.github.com>
Co-authored-by: 01zulfi <85733202+01zulfi@users.noreply.github.com>
Co-authored-by: Abdullah Atta <abdullahatta@streetwriters.co>
 2025-11-27 11:43:27 +05:00
01zulfi
6473ce4244 editor: unhide children when collapsed heading is changed to non-heading node (#8946) 
Signed-off-by: 01zulfi <85733202+01zulfi@users.noreply.github.com>
 2025-11-27 11:43:27 +05:00
01zulfi
82685314f7 editor: improve table cell styling (#8960) 
Signed-off-by: 01zulfi <85733202+01zulfi@users.noreply.github.com>
 2025-11-27 11:43:27 +05:00
01zulfi
c1370af395 editor: change heading collapse icon pos (#8953) 
* editor: enable heading in table, change collapse icon pos, && disable empty heading collapse
Signed-off-by: 01zulfi <85733202+01zulfi@users.noreply.github.com>

* editor: migrate empty collapsed headings in parseHTML instead of plugin
Signed-off-by: 01zulfi <85733202+01zulfi@users.noreply.github.com>

* editor: remove migration for empty collapsed headings
Signed-off-by: 01zulfi <85733202+01zulfi@users.noreply.github.com>

* editor: fix heading collapse on mobile
Signed-off-by: 01zulfi <85733202+01zulfi@users.noreply.github.com>

* editor: use ontouchend instead of ontouchstart

---------

Co-authored-by: Abdullah Atta <abdullahatta@streetwriters.co>
 2025-11-27 11:43:27 +05:00
Abdullah Atta
3de225f7c9 mobile: upgrade react native 0.82 
this commit also bump app version to 3.3.10-beta.0
 2025-11-27 11:32:50 +05:00
Abdullah Atta
1d6ff96dd9 Merge pull request #8930 from streetwriters/feat/improve-tables-on-mobile 2025-11-27 11:12:43 +05:00
Abdullah Atta
9f403b9d7f Merge branch 'master' into beta 2025-11-27 11:04:57 +05:00
01zulfi
30466e4a76 editor: fade checklist when checked 
Signed-off-by: 01zulfi <85733202+01zulfi@users.noreply.github.com>

Update packages/editor/styles/styles.css

Signed-off-by: Abdullah Atta <thecodrr@protonmail.com>
 2025-11-24 09:38:16 +05:00
Abdullah Atta
97d21c818e Merge pull request #8858 from 01zulfi/editor/disable-collapsible-headings-in-table 
editor: disable collapsible headings inside tables
 2025-11-12 11:30:38 +05:00
Abdullah Atta
3beb60d8b6 Merge pull request #8918 from streetwriters/core/fix-keys-reencryption-on-update-password 
core: fix user keys re-encryption when updating password
 2025-11-12 11:29:03 +05:00
Abdullah Atta
3d00502341 editor: fix table column/row tool sizing 2025-11-12 11:23:16 +05:00
Abdullah Atta
7975dfcc78 editor: fix recursive enter in tables on mobile 2025-11-12 11:23:16 +05:00
Abdullah Atta
907406e7b2 editor: add support for resize on hover 2025-11-12 11:23:16 +05:00
Abdullah Atta
8b03f96a3f editor: fix column resize handle hiding after column resize 2025-11-12 11:23:16 +05:00
Abdullah Atta
5183b33f9d editor: fix type errors 2025-11-12 11:23:16 +05:00
Abdullah Atta
bfddf288eb editor: massive improvements to tables on mobile 
- resizable columns
- cell selection
 2025-11-12 11:23:16 +05:00
01zulfi
f728ad8826 editor: disable collapsible headings inside tables 
Signed-off-by: 01zulfi <85733202+01zulfi@users.noreply.github.com>
 2025-11-11 11:39:41 +05:00
Abdullah Atta
33c3bf0d69 Merge pull request #8919 from streetwriters/web/show-monograph-view-count 
web: show monograph's view count
 2025-11-08 13:07:14 +05:00
Abdullah Atta
bd4f130ef8 core: handle errors on monograph analytics fetch 2025-11-08 12:59:17 +05:00
Abdullah Atta
28b563b95b web: make monograph analytics a pro feature 2025-11-08 12:49:36 +05:00
Abdullah Atta
71952a354e core: monographs stats -> monograph analytics 2025-11-08 12:46:58 +05:00
Abdullah Atta
41ad8e0988 web: improve publish view ux 2025-11-07 19:26:32 +05:00
01zulfi
3e87e2ea5a web: use monograph stats api 
Signed-off-by: 01zulfi <85733202+01zulfi@users.noreply.github.com>
 2025-11-07 10:54:15 +05:00
01zulfi
a6541b9731 web: show monograph's view count 
Signed-off-by: 01zulfi <85733202+01zulfi@users.noreply.github.com>
 2025-11-06 14:10:52 +05:00
Abdullah Atta
cc584461ad Merge pull request #8909 from streetwriters/mobile-release-3.3.8 2025-11-05 23:31:34 +05:00
Abdullah Atta
6069a41fa4 Merge pull request #8909 from streetwriters/mobile-release-3.3.8 
Mobile release 3.3.8
 2025-11-05 23:28:48 +05:00
01zulfi
7190207e5c core: fix user keys re-encryption when updating password 
Signed-off-by: 01zulfi <85733202+01zulfi@users.noreply.github.com>
 2025-11-05 14:02:48 +05:00
01zulfi
05ea085cdc Merge pull request #8915 from streetwriters/release/v3.3.5 
Release/v3.3.5
 2025-11-05 13:15:30 +05:00
01zulfi
8e1484a029 editor: fix checklist parsing as bulletlist 
* reduce list-item's parseHTML priority lower than check-list-item's parseHTML priority

Signed-off-by: 01zulfi <85733202+01zulfi@users.noreply.github.com>
 2025-11-05 11:01:52 +05:00
Ammar Ahmed
4a3b3a14ec mobile: release v3.3.8 2025-11-04 10:35:34 +05:00
Abdullah Atta
58f060ae59 Merge pull request #8905 from streetwriters/editor/fix-images-in-lists 2025-11-03 16:14:00 +05:00
Abdullah Atta
d7dde74675 Merge pull request #8905 from streetwriters/editor/fix-images-in-lists 
editor: fix old inline images in bullet,numbered,task&check lists
 2025-11-03 16:13:02 +05:00
01zulfi
5fde1c0f07 editor: fix old inline images in bullet,numbered,task&check lists 
Signed-off-by: 01zulfi <85733202+01zulfi@users.noreply.github.com>
 2025-11-03 16:10:26 +05:00
Abdullah Atta
d9ea44f92a Merge pull request #8857 from 01zulfi/core/escape-paranthesis-in-search 2025-11-03 12:38:33 +05:00
Abdullah Atta
ffddbe2d7a Merge pull request #8857 from 01zulfi/core/escape-paranthesis-in-search 
core: escape paranthesis in notes search query
 2025-11-03 12:37:39 +05:00
01zulfi
eb3998d72d core: remove unnecessary only in tests 
Signed-off-by: 01zulfi <85733202+01zulfi@users.noreply.github.com>
 2025-11-03 12:21:11 +05:00
01zulfi
fca61afd7c core: escape paranthesis in notes search query 
Signed-off-by: 01zulfi <85733202+01zulfi@users.noreply.github.com>
 2025-11-03 11:02:02 +05:00
Abdullah Atta
1bf86386fa Merge pull request #8904 from streetwriters/editor/fix-heading-plugin 2025-11-03 10:29:23 +05:00
01zulfi
38daca0099 editor: fix crash in heading plugin when pasting markdown content 
Signed-off-by: 01zulfi <85733202+01zulfi@users.noreply.github.com>
 2025-11-03 09:01:09 +05:00
Ammar Ahmed
a60a1aa406 Merge branch 'master' into beta 2025-11-01 09:43:46 +05:00
Ammar Ahmed
0dfc1dfa52 mobile: release v3.3.7 2025-10-31 20:02:43 +05:00
Ammar Ahmed
b9c14ef9aa Merge pull request #8888 from streetwriters/fix-clipper-mobile 
mobile: fix share extension not able to clip webpage
 2025-10-31 18:38:59 +05:00
Ammar Ahmed
9aef28b03d Merge pull request #8856 from streetwriters/fix-table-cell-selection-mobile 
Fix table cell selection mobile
 2025-10-31 18:36:56 +05:00
01zulfi
c59091f946 editor: fix changing level of collapsed heading 
* preserve collasped state
* reset visibility of hidden nodes under changed heading

Signed-off-by: 01zulfi <85733202+01zulfi@users.noreply.github.com>
 2025-10-31 14:06:54 +05:00
01zulfi
042656856a editor: fix changing level of collapsed heading 
* preserve collasped state
* reset visibility of hidden nodes under changed heading

Signed-off-by: 01zulfi <85733202+01zulfi@users.noreply.github.com>
 2025-10-31 13:14:06 +05:00
Ammar Ahmed
5921c61e98 mobile: fix share extension not able to clip webpage 2025-10-31 10:01:59 +05:00
Abdullah Atta
6a017c237d Merge branch 'master' into beta 2025-10-30 13:31:01 +05:00
Abdullah Atta
c5cd214d97 Merge pull request #8882 from 01zulfi/editor/fix-collapsible-hidden-under 
editor: fix disappearing nodes under collapsed headings if heading is edited
 2025-10-30 13:29:05 +05:00