Mirrors/notesnook
1
0
Fork 0
mirror of https://github.com/streetwriters/notesnook.git synced 2025-12-24 15:39:44 +01:00
Code Issues Packages Projects Releases Wiki Activity
14,533 Commits 426 Branches 343 Tags
beta
Commit Graph

1042 Commits

Author SHA1 Message Date
01zulfi
41094c80d5 editor: add move line up/down keybinding (#7078) 
* editor: add move line up/down keybinding
Signed-off-by: 01zulfi <85733202+01zulfi@users.noreply.github.com>

* docs: update keyboard shortcuts

* editor: add missing changes

* editor: add move parent node up/down keyboard shortcut
Signed-off-by: 01zulfi <85733202+01zulfi@users.noreply.github.com>

* editor: refactor moveNode fn && add a test case
Signed-off-by: 01zulfi <85733202+01zulfi@users.noreply.github.com>

* editor: improve move node logic
Signed-off-by: 01zulfi <85733202+01zulfi@users.noreply.github.com>

---------

Co-authored-by: Abdullah Atta <abdullahatta@streetwriters.co>
 2025-12-23 12:39:30 +05:00
01zulfi
f6140e8396 editor: fix crash on task list toggle & drag (#9078) 
* make sure column resizing's handleMouseDown correctly checks for handle element

Signed-off-by: 01zulfi <85733202+01zulfi@users.noreply.github.com>
 2025-12-23 10:55:28 +05:00
01zulfi
5171b2e5e2 editor: fix scroll for tables in mobile 
Signed-off-by: 01zulfi <85733202+01zulfi@users.noreply.github.com>
 2025-12-18 10:20:10 +05:00
Abdullah Atta
b5a706a6a9 editor: fix TouchEvent is not defined when resizing columns 2025-12-17 14:40:25 +05:00
01zulfi
a4d29f3e7a editor: hide expand/collapse icon for empty headings (#9063) 
Signed-off-by: 01zulfi <85733202+01zulfi@users.noreply.github.com>
 2025-12-17 14:18:30 +05:00
Abdullah Atta
dfc4cbe01f Merge pull request #9042 from streetwriters/editor/fix-callout-heading 
editor: fix callout collapse/expand on clicking right after its heading
 2025-12-12 09:57:56 +05:00
01zulfi
2cdfe2c158 editor: add shortcut to open search and replace (#9043) 
Signed-off-by: 01zulfi <85733202+01zulfi@users.noreply.github.com>
 2025-12-11 11:28:15 +05:00
01zulfi
d1dfafe1da editor: fix callout collapse/expand on clicking right after its heading 
Signed-off-by: 01zulfi <85733202+01zulfi@users.noreply.github.com>
 2025-12-10 14:36:50 +05:00
01zulfi
121e521eb7 editor: hide horizontal rule if its under a collapsed heading (#9038) 
Signed-off-by: 01zulfi <85733202+01zulfi@users.noreply.github.com>
 2025-12-10 10:01:14 +05:00
Abdullah Atta
db4d998705 editor: fix TouchEvent is not defined 2025-12-03 13:59:36 +05:00
Ammar Ahmed
65ae22e70e Merge branch 'mobile-release-3.3.10-beta.2' into beta 2025-12-01 10:05:46 +05:00
01zulfi
81da60333d editor: fade all nodes inside a checklist item except for a nested checklist (#9008) 
Signed-off-by: 01zulfi <85733202+01zulfi@users.noreply.github.com>
 2025-11-29 12:37:36 +05:00
01zulfi
aa572febd4 editor: add toggle text color keybinding (#9010) 
Signed-off-by: 01zulfi <85733202+01zulfi@users.noreply.github.com>
 2025-11-29 12:36:09 +05:00
Ammar Ahmed
6060cb457d mobile: fix failing build errors on android 2025-11-29 00:01:56 +05:00
01zulfi
ed2a04d590 editor: improve inline code styling (#8987) 
* editor: improve inline code styling
Signed-off-by: 01zulfi <85733202+01zulfi@users.noreply.github.com>

* editor: remove top&bottom padding from inline code
* it was cutting off a bit of text from top&bottom lines

Signed-off-by: 01zulfi <85733202+01zulfi@users.noreply.github.com>

* editor: update text color of inline code
Signed-off-by: 01zulfi <85733202+01zulfi@users.noreply.github.com>

* editor: adjust font size and padding of inline code

---------

Signed-off-by: 01zulfi <85733202+01zulfi@users.noreply.github.com>
Co-authored-by: Abdullah Atta <abdullahatta@streetwriters.co>
 2025-11-27 12:05:16 +05:00
01zulfi
52a3d1c373 editor: readonly table fixes (#8997) 
* editor: readonly table fixes
* fix tables not hiding under collapsed headings in readonly view
* allow column resizing in readonly view
* fix scrollbar not showing in readonly view

Signed-off-by: 01zulfi <85733202+01zulfi@users.noreply.github.com>

* editor: remove table view

---------

Signed-off-by: 01zulfi <85733202+01zulfi@users.noreply.github.com>
Co-authored-by: Abdullah Atta <abdullahatta@streetwriters.co>
 2025-11-27 12:04:23 +05:00
01zulfi
573b24f28f editor: fix heading align (#8996) 
this reverts all the custom layout based on divs & spans and moves back to using pseudo element for the expand/collapse icon.

There were a few problems with the previous logic:

1. We had to write custom logic for text alignment (not a huge deal but it could cause bugs down the line)
2. Aligning the icon properly was hit or miss. We were using flex which meant for multi line headings, the icon appeared way to the left instead of right next to the end of the heading.
3. The styling css for the previous logic was MASSIVE and handled lots of cases which meant more maintenance burden for us.

The new logic is simpler:

1. Use `::after` pseudo element for the expand/collapse icon. This works very nicely on Android.
2. Use selection range on the heading to compute bounding rects for each line. It's a bit hacky but works for both LTR & RTL headings.

---------

Signed-off-by: 01zulfi <85733202+01zulfi@users.noreply.github.com>
Co-authored-by: 01zulfi <85733202+01zulfi@users.noreply.github.com>
Co-authored-by: Abdullah Atta <abdullahatta@streetwriters.co>
 2025-11-27 11:43:27 +05:00
01zulfi
6473ce4244 editor: unhide children when collapsed heading is changed to non-heading node (#8946) 
Signed-off-by: 01zulfi <85733202+01zulfi@users.noreply.github.com>
 2025-11-27 11:43:27 +05:00
01zulfi
82685314f7 editor: improve table cell styling (#8960) 
Signed-off-by: 01zulfi <85733202+01zulfi@users.noreply.github.com>
 2025-11-27 11:43:27 +05:00
01zulfi
c1370af395 editor: change heading collapse icon pos (#8953) 
* editor: enable heading in table, change collapse icon pos, && disable empty heading collapse
Signed-off-by: 01zulfi <85733202+01zulfi@users.noreply.github.com>

* editor: migrate empty collapsed headings in parseHTML instead of plugin
Signed-off-by: 01zulfi <85733202+01zulfi@users.noreply.github.com>

* editor: remove migration for empty collapsed headings
Signed-off-by: 01zulfi <85733202+01zulfi@users.noreply.github.com>

* editor: fix heading collapse on mobile
Signed-off-by: 01zulfi <85733202+01zulfi@users.noreply.github.com>

* editor: use ontouchend instead of ontouchstart

---------

Co-authored-by: Abdullah Atta <abdullahatta@streetwriters.co>
 2025-11-27 11:43:27 +05:00
Abdullah Atta
1d6ff96dd9 Merge pull request #8930 from streetwriters/feat/improve-tables-on-mobile 2025-11-27 11:12:43 +05:00
Abdullah Atta
9f403b9d7f Merge branch 'master' into beta 2025-11-27 11:04:57 +05:00
01zulfi
30466e4a76 editor: fade checklist when checked 
Signed-off-by: 01zulfi <85733202+01zulfi@users.noreply.github.com>

Update packages/editor/styles/styles.css

Signed-off-by: Abdullah Atta <thecodrr@protonmail.com>
 2025-11-24 09:38:16 +05:00
Abdullah Atta
3d00502341 editor: fix table column/row tool sizing 2025-11-12 11:23:16 +05:00
Abdullah Atta
7975dfcc78 editor: fix recursive enter in tables on mobile 2025-11-12 11:23:16 +05:00
Abdullah Atta
907406e7b2 editor: add support for resize on hover 2025-11-12 11:23:16 +05:00
Abdullah Atta
8b03f96a3f editor: fix column resize handle hiding after column resize 2025-11-12 11:23:16 +05:00
Abdullah Atta
5183b33f9d editor: fix type errors 2025-11-12 11:23:16 +05:00
Abdullah Atta
bfddf288eb editor: massive improvements to tables on mobile 
- resizable columns
- cell selection
 2025-11-12 11:23:16 +05:00
01zulfi
f728ad8826 editor: disable collapsible headings inside tables 
Signed-off-by: 01zulfi <85733202+01zulfi@users.noreply.github.com>
 2025-11-11 11:39:41 +05:00
01zulfi
05ea085cdc Merge pull request #8915 from streetwriters/release/v3.3.5 
Release/v3.3.5
 2025-11-05 13:15:30 +05:00
01zulfi
8e1484a029 editor: fix checklist parsing as bulletlist 
* reduce list-item's parseHTML priority lower than check-list-item's parseHTML priority

Signed-off-by: 01zulfi <85733202+01zulfi@users.noreply.github.com>
 2025-11-05 11:01:52 +05:00
Abdullah Atta
58f060ae59 Merge pull request #8905 from streetwriters/editor/fix-images-in-lists 2025-11-03 16:14:00 +05:00
01zulfi
5fde1c0f07 editor: fix old inline images in bullet,numbered,task&check lists 
Signed-off-by: 01zulfi <85733202+01zulfi@users.noreply.github.com>
 2025-11-03 16:10:26 +05:00
Abdullah Atta
1bf86386fa Merge pull request #8904 from streetwriters/editor/fix-heading-plugin 2025-11-03 10:29:23 +05:00
01zulfi
38daca0099 editor: fix crash in heading plugin when pasting markdown content 
Signed-off-by: 01zulfi <85733202+01zulfi@users.noreply.github.com>
 2025-11-03 09:01:09 +05:00
Ammar Ahmed
a60a1aa406 Merge branch 'master' into beta 2025-11-01 09:43:46 +05:00
Ammar Ahmed
9aef28b03d Merge pull request #8856 from streetwriters/fix-table-cell-selection-mobile 
Fix table cell selection mobile
 2025-10-31 18:36:56 +05:00
01zulfi
c59091f946 editor: fix changing level of collapsed heading 
* preserve collasped state
* reset visibility of hidden nodes under changed heading

Signed-off-by: 01zulfi <85733202+01zulfi@users.noreply.github.com>
 2025-10-31 14:06:54 +05:00
01zulfi
042656856a editor: fix changing level of collapsed heading 
* preserve collasped state
* reset visibility of hidden nodes under changed heading

Signed-off-by: 01zulfi <85733202+01zulfi@users.noreply.github.com>
 2025-10-31 13:14:06 +05:00
Abdullah Atta
6a017c237d Merge branch 'master' into beta 2025-10-30 13:31:01 +05:00
Abdullah Atta
c5cd214d97 Merge pull request #8882 from 01zulfi/editor/fix-collapsible-hidden-under 
editor: fix disappearing nodes under collapsed headings if heading is edited
 2025-10-30 13:29:05 +05:00
Abdullah Atta
b30c35e59d Merge pull request #8877 from 01zulfi/editor/fix-outline-images 
editor: fix images from older version not rendering in outline list
 2025-10-30 13:28:00 +05:00
01zulfi
ce4fa13758 editor: fix disappearing nodes under collapsed headings if heading is edited 
* design flaw in using the hiddenUnder attribute on hidden nodes, a hidden attribute should be sufficient

Signed-off-by: 01zulfi <85733202+01zulfi@users.noreply.github.com>
 2025-10-30 12:59:50 +05:00
01zulfi
1f47df0f45 editor: add test case to assert migration of old inline images in outline list item 
Signed-off-by: 01zulfi <85733202+01zulfi@users.noreply.github.com>
 2025-10-30 12:53:21 +05:00
Abdullah Atta
27c641536a editor: add support for twitter embeds (#8879) 2025-10-30 12:02:25 +05:00
01zulfi
78e4672871 editor: fix images from older version not rendering in outline list 
Signed-off-by: 01zulfi <85733202+01zulfi@users.noreply.github.com>
 2025-10-29 13:12:39 +05:00
Abdullah Atta
dbecd6a466 Merge pull request #8743 from 01zulfi/editor/restrict-attachment-for-notloggedin-users 
editor: restrict attachment upload for not logged-in users
 2025-10-29 12:35:53 +05:00
Abdullah Atta
17b14e0ac6 Merge pull request #8875 from streetwriters/fix-remove-line-through-checklist 
Fix remove line through checklist
 2025-10-29 11:53:58 +05:00
Ammar Ahmed
7eefecd961 editor: do not strikethrough on checked item in checklist 2025-10-29 11:38:32 +05:00