From fe364b79327520bbce86b3b319e50a6ff016fed2 Mon Sep 17 00:00:00 2001 From: 01zulfi <85733202+01zulfi@users.noreply.github.com> Date: Tue, 7 Jan 2025 12:00:46 +0500 Subject: [PATCH] web: fix faulty useEffect Signed-off-by: 01zulfi <85733202+01zulfi@users.noreply.github.com> --- apps/web/src/app.tsx | 17 ++++++++++++++--- 1 file changed, 14 insertions(+), 3 deletions(-) diff --git a/apps/web/src/app.tsx b/apps/web/src/app.tsx index 0250e3372..15fc41c39 100644 --- a/apps/web/src/app.tsx +++ b/apps/web/src/app.tsx @@ -154,8 +154,16 @@ function DesktopAppContents({ show, setShow }: DesktopAppContentsProps) { const [isSideMenuOpen, setIsSideMenuOpen] = useState(false); useEffect(() => { - AppEventManager.subscribe(AppEvents.toggleSideMenu, setIsSideMenuOpen); - }); + const { unsubscribe } = AppEventManager.subscribe( + AppEvents.toggleSideMenu, + (state) => { + setIsSideMenuOpen(Boolean(state)); + } + ); + return () => { + unsubscribe(); + }; + }, []); useEffect(() => { if (isTablet) navPane.current?.collapse(0); @@ -193,7 +201,10 @@ function DesktopAppContents({ show, setShow }: DesktopAppContentsProps) { background: "rgba(0,0,0,0.5)" }} onClick={() => { - AppEventManager.publish(AppEvents.toggleSideMenu); + AppEventManager.publish( + AppEvents.toggleSideMenu, + !isSideMenuOpen + ); }} />