From 66209c7a4b4c845187140e40c41f9f38c6478a26 Mon Sep 17 00:00:00 2001 From: thecodrr Date: Sun, 1 Dec 2019 00:01:09 +0500 Subject: [PATCH 1/2] feat: use longer (150 char) headline --- packages/core/api/database.js | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/packages/core/api/database.js b/packages/core/api/database.js index c96b767a7..2f08d83ec 100644 --- a/packages/core/api/database.js +++ b/packages/core/api/database.js @@ -26,7 +26,8 @@ class Database { * @param {object} note The note to add or update */ async addNote(note) { - if (!note || !note.content || note.content.length <= 0) return undefined; + if (!note || !note.content || (!note.title && !note.content)) + return undefined; let timestamp = note.dateCreated || Date.now(); //add or update a note into the database @@ -44,7 +45,7 @@ class Database { notebooks: note.notebooks || [], colors: note.colors || [], favorite: note.favorite || false, - headline: note.content.text.substring(0, 60), + headline: note.content.text.substring(0, 150) + "...", length: note.content.text.length, dateEditted: Date.now(), dateCreated: timestamp From 66ba9c4f9f96e6b2bdeef80b481c545f226c69d5 Mon Sep 17 00:00:00 2001 From: thecodrr Date: Sun, 1 Dec 2019 00:13:59 +0500 Subject: [PATCH 2/2] refactor: slight performance improvements --- packages/core/api/database.js | 5 +++-- packages/core/utils/index.js | 7 +++++++ 2 files changed, 10 insertions(+), 2 deletions(-) create mode 100644 packages/core/utils/index.js diff --git a/packages/core/api/database.js b/packages/core/api/database.js index 2f08d83ec..d3f0acd10 100644 --- a/packages/core/api/database.js +++ b/packages/core/api/database.js @@ -1,6 +1,7 @@ import Storage from "../helpers/storage"; import fuzzysearch from "fuzzysearch"; import ff from "fast-filter"; +import { extractValues } from "../utils"; const KEYS = { notes: "notes" @@ -18,7 +19,7 @@ class Database { async getNotes() { //update our cache this.notes = (await this.storage.read(KEYS.notes)) || {}; - return Object.values(this.notes); + return extractValues(this.notes); } /** @@ -89,7 +90,7 @@ class Database { if (!notes) return; return ff( notes, - v => fuzzysearch(query, v.title) || fuzzysearch(query, v.content.text), + v => fuzzysearch(query, v.title + " " + v.content.text), this ); } diff --git a/packages/core/utils/index.js b/packages/core/utils/index.js new file mode 100644 index 000000000..2d683cc29 --- /dev/null +++ b/packages/core/utils/index.js @@ -0,0 +1,7 @@ +export function extractValues(obj) { + const t = []; + for (var key in obj) { + t[t.length] = obj[key]; + } + return t; +}