Mirrors/notesnook
1
0
Fork 0
mirror of https://github.com/streetwriters/notesnook.git synced 2025-12-23 06:59:31 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix: do not update lastSynced time on SSE sync

Browse Source 
we won't be updating lastSynced time because it can
cause the lastSynced time to move ahead of any last edited
(but unsynced) note resulting in edited notes not getting synced.
This commit is contained in:
thecodrr
2021-02-22 09:33:30 +05:00
parent 465b651587
commit df4c98b27b
1 changed files with 8 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
packages/core/api/sync/index.js
View File

@@ -98,10 +98,14 @@ export default class Sync {
// check for conflicts and throw
// await this._db.conflicts.check();
// update our lastSynced time
if (serverResponse.lastSynced) {
await this._db.context.write("lastSynced", serverResponse.lastSynced);
}
// TODO test this.
// we won't be updating lastSynced time here because
// it can cause the lastSynced time to move ahead of any
// last edited (but unsynced) time resulting in edited notes
// not getting synced.
// if (serverResponse.lastSynced) {
// await this._db.context.write("lastSynced", serverResponse.lastSynced);
// }
}
async _send(data, token) {