Mirrors/notesnook
1
0
Fork 0
mirror of https://github.com/streetwriters/notesnook.git synced 2025-12-23 23:19:40 +01:00
Code Issues Packages Projects Releases Wiki Activity

core: generate setting key ids once

Browse Source 
this greatly improves performance because md5 id generation is slow
This commit is contained in:
Abdullah Atta
2024-03-22 10:09:09 +05:00
parent 77d5bd71f9
commit c4f0cd18ad
1 changed files with 9 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
packages/core/src/collections/settings.ts
View File

@@ -76,6 +76,13 @@ const defaultSettings: SettingItemMap = {
"sideBarHiddenItems:colors": []
};
// since setting keys are static, we can calculate ids for them
// once instead of on each get/set. This can be further optimized
// by generating the ids at build time.
const KEY_IDS = Object.fromEntries(
Object.keys(defaultSettings).map((key) => [key, makeId(key)])
) as Record<keyof SettingItemMap, string>;
export class Settings implements ICollection {
name = "settings";
readonly collection: SQLCachedCollection<"settings", SettingItem>;
@@ -93,15 +100,11 @@ export class Settings implements ICollection {
return this.collection.init();
}
// get raw() {
// return this.collection.raw();
// }
private async set<TKey extends keyof SettingItemMap>(
key: TKey,
value: SettingItemMap[TKey]
) {
const id = makeId(key);
const id = KEY_IDS[key];
const oldItem = this.collection.get(id);
if (oldItem && oldItem.key !== key) throw new Error("Key conflict.");
@@ -119,7 +122,7 @@ export class Settings implements ICollection {
private get<TKey extends keyof SettingItemMap>(
key: TKey
): SettingItemMap[TKey] {
const item = this.collection.get(makeId(key)) as
const item = this.collection.get(KEY_IDS[key]) as
| SettingItem<TKey>
| undefined;
if (!item || item.key !== key) return defaultSettings[key];