From bd1cf0fadc2fe35ca3eb4711e52ffca5ce618235 Mon Sep 17 00:00:00 2001 From: Abdullah Atta Date: Wed, 13 Dec 2023 15:35:46 +0500 Subject: [PATCH] web: fix random crashes when scrolling in list --- apps/web/src/components/list-container/resolved-item.tsx | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/apps/web/src/components/list-container/resolved-item.tsx b/apps/web/src/components/list-container/resolved-item.tsx index 949d4747c..a739c3ca5 100644 --- a/apps/web/src/components/list-container/resolved-item.tsx +++ b/apps/web/src/components/list-container/resolved-item.tsx @@ -83,6 +83,8 @@ function withDateEdited< } export async function resolveItems(ids: string[], items: Item[]) { + if (!ids.length || !items.length) return []; + const { type } = items[0]; if (type === "note") return resolveNotes(ids); else if (type === "notebook") { @@ -172,9 +174,11 @@ async function resolveNotes(ids: string[]) { data.push({ color: group.color ? resolved.colors[group.color] : undefined, reminder: group.reminder ? resolved.reminders[group.reminder] : undefined, - tags: withDateEdited(group.tags.map((id) => resolved.tags[id])), + tags: withDateEdited( + group.tags.map((id) => resolved.tags[id]).filter(Boolean) + ), notebooks: withDateEdited( - group.notebooks.map((id) => resolved.notebooks[id]) + group.notebooks.map((id) => resolved.notebooks[id]).filter(Boolean) ) }); }