From b4ef8660d2f720d2f3daa3e148c6cb65f49af278 Mon Sep 17 00:00:00 2001 From: thecodrr Date: Tue, 4 Jan 2022 11:38:46 +0500 Subject: [PATCH] fix: properly handle native & external url opening --- apps/web/desktop/electron.js | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/apps/web/desktop/electron.js b/apps/web/desktop/electron.js index cf23f5d96..eee14505f 100644 --- a/apps/web/desktop/electron.js +++ b/apps/web/desktop/electron.js @@ -42,7 +42,7 @@ async function createWindow() { nodeIntegration: false, //true, enableRemoteModule: false, contextIsolation: true, - nativeWindowOpen: false, + nativeWindowOpen: true, spellcheck: false, preload: __dirname + "/preload.js", }, @@ -66,11 +66,8 @@ async function createWindow() { }); mainWindow.webContents.setWindowOpenHandler((details) => { - if (details.frameName === "_blank") { - shell.openExternal(details.url); - return { action: "deny" }; - } - return { action: "allow" }; + shell.openExternal(details.url); + return { action: "deny" }; }); nativeTheme.on("updated", () => {