core: fix Object is not iterable error on some platforms

This happened due to [Symbol.asyncIterable] not getting
transformed when it was a method of a class. Moving it inside
another method fixes the issue.

packages/common/src/utils/export-notes.ts

@@ -72,7 +72,9 @@ export async function* exportNotes(
   const pathTree = new PathTree();
   const notePathMap: Map<string, string[]> = new Map();
 
-  for await (const note of notes.fields(["notes.id", "notes.title"])) {
+  for await (const note of notes
+    .fields(["notes.id", "notes.title"])
+    .iterate()) {
     const filename = `${sanitizeFilename(note.title || "Untitled", {
       replacement: "-"
     })}.${FORMAT_TO_EXT[format]}`;

packages/core/src/api/lookup.ts

@@ -184,7 +184,7 @@ export default class Lookup {
   ) {
     const results: Map<string, number> = new Map();
     const columns = fields.map((f) => f.column);
-    for await (const item of selector.fields(columns)) {
+    for await (const item of selector.fields(columns).iterate()) {
       if (limit && results.size >= limit) break;
 
       for (const field of fields) {

packages/core/src/collections/attachments.ts

@@ -422,7 +422,7 @@ export class Attachments implements ICollection {
   async cleanup() {
     const now = dayjs().unix();
     const ids: string[] = [];
-    for await (const attachment of this.deleted) {
+    for await (const attachment of this.deleted.iterate()) {
       if (dayjs(attachment.dateDeleted).add(7, "days").unix() < now) continue;
 
       const isDeleted = await this.db.fs().deleteFile(attachment.hash);

packages/core/src/database/backup.ts

@@ -361,7 +361,7 @@ export default class Backup {
       };
 
       let current = 0;
-      for await (const attachment of this.db.attachments.all) {
+      for await (const attachment of this.db.attachments.all.iterate()) {
         current++;
         if (
           !(await this.db

packages/core/src/database/sql-collection.ts

@@ -476,7 +476,7 @@ export class FilteredSelector<T extends Item> {
   async *map<TReturnType>(
     fn: (item: T) => TReturnType
   ): AsyncIterableIterator<TReturnType> {
-    for await (const item of this) {
+    for await (const item of this.iterate()) {
       yield fn(item);
     }
   }
@@ -567,9 +567,13 @@ export class FilteredSelector<T extends Item> {
     );
   }
 
+  iterate() {
+    // eslint-disable-next-line @typescript-eslint/no-this-alias
+    const thisArg = this;
+    return {
       async *[Symbol.asyncIterator]() {
         let lastRow: any | null = null;
-    const fields = this._fields.slice();
+        const fields = thisArg._fields.slice();
         if (fields.length > 0) {
           if (!fields.find((f) => f.includes(".dateCreated")))
             fields.push("dateCreated");
@@ -577,7 +581,7 @@ export class FilteredSelector<T extends Item> {
         }
 
         while (true) {
-      const rows = await this.filter
+          const rows = await thisArg.filter
             .orderBy("dateCreated asc")
             .orderBy("id asc")
             .$if(lastRow !== null, (qb) =>
@@ -587,7 +591,7 @@ export class FilteredSelector<T extends Item> {
                 (eb) => eb.tuple(lastRow.dateCreated, lastRow.id)
               )
             )
-        .limit(this.batchSize)
+            .limit(thisArg.batchSize)
             .$if(fields.length === 0, (eb) => eb.selectAll())
             .$if(fields.length > 0, (eb) => eb.select(fields))
             .execute();
@@ -599,6 +603,8 @@ export class FilteredSelector<T extends Item> {
           lastRow = rows[rows.length - 1];
         }
       }
+    };
+  }
 
   private buildSortExpression(options: GroupOptions, hasDueDate?: boolean) {
     sanitizeSortOptions(this.type, options);