diff --git a/.github/workflows/android.publish.internal.yml b/.github/workflows/android.publish.internal.yml index 3be85dc79..425efad47 100644 --- a/.github/workflows/android.publish.internal.yml +++ b/.github/workflows/android.publish.internal.yml @@ -147,8 +147,10 @@ jobs: apps/mobile/native/android/app/build/outputs/apk/release/notesnook-x86.apk apps/mobile/native/android/app/build/outputs/apk/release/notesnook-x86_64.apk - - name: Upload signed aab to Github + - name: Upload sourcemaps uses: actions/upload-artifact@v2 with: - name: Notesnook.aab - path: ${{steps.sign_app.outputs.signedReleaseFile}} + name: sourcemaps + path: | + apps/mobile/native/android/app/build/**/*.map + packages/editor-mobile/sourcemaps/*.map diff --git a/.github/workflows/android.publish.yml b/.github/workflows/android.publish.yml index a3e496d02..090057c96 100644 --- a/.github/workflows/android.publish.yml +++ b/.github/workflows/android.publish.yml @@ -133,7 +133,6 @@ jobs: status: completed whatsNewDirectory: apps/mobile/native/android/releasenotes/ - - name: Create release draft on Github uses: softprops/action-gh-release@v1 with: @@ -148,8 +147,10 @@ jobs: apps/mobile/native/android/app/build/outputs/apk/release/notesnook-x86.apk apps/mobile/native/android/app/build/outputs/apk/release/notesnook-x86_64.apk - - name: Upload signed aab to Github + - name: Upload sourcemaps uses: actions/upload-artifact@v2 with: - name: Notesnook.aab - path: ${{steps.sign_app.outputs.signedReleaseFile}} + name: sourcemaps + path: | + apps/mobile/native/android/app/build/**/*.map + packages/editor-mobile/sourcemaps/*.map diff --git a/.github/workflows/ios.publish.yml b/.github/workflows/ios.publish.yml index f0cd3b614..d36ef4ba3 100644 --- a/.github/workflows/ios.publish.yml +++ b/.github/workflows/ios.publish.yml @@ -100,5 +100,8 @@ jobs: - name: Upload Notesnook.ipa to Github uses: actions/upload-artifact@v2 with: - name: Notesnook.ipa - path: Notesnook.ipa + name: Notesnook.zip + path: | + Notesnook.ipa + apps/mobile/native/ios/**/*.map + packages/editor-mobile/sourcemaps/*.map diff --git a/packages/editor-mobile/.env-cmdrc.js b/packages/editor-mobile/.env-cmdrc.js index 257c79d81..1777bf737 100644 --- a/packages/editor-mobile/.env-cmdrc.js +++ b/packages/editor-mobile/.env-cmdrc.js @@ -1,7 +1,7 @@ module.exports = { all: { DISABLE_ESLINT_PLUGIN: true, - GENERATE_SOURCEMAP: process.env.NODE_ENV === "development", + GENERATE_SOURCEMAP: true, BROWSER: "none" } }; diff --git a/packages/editor-mobile/package.json b/packages/editor-mobile/package.json index 2dd483cff..05a2426df 100644 --- a/packages/editor-mobile/package.json +++ b/packages/editor-mobile/package.json @@ -27,7 +27,7 @@ }, "scripts": { "start": "env-cmd -e all react-scripts start", - "build": "env-cmd -e all react-scripts build && rm -rf build.bundle && mv build build.bundle", + "build": "env-cmd -e all react-scripts build && rm -rf build.bundle && rm -rf sourcemaps && mv build build.bundle && cp -r ./build.bundle/static/js/ sourcemaps && rm -r ./build.bundle/static/js/*.map", "test": "react-scripts test", "eject": "react-scripts eject", "postinstall": "patch-package"