From 7c00a281e4f88d9aa6d39d8fb1b2035326616351 Mon Sep 17 00:00:00 2001 From: thecodrr Date: Tue, 21 Apr 2020 12:33:29 +0500 Subject: [PATCH] chore: update notesnook-core --- apps/web/package.json | 2 +- apps/web/src/components/note/index.js | 3 ++- apps/web/yarn.lock | 4 ++-- 3 files changed, 5 insertions(+), 4 deletions(-) diff --git a/apps/web/package.json b/apps/web/package.json index 674385781..6487443b8 100644 --- a/apps/web/package.json +++ b/apps/web/package.json @@ -27,8 +27,8 @@ "zustand": "^2.2.3" }, "devDependencies": { - "babel-loader": "8.1.0", "babel-eslint": "^10.1.0", + "babel-loader": "8.1.0", "eslint": "^6.8.0", "eslint-config-react-app": "^5.2.1", "eslint-plugin-import": "^2.20.2", diff --git a/apps/web/src/components/note/index.js b/apps/web/src/components/note/index.js index 853eba560..fec23c352 100644 --- a/apps/web/src/components/note/index.js +++ b/apps/web/src/components/note/index.js @@ -162,7 +162,8 @@ function Note(props) { export default React.memo(Note, function (prevProps, nextProps) { const prevItem = prevProps.item; const nextItem = nextProps.item; - // TODO need to investigate why a crash happens here. + + // do not update if the item was removed if (!prevItem || !nextItem) return true; return ( prevItem.pinned === nextItem.pinned && diff --git a/apps/web/yarn.lock b/apps/web/yarn.lock index 82623ee24..b31517fe7 100644 --- a/apps/web/yarn.lock +++ b/apps/web/yarn.lock @@ -7291,9 +7291,9 @@ normalize-url@^3.0.0, normalize-url@^3.0.1: resolved "https://registry.yarnpkg.com/normalize-url/-/normalize-url-3.3.0.tgz#b2e1c4dc4f7c6d57743df733a4f5978d18650559" integrity sha512-U+JJi7duF1o+u2pynbp2zXDW2/PADgC30f0GsHZtRh+HOcXHnw137TrNlyxxRvWW5fjKd3bcLHPxofWuCjaeZg== -"notes-core@https://github.com/streetwriters/notesnook-core.git": +"notes-core@git+ssh://git@github.com:streetwriters/notesnook-core.git": version "1.3.0" - resolved "https://github.com/streetwriters/notesnook-core.git#ed5ead55bed5ff5ec976ed46dc517854b407aff7" + resolved "git+ssh://git@github.com:streetwriters/notesnook-core.git#f1d3ccc200f76208b072414c1dc61f2bc3f148a9" dependencies: fast-sort "^2.0.1" fuzzysearch "^1.0.3"