From 6965899092bc335e35f22134a2200c4befea2422 Mon Sep 17 00:00:00 2001
From: thecodrr <thecodrr@protonmail.com>
Date: Thu, 16 Jun 2022 17:11:04 +0500
Subject: [PATCH] perf: improve note refreshing performance

---
 apps/web/src/components/note/index.js |  2 +-
 apps/web/src/stores/note-store.js     | 51 ++++++++++++++++-----------
 apps/web/src/views/home.js            |  1 +
 3 files changed, 33 insertions(+), 21 deletions(-)

diff --git a/apps/web/src/components/note/index.js b/apps/web/src/components/note/index.js
index 9f36c1174..a6f5769c5 100644
--- a/apps/web/src/components/note/index.js
+++ b/apps/web/src/components/note/index.js
@@ -264,7 +264,7 @@ const menuItems = [
     key: "favorite",
     title: ({ note }) => (note.favorite ? "Unfavorite" : "Favorite"),
     icon: Icon.StarOutline,
-    onClick: ({ note }) => store.favorite(note),
+    onClick: ({ note }) => store.favorite(note.id),
   },
   {
     key: "addtonotebook",
diff --git a/apps/web/src/stores/note-store.js b/apps/web/src/stores/note-store.js
index 4e03c0249..6c73db927 100644
--- a/apps/web/src/stores/note-store.js
+++ b/apps/web/src/stores/note-store.js
@@ -8,7 +8,6 @@ import Vault from "../common/vault";
 import BaseStore from ".";
 import { EV, EVENTS } from "notes-core/common";
 import Config from "../utils/config";
-import { qclone } from "qclone";
 import { hashNavigate } from "../navigation";
 import { groupArray } from "notes-core/utils/grouping";
 
@@ -39,16 +38,23 @@ class NoteStore extends BaseStore {
   };
 
   refresh = () => {
-    this.set((state) => {
-      state.notes = groupArray(
-        db.notes.all,
-        db.settings.getGroupOptions("home")
-      );
-      state.nonce = Math.random();
-    });
+    this.get().notes = groupArray(
+      db.notes.all,
+      db.settings.getGroupOptions("home")
+    );
+    this._forceUpdate();
     this.refreshContext();
   };
 
+  refreshItem = (id, newNote) => {
+    const notes = this.get().notes;
+    const index = notes.findIndex((n) => n.id === id);
+    if (index <= -1) return;
+    newNote = newNote || db.notes.note(id).data;
+    notes[index] = newNote;
+    this._forceUpdate();
+  };
+
   refreshContext = () => {
     const context = this.get().context;
     if (!context) return;
@@ -63,12 +69,8 @@ class NoteStore extends BaseStore {
 
   setContext = (context) => {
     db.notes.init().then(() => {
-      this.set((state) => {
-        state.context = {
-          ...context,
-          notes: qclone(notesFromContext(context)),
-        };
-      });
+      this.get().context = { ...context, notes: notesFromContext(context) };
+      this._forceUpdate();
     });
   };
 
@@ -100,21 +102,21 @@ class NoteStore extends BaseStore {
     const note = db.notes.note(id);
     await note.favorite();
     this._syncEditor(note.id, "favorite", !note.data.favorite);
-    this.refresh();
+    this.refreshItem(id);
   };
 
   unlock = async (id) => {
     return await Vault.unlockNote(id).then(async (res) => {
       if (editorStore.get().session.id === id)
         await editorStore.openSession(id);
-      this.refresh();
+      this.refreshItem(id);
       return res;
     });
   };
 
   lock = async (id) => {
     await Vault.lockNote(id);
-    this.refresh();
+    this.refreshItem(id);
     if (editorStore.get().session.id === id)
       await editorStore.openSession(id, true);
   };
@@ -123,7 +125,7 @@ class NoteStore extends BaseStore {
     const note = db.notes.note(id);
     await note.readonly();
     this._syncEditor(note.id, "readonly", !note.data.readonly);
-    this.refresh();
+    this.refreshItem(id);
   };
 
   duplicate = async (note) => {
@@ -136,7 +138,7 @@ class NoteStore extends BaseStore {
     const note = db.notes.note(id);
     await note.localOnly();
     this._syncEditor(note.id, "localOnly", !note.data.localOnly);
-    this.refresh();
+    this.refreshItem(id);
   };
 
   setColor = async (id, color) => {
@@ -147,7 +149,7 @@ class NoteStore extends BaseStore {
       else await db.notes.note(id).color(color);
       appStore.refreshNavItems();
       this._syncEditor(note.id, "color", db.notes.note(id).data.color);
-      this.refresh();
+      this.refreshItem(id);
     } catch (e) {
       console.error(e);
     }
@@ -162,6 +164,15 @@ class NoteStore extends BaseStore {
     toggle(session.id, action, value);
     return true;
   };
+
+  /**
+   * @private
+   */
+  _forceUpdate = () => {
+    this.set((state) => {
+      state.nonce++;
+    });
+  };
 }
 
 /**
diff --git a/apps/web/src/views/home.js b/apps/web/src/views/home.js
index a90b1e6f0..92717d1b5 100644
--- a/apps/web/src/views/home.js
+++ b/apps/web/src/views/home.js
@@ -7,6 +7,7 @@ import { hashNavigate } from "../navigation";
 import useNavigate from "../utils/use-navigate";
 
 function Home() {
+  useStore((store) => store.nonce);
   const notes = useStore((store) => store.notes);
   const refresh = useStore((store) => store.refresh);
   const clearContext = useStore((store) => store.clearContext);