From 5934c518e668dff51121c8c33686a23d1bb208fd Mon Sep 17 00:00:00 2001
From: Abdullah Atta <abdullahatta@streetwriters.co>
Date: Fri, 17 Mar 2023 15:02:45 +0500
Subject: [PATCH] web: refactor OptionItem to take objects instead of strings

---
 apps/web/src/views/settings.js | 82 +++++++++++++++++-----------------
 1 file changed, 40 insertions(+), 42 deletions(-)

diff --git a/apps/web/src/views/settings.js b/apps/web/src/views/settings.js
index 654eaf29f..ed6dcfc5e 100644
--- a/apps/web/src/views/settings.js
+++ b/apps/web/src/views/settings.js
@@ -188,9 +188,7 @@ function Settings() {
     "backupReminderOffset",
     0
   );
-  const [trashCleanupInterval, setTrashCleanupInterval] = useState(
-    cleanupIntervalToOptions[db.settings.getTrashCleanupInterval()]
-  );
+  const [trashCleanupInterval, setTrashCleanupInterval] = useState(7);
   const [debugMode, setDebugMode] = usePersistentState("debugMode", false);
   const [homepage, setHomepage] = usePersistentState("homepage", 0);
   const [backupStorageLocation, setBackupStorageLocation] = usePersistentState(
@@ -516,7 +514,12 @@ function Settings() {
             <OptionsItem
               title={"Homepage"}
               tip={"Default screen to open on app startup."}
-              options={["Notes", "Notebooks", "Favorites", "Tags"]}
+              options={[
+                { value: 0, title: "Notes" },
+                { value: 1, title: "Notebooks" },
+                { value: 2, title: "Favorites" },
+                { value: 3, title: "Tags" }
+              ]}
               premium
               selectedOption={homepage}
               onSelectionChanged={(_option, index) => setHomepage(index)}
@@ -704,18 +707,15 @@ function Settings() {
               tip={
                 "Create a zip file containing all your notes as TXT, MD or HTML files"
               }
-              options={["Text", "Markdown", "HTML"]}
-              selectedOption={-1}
+              options={[
+                { value: "txt", title: "Text" },
+                { value: "md", title: "Markdown", premium: true },
+                { value: "html", title: "HTML", premium: true }
+              ]}
               onSelectionChanged={async (option) => {
                 await db.notes.init();
-                const format =
-                  option === "Text"
-                    ? "txt"
-                    : option === "Markdown"
-                    ? "md"
-                    : "html";
                 await exportNotes(
-                  format,
+                  option.value,
                   db.notes.all.map((n) => n.id)
                 );
               }}
@@ -752,11 +752,16 @@ function Settings() {
                       ? "Automatically backup my data"
                       : "Remind me to backup my data"
                   }
-                  options={["Never", "Daily", "Weekly", "Monthly"]}
+                  options={[
+                    { value: 0, title: "Never" },
+                    { value: 1, title: "Daily" },
+                    { value: 2, title: "Weekly" },
+                    { value: 3, title: "Monthly" }
+                  ]}
                   premium="backups"
                   selectedOption={backupReminderOffset}
-                  onSelectionChanged={async (_option, index) =>
-                    setBackupReminderOffset(index)
+                  onSelectionChanged={(option) =>
+                    setBackupReminderOffset(option.value)
                   }
                 />
                 {isDesktop() ? (
@@ -795,13 +800,16 @@ function Settings() {
           <OptionsItem
             title="Clear trash interval"
             tip={"Permanently delete all items in the trash"}
-            options={["Weekly", "Monthly", "Yearly", "Never"]}
+            options={[
+              { value: 7, title: "Weekly" },
+              { value: 30, title: "Monthly" },
+              { value: 365, title: "Yearly" },
+              { value: -1, title: "Never", premium: true }
+            ]}
             selectedOption={trashCleanupInterval}
-            onSelectionChanged={async (_option, index) => {
-              setTrashCleanupInterval(index);
-              db.settings.setTrashCleanupInterval(
-                optionsToCleanupInterval[index]
-              );
+            onSelectionChanged={async (option) => {
+              setTrashCleanupInterval(option.value);
+              await db.settings.setTrashCleanupInterval(option.value);
             }}
           />
         )}
@@ -1125,27 +1133,31 @@ function OptionsItem(props) {
       >
         {options.map((option, index) => (
           <Text
-            key={option}
-            bg={selectedOption === index ? "primary" : "transparent"}
+            key={option.value}
+            bg={selectedOption === option.value ? "primary" : "transparent"}
             variant="subBody"
             p={2}
             py={1}
             onClick={async () => {
-              if (isUserPremium() || !premium)
+              const isPremium = premium || option.premium;
+              if (isUserPremium() || !isPremium)
                 onSelectionChanged(option, index);
               else {
                 await showBuyDialog();
               }
             }}
             sx={{
-              ":hover": { color: selectedOption === index ? "static" : "text" },
+              ":hover": {
+                color: selectedOption === option.value ? "static" : "text"
+              },
               flex: 1,
               textAlign: "center",
-              color: selectedOption === index ? "static" : "bgSecondaryText",
+              color:
+                selectedOption === option.value ? "static" : "bgSecondaryText",
               minWidth: 70
             }}
           >
-            {option}
+            {option.title}
           </Text>
         ))}
       </Flex>
@@ -1392,17 +1404,3 @@ function Header(props) {
     </Flex>
   );
 }
-
-const optionsToCleanupInterval = {
-  0: 7,
-  1: 30,
-  2: 365,
-  3: -1
-};
-
-const cleanupIntervalToOptions = {
-  7: 0,
-  30: 1,
-  365: 2,
-  "-1": 3
-};