Mirrors/notesnook
1
0
Fork 0
mirror of https://github.com/streetwriters/notesnook.git synced 2025-12-24 07:29:30 +01:00
Code Issues Packages Projects Releases Wiki Activity

core: move index migrations to main database migrations

Browse Source 
this is better design wise as we won't have to keep checking if the
indices have been migrated or not. We'll just check the database version
and do the appropriate migrations based on that.
This commit is contained in:
Abdullah Atta
2022-10-17 22:36:53 +05:00
parent 1a589b0955
commit 577d50b512
7 changed files with 171 additions and 74 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
packages/core/database/migrator.js
View File

@@ -17,14 +17,18 @@ You should have received a copy of the GNU General Public License
along with this program. If not, see <http://www.gnu.org/licenses/>.
*/
import { migrateItem } from "../migrations";
import { migrateCollection, migrateItem } from "../migrations";
class Migrator {
async migrate(db, collections, get, version) {
for (let collection of collections) {
if (!collection.index || !collection.dbCollection) continue;
for (var i = 0; i < collection.index.length; ++i) {
let id = collection.index[i];
await migrateCollection(collection.dbCollection, version);
const index = (await collection.index()) || [];
for (var i = 0; i < index.length; ++i) {
let id = index[i];
let item = get(id);
if (!item) {
continue;
@@ -35,19 +39,24 @@ class Migrator {
await collection.dbCollection?._collection?.addItem(item);
continue;
}
const itemId = item.id;
item = await migrateItem(
item,
version,
item.type || collection.type,
item.type || collection.type || collection.dbCollection.type,
db
);
if (collection.dbCollection.merge) {
await collection.dbCollection.merge(item);
} else {
} else if (collection.dbCollection.add) {
await collection.dbCollection.add(item);
}
// if id changed after migration, we need to delete the old one.
if (item.id !== itemId) {
await collection.dbCollection?._collection?.deleteItem(itemId);
}
}
}
return true;