Mirrors/notesnook
1
0
Fork 0
mirror of https://github.com/streetwriters/notesnook.git synced 2025-12-24 07:29:30 +01:00
Code Issues Packages Projects Releases Wiki Activity

refactor: do not throw when adding, removing note in tag

Browse Source
This commit is contained in:
thecodrr
2021-07-06 12:13:19 +05:00
parent 1db9be8795
commit 3709a63aae
1 changed files with 23 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

30
packages/core/collections/tags.js
View File

@@ -1,6 +1,7 @@
import Collection from "./collection";
import { qclone } from "qclone";
import { makeId } from "../utils/id";
import { deleteItem } from "../utils/array";
export default class Tags extends Collection {
tag(id) {
@@ -13,7 +14,10 @@ export default class Tags extends Collection {
tagId = tagId.id;
}
if (!tagId || !noteId) new Error("tagId and noteId cannot be falsy.");
if (!tagId || !noteId) {
console.error("tagId and noteId cannot be falsy.");
return;
}
let tag = this.all.find((t) => t.id === tagId || t.title === tagId) || {
title: tagId,
@@ -44,14 +48,26 @@ export default class Tags extends Collection {
}
async remove(tagTitle, noteId) {
if (!tagTitle || !noteId) new Error("tagTitle and noteId cannot be falsy.");
if (!tagTitle || !noteId) {
console.error(
"tag title and noteId cannot be undefined.",
tagTitle,
noteId
);
return;
}
let tag = this.all.find((t) => t.title === tagTitle || t.id === tagTitle);
if (!tag) throw new Error(`No tag with title "${tagTitle}" found.`);
if (!tag) {
console.error(`No such tag found. Tag title:`, tagTitle);
return;
}
tag = qclone(tag);
const noteIndex = tag.noteIds.indexOf(noteId);
if (noteIndex <= -1)
throw new Error(`No note of id "${noteId}" exists in this tag.`);
tag.noteIds.splice(noteIndex, 1);
if (!deleteItem(tag.noteIds, noteId))
console.error(`No such note exists in tag.`, tag.id, noteId);
if (tag.noteIds.length > 0) await this._collection.addItem(tag);
else {
await this._db.settings.unpin(tag.id);