From 2260bc774a5bc17e57d0f6d47f0961868de7d96c Mon Sep 17 00:00:00 2001 From: Ammar Ahmed Date: Fri, 12 Jun 2026 12:30:16 +0500 Subject: [PATCH] mobile: replace hard coded strings --- apps/mobile/app/screens/settings/groups/account.ts | 10 +++------- packages/intl/locale/en.po | 12 ++++++++++++ packages/intl/locale/pseudo-LOCALE.po | 12 ++++++++++++ packages/intl/src/strings.ts | 5 ++++- 4 files changed, 31 insertions(+), 8 deletions(-) diff --git a/apps/mobile/app/screens/settings/groups/account.ts b/apps/mobile/app/screens/settings/groups/account.ts index d13fcb64a..516468c40 100644 --- a/apps/mobile/app/screens/settings/groups/account.ts +++ b/apps/mobile/app/screens/settings/groups/account.ts @@ -210,7 +210,6 @@ export const accountGroup: SettingSection = { id: "account-sub-section", type: "group", name: strings.account(), - description: "Profile details and subscription options", icon: "user", iconFamily: "notesnook", sections: [ @@ -218,7 +217,7 @@ export const accountGroup: SettingSection = { id: "edit-profile", type: "screen", name: strings.editProfile(), - description: "Change profile picture, full name and email", + description: strings.editProfileDesc(), icon: "user", iconFamily: "notesnook", sections: [ @@ -331,7 +330,6 @@ export const accountGroup: SettingSection = { id: "security-sub-section", type: "group", name: strings.privacyAndSecurity(), - description: "Password, 2FA and account recovery", icon: "two-factor-authentication", sections: [ { @@ -444,8 +442,7 @@ export const accountGroup: SettingSection = { { id: "data-storage-sub-section", type: "group", - name: "Data & Storage", - description: "Manage attachments and local cache", + name: strings.dataAndStorage(), icon: "paperclip", iconFamily: "notesnook", sections: [ @@ -506,8 +503,7 @@ export const accountGroup: SettingSection = { { id: "account-actions-sub-section", type: "group", - name: "Account actions", - description: "Log out or permanently delete your account", + name: strings.accountActions(), icon: "user-sheet-logout", iconFamily: "notesnook", sections: [ diff --git a/packages/intl/locale/en.po b/packages/intl/locale/en.po index 873a8c7bf..05340453d 100644 --- a/packages/intl/locale/en.po +++ b/packages/intl/locale/en.po @@ -682,6 +682,10 @@ msgstr "Access on all your devices" msgid "Account" msgstr "Account" +#: src/strings.ts:2820 +msgid "Account actions" +msgstr "Account actions" + #: src/strings.ts:1870 msgid "Account password" msgstr "Account password" @@ -1494,6 +1498,10 @@ msgstr "Change plan" msgid "Change profile picture" msgstr "Change profile picture" +#: src/strings.ts:2818 +msgid "Change profile picture, full name and email" +msgstr "Change profile picture, full name and email" + #: src/strings.ts:2213 msgid "Change proxy" msgstr "Change proxy" @@ -2201,6 +2209,10 @@ msgstr "Dark mode" msgid "Dark or light, we won't judge." msgstr "Dark or light, we won't judge." +#: src/strings.ts:2819 +msgid "Data and storage" +msgstr "Data and storage" + #: src/strings.ts:1570 msgid "Database setup failed, could not get database key" msgstr "Database setup failed, could not get database key" diff --git a/packages/intl/locale/pseudo-LOCALE.po b/packages/intl/locale/pseudo-LOCALE.po index 4c90f8f1f..035c2a29c 100644 --- a/packages/intl/locale/pseudo-LOCALE.po +++ b/packages/intl/locale/pseudo-LOCALE.po @@ -682,6 +682,10 @@ msgstr "" msgid "Account" msgstr "" +#: src/strings.ts:2820 +msgid "Account actions" +msgstr "" + #: src/strings.ts:1870 msgid "Account password" msgstr "" @@ -1494,6 +1498,10 @@ msgstr "" msgid "Change profile picture" msgstr "" +#: src/strings.ts:2818 +msgid "Change profile picture, full name and email" +msgstr "" + #: src/strings.ts:2213 msgid "Change proxy" msgstr "" @@ -2190,6 +2198,10 @@ msgstr "" msgid "Dark or light, we won't judge." msgstr "" +#: src/strings.ts:2819 +msgid "Data and storage" +msgstr "" + #: src/strings.ts:1570 msgid "Database setup failed, could not get database key" msgstr "" diff --git a/packages/intl/src/strings.ts b/packages/intl/src/strings.ts index aedd37500..16ade6780 100644 --- a/packages/intl/src/strings.ts +++ b/packages/intl/src/strings.ts @@ -2866,5 +2866,8 @@ Continue without attachments?`, forceSyncWarningShort: () => t`Use this only for troubleshooting sync issues. Regular use may lead to data loss or conflicts.`, forceSyncNeedHelpContact: () => t`Having issues? Contact`, - forceSyncRiskAcknowledgement: () => t`I understand the risks` + forceSyncRiskAcknowledgement: () => t`I understand the risks`, + editProfileDesc: () => t`Change profile picture, full name and email`, + dataAndStorage: () => t`Data and storage`, + accountActions: () => t`Account actions` };