From 192fa8fc2483f2d8dc083a1969e97c6cf1e8d902 Mon Sep 17 00:00:00 2001
From: Abdullah Atta <abdullahatta@streetwriters.co>
Date: Mon, 6 Feb 2023 10:03:13 +0500
Subject: [PATCH] editor: add rtl support in outline list

---
 .../outline-list-item/component.tsx           | 102 ++++++++++++------
 .../extensions/outline-list/outline-list.ts   |  12 ---
 2 files changed, 71 insertions(+), 43 deletions(-)

diff --git a/packages/editor/src/extensions/outline-list-item/component.tsx b/packages/editor/src/extensions/outline-list-item/component.tsx
index 8b571372b..4f291930e 100644
--- a/packages/editor/src/extensions/outline-list-item/component.tsx
+++ b/packages/editor/src/extensions/outline-list-item/component.tsx
@@ -18,7 +18,7 @@ along with this program.  If not, see <http://www.gnu.org/licenses/>.
 */
 
 import { Box, Flex, Text } from "@theme-ui/components";
-import { ReactNodeViewProps } from "../react";
+import { GetPosNode, ReactNodeViewProps } from "../react";
 import { Icon } from "../../toolbar/components/icon";
 import { Icons } from "../../toolbar/icons";
 import { Node as ProsemirrorNode } from "prosemirror-model";
@@ -26,6 +26,7 @@ import { findChildren } from "@tiptap/core";
 import { OutlineList } from "../outline-list/outline-list";
 import { useIsMobile } from "../../toolbar/stores/toolbar-store";
 import { Editor } from "../../types";
+import { TextDirections } from "../text-direction";
 
 export function OutlineListItemComponent(props: ReactNodeViewProps) {
   const { editor, node, getPos, forwardRef } = props;
@@ -45,36 +46,24 @@ export function OutlineListItemComponent(props: ReactNodeViewProps) {
         }}
       >
         {isNested ? (
-          <Icon
-            path={isCollapsed ? Icons.chevronRight : Icons.chevronDown}
-            title={
-              isCollapsed
-                ? "Click to uncollapse list"
-                : "Click to collapse list"
-            }
-            sx={{
-              cursor: "pointer",
-              transition: "all .2s ease-in-out",
-              ":hover": {
-                transform: ["unset", "scale(1.3)"]
-              },
-              ":active": {
-                transform: ["scale(1.3)", "unset"]
-              },
-              ".icon:hover path": {
-                fill: "var(--checked) !important"
-              }
-            }}
-            size={isMobile ? 24 : 18}
-            onMouseDown={(e) => e.preventDefault()}
-            onTouchEnd={(e) => {
-              e.preventDefault();
-              toggleOutlineList(editor, node, isCollapsed, getPos());
-            }}
-            onClick={() => {
-              toggleOutlineList(editor, node, isCollapsed, getPos());
-            }}
-          />
+          <>
+            <ToggleIconButton
+              editor={editor}
+              isCollapsed={isCollapsed}
+              isMobile={isMobile}
+              node={node}
+              getPos={getPos}
+              textDirection={undefined}
+            />
+            <ToggleIconButton
+              editor={editor}
+              isCollapsed={isCollapsed}
+              isMobile={isMobile}
+              node={node}
+              getPos={getPos}
+              textDirection={"rtl"}
+            />
+          </>
         ) : (
           <Icon
             path={Icons.circle}
@@ -133,3 +122,54 @@ function toggleOutlineList(
     !isCollapsed
   );
 }
+
+type ToggleIconButtonProps = {
+  textDirection: TextDirections;
+  isCollapsed: boolean;
+  isMobile: boolean;
+
+  editor: Editor;
+  node: ProsemirrorNode;
+  getPos: GetPosNode;
+};
+function ToggleIconButton(props: ToggleIconButtonProps) {
+  const { textDirection, isCollapsed, isMobile, editor, node, getPos } = props;
+
+  return (
+    <Icon
+      className={`outline-list-item-toggle ${textDirection || ""}`}
+      path={
+        isCollapsed
+          ? textDirection === "rtl"
+            ? Icons.chevronLeft
+            : Icons.chevronRight
+          : Icons.chevronDown
+      }
+      title={
+        isCollapsed ? "Click to uncollapse list" : "Click to collapse list"
+      }
+      sx={{
+        cursor: "pointer",
+        transition: "all .2s ease-in-out",
+        ":hover": {
+          transform: ["unset", "scale(1.3)"]
+        },
+        ":active": {
+          transform: ["scale(1.3)", "unset"]
+        },
+        ".icon:hover path": {
+          fill: "var(--checked) !important"
+        }
+      }}
+      size={isMobile ? 24 : 18}
+      onMouseDown={(e) => e.preventDefault()}
+      onTouchEnd={(e) => {
+        e.preventDefault();
+        toggleOutlineList(editor, node, isCollapsed, getPos());
+      }}
+      onClick={() => {
+        toggleOutlineList(editor, node, isCollapsed, getPos());
+      }}
+    />
+  );
+}
diff --git a/packages/editor/src/extensions/outline-list/outline-list.ts b/packages/editor/src/extensions/outline-list/outline-list.ts
index a650705a0..459519d4c 100644
--- a/packages/editor/src/extensions/outline-list/outline-list.ts
+++ b/packages/editor/src/extensions/outline-list/outline-list.ts
@@ -23,7 +23,6 @@ import { OutlineListComponent } from "./component";
 
 export type OutlineListAttributes = {
   collapsed: boolean;
-  textDirection: string;
 };
 
 export interface OutlineListOptions {
@@ -61,17 +60,6 @@ export const OutlineList = Node.create<OutlineListOptions>({
         renderHTML: (attributes) => ({
           "data-collapsed": attributes.collapsed === true
         })
-      },
-      textDirection: {
-        default: "ltr",
-        parseHTML: (element) => element.dir,
-        renderHTML(attributes) {
-          if (!attributes.textDirection) {
-            return {};
-          }
-
-          return { dir: attributes.textDirection };
-        }
       }
     };
   },