From 181ad335d87f7865f5d71eef2dba4b40e363b7d5 Mon Sep 17 00:00:00 2001 From: Ammar Ahmed Date: Fri, 14 Mar 2025 17:37:42 +0500 Subject: [PATCH] mobile: fix tablet bugs --- apps/mobile/app/components/sheets/github/issue.js | 9 +++++++++ apps/mobile/app/screens/link-notebooks/index.tsx | 5 +---- apps/mobile/app/screens/move-notes/index.tsx | 1 + 3 files changed, 11 insertions(+), 4 deletions(-) diff --git a/apps/mobile/app/components/sheets/github/issue.js b/apps/mobile/app/components/sheets/github/issue.js index 7462faa3d..eaa9bc770 100644 --- a/apps/mobile/app/components/sheets/github/issue.js +++ b/apps/mobile/app/components/sheets/github/issue.js @@ -70,6 +70,15 @@ Pro: ${PremiumService.get()} Logged in: ${user ? "yes" : "no"}`, userId: user?.id }); + if (!issueUrl.current) { + setLoading(false); + ToastManager.show({ + heading: "Failed to report issue on github", + type: "error", + context: "local" + }); + return; + } setLoading(false); body.reset(); title.reset(); diff --git a/apps/mobile/app/screens/link-notebooks/index.tsx b/apps/mobile/app/screens/link-notebooks/index.tsx index a02bb7c7e..ef94a195e 100644 --- a/apps/mobile/app/screens/link-notebooks/index.tsx +++ b/apps/mobile/app/screens/link-notebooks/index.tsx @@ -136,9 +136,6 @@ const LinkNotebooks = (props: NavigationProps<"LinkNotebooks">) => { })(); }, [loadRootNotebooks, loading]); - const selectedItemsList = useSelectionStore( - (state) => state.selectedItemsList - ); const multiSelect = useNotebookSelectionStore((state) => state.multiSelect); const hasSelection = useNotebookSelectionStore((state) => @@ -285,7 +282,7 @@ const LinkNotebooks = (props: NavigationProps<"LinkNotebooks">) => { /> {hasSelection ? ( - onSave()} /> + onSave()} /> ) : null} ); diff --git a/apps/mobile/app/screens/move-notes/index.tsx b/apps/mobile/app/screens/move-notes/index.tsx index 5dda8be84..b2b649b03 100644 --- a/apps/mobile/app/screens/move-notes/index.tsx +++ b/apps/mobile/app/screens/move-notes/index.tsx @@ -185,6 +185,7 @@ export const MoveNotes = (props: NavigationProps<"MoveNotes">) => { {selectionCount ? ( { await db.notes?.addToNotebook( currentNotebook.id,