Mirrors/notesnook
1
0
Fork 0
mirror of https://github.com/streetwriters/notesnook.git synced 2025-12-20 21:49:32 +01:00
Code Issues Packages Projects Releases Wiki Activity

refactor: improve portal provider logic

Browse Source
This commit is contained in:
thecodrr
2022-06-22 13:50:08 +05:00
parent 89f5ed0464
commit 0c669a5aea
27 changed files with 128 additions and 245 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
packages/editor/src/extensions/react/selection-based-react-node-view.tsx
View File

@@ -57,11 +57,9 @@ export class SelectionBasedNodeView<
node: PMNode,
editor: Editor,
getPos: GetPosNode,
portalProviderAPI: PortalProviderAPI,
eventDispatcher: EventDispatcher,
options: ReactNodeViewOptions<P>
) {
super(node, editor, getPos, portalProviderAPI, eventDispatcher, options);
super(node, editor, getPos, options);
this.updatePos();
@@ -251,16 +249,9 @@ export function createSelectionBasedNodeView<
) {
return ({ node, getPos, editor }: NodeViewRendererProps) => {
const _getPos = () => (typeof getPos === "boolean" ? -1 : getPos());
return new SelectionBasedNodeView(
node,
editor,
_getPos,
editor.storage.portalProviderAPI,
editor.storage.eventDispatcher,
{
...options,
component,
}
).init();
return new SelectionBasedNodeView(node, editor, _getPos, {
...options,
component,
}).init();
};
}