Mirrors/notesnook
1
0
Fork 0
mirror of https://github.com/streetwriters/notesnook.git synced 2025-12-23 15:09:33 +01:00
Code Issues Packages Projects Releases Wiki Activity

core: re-insert only migrated items

Browse Source 
Previously, we were re-inserting all items regardless of whether they
were changed or not. This raised a lot of issues, not to mention
unnecessary load on our servers because after each migration
all the data is re-synced. Since migration takes place independently on
each device, this multiplies exponentially.
Hopefully after this update, this will only happen much more granually.
This commit is contained in:
Abdullah Atta
2022-10-26 10:52:27 +05:00
parent 9f25d623bb
commit 082b9755db
3 changed files with 41 additions and 32 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
packages/core/database/migrator.js
View File

@@ -21,7 +21,7 @@ import { sendMigrationProgressEvent } from "../common";
import { migrateCollection, migrateItem } from "../migrations";
class Migrator {
async migrate(db, collections, get, version) {
async migrate(db, collections, get, version, restore = false) {
for (let collection of collections) {
if (!collection.index || !collection.dbCollection) continue;
@@ -56,23 +56,26 @@ class Migrator {
await collection.dbCollection?._collection?.addItem(item);
continue;
}
const itemId = item.id;
item = await migrateItem(
const migrated = await migrateItem(
item,
version,
item.type || collection.type || collection.dbCollection.type,
db
);
if (collection.dbCollection.merge) {
await collection.dbCollection.merge(item);
} else if (collection.dbCollection.add) {
await collection.dbCollection.add(item);
}
if (migrated || restore) {
if (collection.dbCollection.merge) {
await collection.dbCollection.merge(item);
} else if (collection.dbCollection.add) {
await collection.dbCollection.add(item);
}
// if id changed after migration, we need to delete the old one.
if (item.id !== itemId) {
await collection.dbCollection?._collection?.deleteItem(itemId);
// if id changed after migration, we need to delete the old one.
if (item.id !== itemId) {
await collection.dbCollection?._collection?.deleteItem(itemId);
}
}
}
}