From d5ae8ae43b1cf333ba297401b00f5baffe17109f Mon Sep 17 00:00:00 2001
From: "wenmeng.zwm" <wenmeng.zwm@alibaba-inc.com>
Date: Wed, 8 Feb 2023 10:07:07 +0000
Subject: [PATCH] remove tensorboard hook as default

tensorboard has been removed from the requirements of framework.txt, so we remove tensorboard hook from default config
        Link: https://code.alibaba-inc.com/Ali-MaaS/MaaS-lib/codereview/11519980

    * remove tensorboard hook as default

* Merge branch 'master' into fix/remove_default_tensorboard_hook
---
 modelscope/trainers/default_config.py | 26 +++++++++-----------------
 tests/trainers/test_trainer.py        |  3 +++
 2 files changed, 12 insertions(+), 17 deletions(-)

diff --git a/modelscope/trainers/default_config.py b/modelscope/trainers/default_config.py
index 7b2e339a..a02478b9 100644
--- a/modelscope/trainers/default_config.py
+++ b/modelscope/trainers/default_config.py
@@ -4,23 +4,15 @@ from modelscope.utils.config import Config
 
 DEFAULT_CONFIG = {
     'train': {
-        'hooks': [
-            {
-                'type': 'CheckpointHook',
-                'interval': 1
-            },
-            {
-                'type': 'TextLoggerHook',
-                'interval': 10
-            },
-            {
-                'type': 'IterTimerHook'
-            },
-            {
-                'type': 'TensorboardHook',
-                'interval': 10
-            },
-        ]
+        'hooks': [{
+            'type': 'CheckpointHook',
+            'interval': 1
+        }, {
+            'type': 'TextLoggerHook',
+            'interval': 10
+        }, {
+            'type': 'IterTimerHook'
+        }]
     }
 }
 
diff --git a/tests/trainers/test_trainer.py b/tests/trainers/test_trainer.py
index c692196a..4453d4dc 100644
--- a/tests/trainers/test_trainer.py
+++ b/tests/trainers/test_trainer.py
@@ -268,6 +268,9 @@ class TrainerTest(unittest.TestCase):
                 }, {
                     'type': 'EvaluationHook',
                     'interval': 1
+                }, {
+                    'type': 'TensorboardHook',
+                    'interval': 1
                 }]
             },
             'evaluation': {