From 883bbd01640140c7061ff3001ef8b1e67cbff7ff Mon Sep 17 00:00:00 2001 From: "zhangzhicheng.zzc" Date: Fri, 13 Jan 2023 13:52:09 +0000 Subject: [PATCH] fix file dir creation error with native method Link: https://code.alibaba-inc.com/Ali-MaaS/MaaS-lib/codereview/11433444 --- modelscope/fileio/file.py | 18 ++---------------- 1 file changed, 2 insertions(+), 16 deletions(-) diff --git a/modelscope/fileio/file.py b/modelscope/fileio/file.py index c5eb8261..d93f24c9 100644 --- a/modelscope/fileio/file.py +++ b/modelscope/fileio/file.py @@ -9,10 +9,6 @@ from typing import Generator, Union import requests -from modelscope.utils.logger import get_logger - -logger = get_logger() - class Storage(metaclass=ABCMeta): """Abstract class of storage. @@ -88,12 +84,7 @@ class LocalStorage(Storage): """ dirname = os.path.dirname(filepath) if dirname and not os.path.exists(dirname): - try: - os.makedirs(dirname) - except FileExistsError as err: - logger.warning( - f'File directory created by other thread during creation with err: {err}' - ) + os.makedirs(dirname, exist_ok=True) with open(filepath, 'wb') as f: f.write(obj) @@ -116,12 +107,7 @@ class LocalStorage(Storage): """ dirname = os.path.dirname(filepath) if dirname and not os.path.exists(dirname): - try: - os.makedirs(dirname) - except FileExistsError as err: - logger.warning( - f'File directory created by other thread during creation with err: {err}' - ) + os.makedirs(dirname, exist_ok=True) with open(filepath, 'w', encoding=encoding) as f: f.write(obj)