From d25b27f6d53f347ca6901c2606751d69b73373f8 Mon Sep 17 00:00:00 2001 From: Yingda Chen Date: Wed, 13 Nov 2024 18:43:38 +0800 Subject: [PATCH] Log reduce (#1081) * do not print log for symbolic link creation failure due to existing ones Co-authored-by: Yingda Chen --- modelscope/hub/snapshot_download.py | 20 +++++++++++--------- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/modelscope/hub/snapshot_download.py b/modelscope/hub/snapshot_download.py index 9d32a08e..915d8108 100644 --- a/modelscope/hub/snapshot_download.py +++ b/modelscope/hub/snapshot_download.py @@ -265,15 +265,17 @@ def _snapshot_download( if '.' in repo_id: masked_directory = get_model_masked_directory( directory, repo_id) - logger.info( - f'Creating symbolic link {masked_directory} -> {directory}.' - ) - try: - os.symlink(os.path.abspath(masked_directory), directory) - except OSError as e: - logger.warning( - f'Failed to create symbolic link {masked_directory} -> {directory}: {e}' - ) + if os.path.exists(directory): + logger.info( + 'Target directory already exists, skipping creation.') + else: + logger.info(f'Creating symbolic link [{directory}].') + try: + os.symlink( + os.path.abspath(masked_directory), directory) + except OSError: + logger.warning( + f'Failed to create symbolic link {directory}.') elif repo_type == REPO_TYPE_DATASET: directory = os.path.abspath(