Mirrors/flowframes
1
0
Fork 0
mirror of https://github.com/n00mkrad/flowframes.git synced 2025-12-21 10:49:25 +01:00
Code Issues Packages Projects Releases Wiki Activity

Possibly fixed Fraction division-by-zero exception? (can't reproduce)

Browse Source
This commit is contained in:
N00MKRAD
2021-04-03 00:17:29 +02:00
parent 5556b5a5c7
commit ada9aefab1
1 changed files with 18 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

29
Code/Data/Fraction.cs
View File

@@ -111,20 +111,27 @@ namespace Flowframes.Data
//Reduce the fraction to lowest terms //Reduce the fraction to lowest terms
Fraction modifiedFraction = this; Fraction modifiedFraction = this;
//While the numerator and denominator share a greatest common denominator, try
//keep dividing both by it
int gcd = 0;
while (Math.Abs(gcd = getGCD(modifiedFraction.Numerator, modifiedFraction.Denominator)) != 1)
{ {
modifiedFraction.Numerator /= gcd; //While the numerator and denominator share a greatest common denominator,
modifiedFraction.Denominator /= gcd; //keep dividing both by it
} int gcd = 0;
while (Math.Abs(gcd = getGCD(modifiedFraction.Numerator, modifiedFraction.Denominator)) != 1)
{
modifiedFraction.Numerator /= gcd;
modifiedFraction.Denominator /= gcd;
}
//Make sure only a single negative sign is on the numerator //Make sure only a single negative sign is on the numerator
if (modifiedFraction.Denominator < 0) if (modifiedFraction.Denominator < 0)
{
modifiedFraction.Numerator = -this.Numerator;
modifiedFraction.Denominator = -this.Denominator;
}
}
catch (Exception e)
{ {
modifiedFraction.Numerator = -this.Numerator; Logger.Log($"Failed to reduce fraction ({modifiedFraction}): {e.Message}", true);
modifiedFraction.Denominator = -this.Denominator;
} }
return modifiedFraction; return modifiedFraction;