From f703d9be788f7894d6d366a867f0bf39662e128f Mon Sep 17 00:00:00 2001 From: itsKaynine Date: Sun, 19 Mar 2023 03:04:09 +0700 Subject: [PATCH] fix: linting issues from clippy --- src/injector.rs | 12 +++++------- src/websocket.rs | 2 +- 2 files changed, 6 insertions(+), 8 deletions(-) diff --git a/src/injector.rs b/src/injector.rs index 957e166..0eb8a0a 100644 --- a/src/injector.rs +++ b/src/injector.rs @@ -94,8 +94,7 @@ impl Injector { // Inject prelude if self.config.prelude { info!("Injecting prelude script (id: {})", page.id); - _ = self - .evaluate(&mut ws, &prelude_script) + self.evaluate(&mut ws, &prelude_script) .expect("Should be able to evaluate JS"); } @@ -103,8 +102,7 @@ impl Injector { for user_script in user_scripts.iter() { // Inject using evaluate info!("Injecting script: {}", user_script.file_path); - _ = self - .evaluate(&mut ws, &user_script.content) + self.evaluate(&mut ws, &user_script.content) .expect("Should be able to evaluate JS"); } @@ -176,13 +174,13 @@ impl Injector { }) .collect(); - return scripts; + scripts } fn spawn_process(&self) -> Result { // Prepare args let mut args = vec![format!("--remote-debugging-port={}", &self.port)]; - args.extend(self.config.arg.iter().map(|a| a.clone())); + args.extend(self.config.arg.iter().cloned()); // Spawn child process debug!( @@ -258,7 +256,7 @@ impl Injector { debug!("[Runtime.evaluate] Parsed response: {:#?}", response); // Handle exception - if let Some(_) = response.result.exception_details { + if response.result.exception_details.is_some() { warn!( "[Runtime.evaluate] Caught exception while evaluating script: {:#?}", response diff --git a/src/websocket.rs b/src/websocket.rs index a759bff..7566e9e 100644 --- a/src/websocket.rs +++ b/src/websocket.rs @@ -10,7 +10,7 @@ pub struct WebSocket { impl WebSocket { pub fn connect(address: &str) -> Result { - let url = url::Url::parse(&address).expect("Should be a valid address"); + let url = url::Url::parse(address).expect("Should be a valid address"); let (socket, response) = tungstenite::connect(url)?; info!("WebSocket connected (status: {})", response.status());