mirror of
https://github.com/dokku/dokku.git
synced 2026-09-01 19:49:25 +02:00
8d4e7d9793
Options drained out of the pre-0.38.0 `DOCKER_OPTIONS_<PHASE>` files were copied verbatim rather than re-serialized the way `docker-options:add` stores them, so `docker-options:remove` compared the canonical string it builds against a stored value that could never match it and exited successfully without removing anything. Removal now matches stored options by shell word, and stored options are rewritten into the canonical form once on upgrade, which additionally splits an entry that carried several flags on a single line into one entry per flag so a single flag can be removed and so the readers that match on a flag prefix see one value per entry. The leftover `.migrated` sentinel drain is restored to running ahead of the global short-circuit that had made it unreachable, and the plugin's Go tests are added to the test target that had never run them.
496 lines
16 KiB
Bash
496 lines
16 KiB
Bash
#!/usr/bin/env bats
|
|
|
|
load test_helper
|
|
|
|
setup() {
|
|
global_setup
|
|
create_app
|
|
}
|
|
|
|
teardown() {
|
|
destroy_app
|
|
global_teardown
|
|
}
|
|
|
|
@test "(docker-options) docker-options:help" {
|
|
run /bin/bash -c "dokku docker-options"
|
|
echo "output: $output"
|
|
echo "status: $status"
|
|
assert_output_contains "Manage docker options for an app"
|
|
help_output="$output"
|
|
|
|
run /bin/bash -c "dokku docker-options:help"
|
|
echo "output: $output"
|
|
echo "status: $status"
|
|
assert_output_contains "Manage docker options for an app"
|
|
assert_output "$help_output"
|
|
}
|
|
|
|
@test "(docker-options) docker-options:add (all phases)" {
|
|
run /bin/bash -c "dokku docker-options:add $TEST_APP build,deploy,run \"-v /tmp\""
|
|
echo "output: $output"
|
|
echo "status: $status"
|
|
assert_success
|
|
run /bin/bash -c "dokku docker-options:report $TEST_APP --docker-options-build"
|
|
echo "output: $output"
|
|
echo "status: $status"
|
|
assert_success
|
|
assert_output_contains "-v /tmp"
|
|
run /bin/bash -c "dokku docker-options:report $TEST_APP --docker-options-deploy"
|
|
echo "output: $output"
|
|
echo "status: $status"
|
|
assert_success
|
|
assert_output_contains "-v /tmp"
|
|
run /bin/bash -c "dokku docker-options:report $TEST_APP --docker-options-run"
|
|
echo "output: $output"
|
|
echo "status: $status"
|
|
assert_success
|
|
assert_output_contains "-v /tmp"
|
|
}
|
|
|
|
@test "(docker-options) docker-options:clear" {
|
|
run /bin/bash -c "dokku docker-options:add $TEST_APP build,deploy,run \"-v /tmp\""
|
|
echo "output: $output"
|
|
echo "status: $status"
|
|
assert_success
|
|
run /bin/bash -c "dokku docker-options:clear $TEST_APP"
|
|
echo "output: $output"
|
|
echo "status: $status"
|
|
assert_success
|
|
run /bin/bash -c "dokku docker-options:report $TEST_APP --docker-options-build"
|
|
echo "output: $output"
|
|
echo "status: $status"
|
|
assert_success
|
|
assert_output_contains "-v /tmp" 0
|
|
run /bin/bash -c "dokku docker-options:report $TEST_APP --docker-options-deploy"
|
|
echo "output: $output"
|
|
echo "status: $status"
|
|
assert_success
|
|
assert_output_contains "-v /tmp" 0
|
|
run /bin/bash -c "dokku docker-options:report $TEST_APP --docker-options-run"
|
|
echo "output: $output"
|
|
echo "status: $status"
|
|
assert_success
|
|
assert_output_contains "-v /tmp" 0
|
|
|
|
run /bin/bash -c "dokku docker-options:add $TEST_APP build,deploy,run \"-v /tmp\""
|
|
echo "output: $output"
|
|
echo "status: $status"
|
|
assert_success
|
|
run /bin/bash -c "dokku docker-options:clear $TEST_APP build"
|
|
echo "output: $output"
|
|
echo "status: $status"
|
|
assert_success
|
|
run /bin/bash -c "dokku docker-options:report $TEST_APP --docker-options-build"
|
|
echo "output: $output"
|
|
echo "status: $status"
|
|
assert_success
|
|
assert_output_contains "-v /tmp" 0
|
|
run /bin/bash -c "dokku docker-options:report $TEST_APP --docker-options-deploy"
|
|
echo "output: $output"
|
|
echo "status: $status"
|
|
assert_success
|
|
assert_output_contains "-v /tmp"
|
|
run /bin/bash -c "dokku docker-options:report $TEST_APP --docker-options-run"
|
|
echo "output: $output"
|
|
echo "status: $status"
|
|
assert_success
|
|
assert_output_contains "-v /tmp"
|
|
|
|
run /bin/bash -c "dokku docker-options:clear $TEST_APP deploy"
|
|
echo "output: $output"
|
|
echo "status: $status"
|
|
assert_success
|
|
run /bin/bash -c "dokku docker-options:report $TEST_APP --docker-options-build"
|
|
echo "output: $output"
|
|
echo "status: $status"
|
|
assert_success
|
|
assert_output_contains "-v /tmp" 0
|
|
run /bin/bash -c "dokku docker-options:report $TEST_APP --docker-options-deploy"
|
|
echo "output: $output"
|
|
echo "status: $status"
|
|
assert_success
|
|
assert_output_contains "-v /tmp" 0
|
|
run /bin/bash -c "dokku docker-options:report $TEST_APP --docker-options-run"
|
|
echo "output: $output"
|
|
echo "status: $status"
|
|
assert_success
|
|
assert_output_contains "-v /tmp"
|
|
|
|
run /bin/bash -c "dokku docker-options:clear $TEST_APP run"
|
|
echo "output: $output"
|
|
echo "status: $status"
|
|
assert_success
|
|
run /bin/bash -c "dokku docker-options:report $TEST_APP --docker-options-build"
|
|
echo "output: $output"
|
|
echo "status: $status"
|
|
assert_success
|
|
assert_output_contains "-v /tmp" 0
|
|
run /bin/bash -c "dokku docker-options:report $TEST_APP --docker-options-deploy"
|
|
echo "output: $output"
|
|
echo "status: $status"
|
|
assert_success
|
|
assert_output_contains "-v /tmp" 0
|
|
run /bin/bash -c "dokku docker-options:report $TEST_APP --docker-options-run"
|
|
echo "output: $output"
|
|
echo "status: $status"
|
|
assert_success
|
|
assert_output_contains "-v /tmp" 0
|
|
}
|
|
|
|
@test "(docker-options) docker-options:add (build phase)" {
|
|
run /bin/bash -c "dokku docker-options:add $TEST_APP build \"-v /tmp\""
|
|
echo "output: $output"
|
|
echo "status: $status"
|
|
assert_success
|
|
run /bin/bash -c "dokku docker-options:report $TEST_APP --docker-options-build"
|
|
echo "output: $output"
|
|
echo "status: $status"
|
|
assert_success
|
|
assert_output_contains "-v /tmp"
|
|
}
|
|
|
|
@test "(docker-options) docker-options:add (deploy phase)" {
|
|
run /bin/bash -c "dokku docker-options:add $TEST_APP deploy \"-v /tmp\""
|
|
echo "output: $output"
|
|
echo "status: $status"
|
|
assert_success
|
|
run /bin/bash -c "dokku docker-options:report $TEST_APP --docker-options-deploy"
|
|
echo "output: $output"
|
|
echo "status: $status"
|
|
assert_success
|
|
assert_output_contains "-v /tmp"
|
|
}
|
|
|
|
@test "(docker-options) docker-options:add (run phase)" {
|
|
run /bin/bash -c "dokku docker-options:add $TEST_APP run \"-v /tmp\""
|
|
echo "output: $output"
|
|
echo "status: $status"
|
|
assert_success
|
|
run /bin/bash -c "dokku docker-options:report $TEST_APP --docker-options-run"
|
|
echo "output: $output"
|
|
echo "status: $status"
|
|
assert_success
|
|
assert_output_contains "-v /tmp"
|
|
}
|
|
|
|
@test "(docker-options) docker-options:remove (all phases)" {
|
|
run /bin/bash -c "dokku docker-options:add $TEST_APP build,deploy,run \"-v /tmp\""
|
|
echo "output: $output"
|
|
echo "status: $status"
|
|
assert_success
|
|
run /bin/bash -c "dokku docker-options:report $TEST_APP"
|
|
echo "output: $output"
|
|
echo "status: $status"
|
|
assert_success
|
|
assert_output_contains "-v /tmp" 3
|
|
run /bin/bash -c "dokku docker-options:remove $TEST_APP build,deploy,run \"-v /tmp\""
|
|
echo "output: $output"
|
|
echo "status: $status"
|
|
assert_success
|
|
run /bin/bash -c "dokku docker-options:report $TEST_APP"
|
|
echo "output: $output"
|
|
echo "status: $status"
|
|
assert_success
|
|
assert_output_contains "-v /tmp" 0
|
|
}
|
|
|
|
@test "(docker-options) docker-options:remove (build phase)" {
|
|
run /bin/bash -c "dokku docker-options:add $TEST_APP build,deploy,run \"-v /tmp\""
|
|
echo "output: $output"
|
|
echo "status: $status"
|
|
assert_success
|
|
run /bin/bash -c "dokku docker-options:report $TEST_APP"
|
|
echo "output: $output"
|
|
echo "status: $status"
|
|
assert_success
|
|
assert_output_contains "-v /tmp" 3
|
|
run /bin/bash -c "dokku docker-options:remove $TEST_APP build \"-v /tmp\""
|
|
echo "output: $output"
|
|
echo "status: $status"
|
|
assert_success
|
|
run /bin/bash -c "dokku docker-options:report $TEST_APP"
|
|
echo "output: $output"
|
|
echo "status: $status"
|
|
assert_success
|
|
assert_output_contains "-v /tmp" 2
|
|
}
|
|
|
|
@test "(docker-options) docker-options:remove (deploy phase)" {
|
|
run /bin/bash -c "dokku docker-options:add $TEST_APP build,deploy,run \"-v /tmp\""
|
|
echo "output: $output"
|
|
echo "status: $status"
|
|
assert_success
|
|
run /bin/bash -c "dokku docker-options:report $TEST_APP"
|
|
echo "output: $output"
|
|
echo "status: $status"
|
|
assert_success
|
|
assert_output_contains "-v /tmp" 3
|
|
run /bin/bash -c "dokku docker-options:remove $TEST_APP deploy \"-v /tmp\""
|
|
echo "output: $output"
|
|
echo "status: $status"
|
|
assert_success
|
|
run /bin/bash -c "dokku docker-options:report $TEST_APP"
|
|
echo "output: $output"
|
|
echo "status: $status"
|
|
assert_success
|
|
assert_output_contains "-v /tmp" 2
|
|
}
|
|
|
|
@test "(docker-options) docker-options:remove (run phase)" {
|
|
run /bin/bash -c "dokku docker-options:add $TEST_APP build,deploy,run \"-v /tmp\""
|
|
echo "output: $output"
|
|
echo "status: $status"
|
|
assert_success
|
|
run /bin/bash -c "dokku docker-options:report $TEST_APP"
|
|
echo "output: $output"
|
|
echo "status: $status"
|
|
assert_success
|
|
assert_output_contains "-v /tmp" 3
|
|
run /bin/bash -c "dokku docker-options:remove $TEST_APP run \"-v /tmp\""
|
|
echo "output: $output"
|
|
echo "status: $status"
|
|
assert_success
|
|
run /bin/bash -c "dokku docker-options:report $TEST_APP"
|
|
echo "output: $output"
|
|
echo "status: $status"
|
|
assert_success
|
|
assert_output_contains "-v /tmp" 2
|
|
}
|
|
|
|
@test "(docker-options) deploy with options [buildpacks]" {
|
|
run /bin/bash -c "dokku docker-options:add $TEST_APP deploy \"-v /var/tmp\""
|
|
echo "output: $output"
|
|
echo "status: $status"
|
|
assert_success
|
|
run /bin/bash -c "dokku docker-options:add $TEST_APP deploy \"-v /tmp\""
|
|
echo "output: $output"
|
|
echo "status: $status"
|
|
assert_success
|
|
run /bin/bash -c "dokku docker-options:report $TEST_APP"
|
|
echo "output: $output"
|
|
echo "status: $status"
|
|
assert_success
|
|
assert_output_contains "-v /tmp" 1
|
|
|
|
run deploy_app
|
|
echo "output: $output"
|
|
echo "status: $status"
|
|
assert_success
|
|
|
|
CID=$(<$DOKKU_ROOT/$TEST_APP/CONTAINER.web.1)
|
|
run /bin/bash -c "docker inspect -f '{{ .Config.Volumes }}' $CID | sed -e 's:map::g' | tr -d '[]' | tr ' ' $'\n' | sort | xargs"
|
|
echo "output: $output"
|
|
echo "status: $status"
|
|
assert_output "/tmp:{} /var/tmp:{}"
|
|
}
|
|
|
|
@test "(docker-options) deploy does not expand command substitution in option values [buildpacks]" {
|
|
run /bin/bash -c "dokku docker-options:add $TEST_APP deploy '--label=com.dokku.test=\$(id)'"
|
|
echo "output: $output"
|
|
echo "status: $status"
|
|
assert_success
|
|
|
|
run deploy_app
|
|
echo "output: $output"
|
|
echo "status: $status"
|
|
assert_success
|
|
|
|
CID=$(<$DOKKU_ROOT/$TEST_APP/CONTAINER.web.1)
|
|
run /bin/bash -c "docker inspect $CID --format '{{ index .Config.Labels \"com.dokku.test\" }}'"
|
|
echo "output: $output"
|
|
echo "status: $status"
|
|
assert_output '$(id)'
|
|
[[ "$output" != *"uid="* ]] || flunk "id command output leaked - option value was expanded"
|
|
}
|
|
|
|
@test "(docker-options) deploy with options [dockerfile]" {
|
|
run /bin/bash -c "dokku docker-options:add $TEST_APP deploy \"-v /var/tmp\""
|
|
echo "output: $output"
|
|
echo "status: $status"
|
|
assert_success
|
|
run /bin/bash -c "dokku docker-options:add $TEST_APP deploy \"-v /tmp\""
|
|
echo "output: $output"
|
|
echo "status: $status"
|
|
assert_success
|
|
run /bin/bash -c "dokku docker-options:report $TEST_APP"
|
|
echo "output: $output"
|
|
echo "status: $status"
|
|
assert_success
|
|
assert_output_contains "-v /tmp" 1
|
|
|
|
run /bin/bash -c "dokku docker-options:add $TEST_APP build --build-arg PAYPAL_CLIENT_ID=abc-v123"
|
|
echo "output: $output"
|
|
echo "status: $status"
|
|
assert_success
|
|
|
|
run /bin/bash -c "dokku docker-options:add $TEST_APP build --build-arg PAYPAL_CLIENT_MODE=sandbox"
|
|
echo "output: $output"
|
|
echo "status: $status"
|
|
assert_success
|
|
|
|
run deploy_app dockerfile
|
|
echo "output: $output"
|
|
echo "status: $status"
|
|
assert_success
|
|
# assert_output_contains "One or more build-args \[PAYPAL_CLIENT_ID PAYPAL_CLIENT_MODE\] were not consumed"
|
|
|
|
CID=$(<$DOKKU_ROOT/$TEST_APP/CONTAINER.web.1)
|
|
run /bin/bash -c "docker inspect -f '{{ .Config.Volumes }}' $CID | sed -e 's:map::g' | tr -d '[]' | tr ' ' $'\n' | sort | xargs"
|
|
echo "output: $output"
|
|
echo "status: $status"
|
|
assert_output "/tmp:{} /var/tmp:{}"
|
|
}
|
|
|
|
@test "(docker-options) docker-options:add (all phases over SSH)" {
|
|
run ssh "dokku@$DOKKU_DOMAIN" docker-options:add $TEST_APP build,deploy,run "-v /tmp"
|
|
echo "output: $output"
|
|
echo "status: $status"
|
|
assert_success
|
|
run /bin/bash -c "dokku docker-options:report $TEST_APP"
|
|
echo "output: $output"
|
|
echo "status: $status"
|
|
assert_success
|
|
assert_output_contains "-v /tmp" 3
|
|
}
|
|
|
|
@test "(docker-options) dockerfile deploy with link" {
|
|
run /bin/bash -c "dokku docker-options:add $TEST_APP deploy \"-v /var/tmp\""
|
|
echo "output: $output"
|
|
echo "status: $status"
|
|
assert_success
|
|
|
|
run /bin/bash -c "dokku docker-options:add $TEST_APP build \"--link postgres\""
|
|
echo "output: $output"
|
|
echo "status: $status"
|
|
assert_success
|
|
|
|
run deploy_app dockerfile
|
|
echo "output: $output"
|
|
echo "status: $status"
|
|
assert_success
|
|
}
|
|
|
|
@test "(docker-options) build arguments" {
|
|
run /bin/bash -c "dokku docker-options:add $TEST_APP build '--build-arg GITHUB_TOKEN=\"hello\"'"
|
|
|
|
run deploy_app dockerfile
|
|
echo "output: $output"
|
|
echo "status: $status"
|
|
assert_success
|
|
assert_output_contains "TOKEN is: hello" 2
|
|
}
|
|
|
|
@test "(docker-options:add) splits multi-flag input into separate options" {
|
|
run /bin/bash -c "dokku docker-options:add $TEST_APP build --build-arg X=Y --link foo --link bar"
|
|
echo "output: $output"
|
|
echo "status: $status"
|
|
assert_success
|
|
|
|
run /bin/bash -c "dokku docker-options:list $TEST_APP --phase build"
|
|
echo "output: $output"
|
|
echo "status: $status"
|
|
assert_success
|
|
assert_output_contains "--build-arg X=Y"
|
|
assert_output_contains "--link foo"
|
|
assert_output_contains "--link bar"
|
|
|
|
run /bin/bash -c "dokku docker-options:report $TEST_APP --docker-options-build"
|
|
echo "output: $output"
|
|
echo "status: $status"
|
|
assert_success
|
|
assert_output_contains "--build-arg X=Y"
|
|
assert_output_contains "--link foo"
|
|
assert_output_contains "--link bar"
|
|
}
|
|
|
|
@test "(docker-options:remove) symmetrically removes multi-flag input" {
|
|
run /bin/bash -c "dokku docker-options:add $TEST_APP build --build-arg X=Y --link foo --link bar"
|
|
echo "output: $output"
|
|
echo "status: $status"
|
|
assert_success
|
|
|
|
run /bin/bash -c "dokku docker-options:remove $TEST_APP build --build-arg X=Y --link foo --link bar"
|
|
echo "output: $output"
|
|
echo "status: $status"
|
|
assert_success
|
|
|
|
run /bin/bash -c "dokku docker-options:list $TEST_APP --phase build"
|
|
echo "output: $output"
|
|
echo "status: $status"
|
|
assert_success
|
|
assert_output ""
|
|
}
|
|
|
|
@test "(docker-options:add) lifts misplaced --process out of option content" {
|
|
run /bin/bash -c "dokku docker-options:add $TEST_APP deploy --link foo --process web"
|
|
echo "output: $output"
|
|
echo "status: $status"
|
|
assert_success
|
|
|
|
run /bin/bash -c "dokku docker-options:list $TEST_APP --process web --phase deploy"
|
|
echo "output: $output"
|
|
echo "status: $status"
|
|
assert_success
|
|
assert_output "--link foo"
|
|
|
|
run /bin/bash -c "dokku docker-options:list $TEST_APP --phase deploy"
|
|
echo "output: $output"
|
|
echo "status: $status"
|
|
assert_success
|
|
assert_output_contains "--link foo" 0
|
|
}
|
|
|
|
@test "(docker-options:remove) removes an option stored in the pre-0.38.25 unquoted form" {
|
|
# Options drained out of a legacy DOCKER_OPTIONS_<PHASE> file by
|
|
# releases before 0.38.26 were copied verbatim, so a value holding
|
|
# shell metacharacters sits in the property store unquoted. Seed that
|
|
# state directly - the add path always canonicalizes, so it cannot
|
|
# produce it.
|
|
run /bin/bash -c "dokku docker-options:add $TEST_APP deploy \"-v /tmp/keep:/keep\""
|
|
echo "output: $output"
|
|
echo "status: $status"
|
|
assert_success
|
|
|
|
legacy_option='--group-add $(getent group docker | cut -d: -f3)'
|
|
property_file="/var/lib/dokku/config/docker-options/$TEST_APP/_default_.deploy"
|
|
run /bin/bash -c "printf '%s\n-v /tmp/keep:/keep\n' '$legacy_option' | sudo tee $property_file"
|
|
echo "output: $output"
|
|
echo "status: $status"
|
|
assert_success
|
|
|
|
run /bin/bash -c "sudo chown dokku:dokku $property_file"
|
|
echo "output: $output"
|
|
echo "status: $status"
|
|
assert_success
|
|
|
|
run /bin/bash -c "dokku docker-options:list $TEST_APP --phase deploy"
|
|
echo "output: $output"
|
|
echo "status: $status"
|
|
assert_success
|
|
assert_output_contains "$legacy_option"
|
|
|
|
run /bin/bash -c "dokku docker-options:remove $TEST_APP deploy '$legacy_option'"
|
|
echo "output: $output"
|
|
echo "status: $status"
|
|
assert_success
|
|
|
|
run /bin/bash -c "dokku docker-options:list $TEST_APP --phase deploy"
|
|
echo "output: $output"
|
|
echo "status: $status"
|
|
assert_success
|
|
assert_output "-v /tmp/keep:/keep"
|
|
}
|
|
|
|
@test "(docker-options) dockerfile build skips unsupported flags from multi-flag input" {
|
|
run /bin/bash -c "dokku docker-options:add $TEST_APP build --build-arg PAYPAL_CLIENT_ID=abc --link postgres"
|
|
echo "output: $output"
|
|
echo "status: $status"
|
|
assert_success
|
|
|
|
run deploy_app dockerfile
|
|
echo "output: $output"
|
|
echo "status: $status"
|
|
assert_success
|
|
}
|