mirror of
https://github.com/dokku/dokku.git
synced 2025-12-16 12:07:45 +01:00
- Replace boolean return values with proper error handling in dockerTag and dockerPush functions - Add detailed error context including Docker command exit codes and stderr output - Remove TODO comments and improve error messages for better debugging - Fix error message formatting in defer function This addresses the TODO comments for better error handling and provides users with actionable error information when Docker registry operations fail. Closes: #XXXX
195 lines
5.7 KiB
Go
195 lines
5.7 KiB
Go
package registry
|
|
|
|
import (
|
|
"bytes"
|
|
"fmt"
|
|
"strconv"
|
|
"strings"
|
|
"text/template"
|
|
|
|
"github.com/dokku/dokku/plugins/common"
|
|
)
|
|
|
|
func getImageRepoFromTemplate(appName string) (string, error) {
|
|
imageRepoTemplate := common.PropertyGet("registry", "--global", "image-repo-template")
|
|
if imageRepoTemplate == "" {
|
|
return "", nil
|
|
}
|
|
|
|
tmpl, err := template.New("template").Parse(imageRepoTemplate)
|
|
if err != nil {
|
|
return "", fmt.Errorf("Unable to parse image-repo-template: %w", err)
|
|
}
|
|
|
|
type templateData struct {
|
|
AppName string
|
|
}
|
|
data := templateData{AppName: appName}
|
|
|
|
var doc bytes.Buffer
|
|
if err := tmpl.Execute(&doc, data); err != nil {
|
|
return "", fmt.Errorf("Unable to execute image-repo-template: %w", err)
|
|
}
|
|
|
|
return strings.TrimSpace(doc.String()), nil
|
|
}
|
|
|
|
func getRegistryServerForApp(appName string) string {
|
|
value := common.PropertyGet("registry", appName, "server")
|
|
if value == "" {
|
|
value = common.PropertyGet("registry", "--global", "server")
|
|
}
|
|
value = strings.TrimSpace(value)
|
|
|
|
value = strings.TrimSuffix(value, "/")
|
|
if value == "hub.docker.com" || value == "docker.io" {
|
|
value = ""
|
|
}
|
|
|
|
if value != "" {
|
|
value = value + "/"
|
|
}
|
|
|
|
return value
|
|
}
|
|
|
|
func isPushEnabled(appName string) bool {
|
|
return reportComputedPushOnRelease(appName) == "true"
|
|
}
|
|
|
|
func incrementTagVersion(appName string) (int, error) {
|
|
tag := common.PropertyGet("registry", appName, "tag-version")
|
|
if tag == "" {
|
|
tag = "0"
|
|
}
|
|
|
|
tag = strings.TrimSpace(tag)
|
|
version, err := strconv.Atoi(tag)
|
|
if err != nil {
|
|
return 0, fmt.Errorf("Unable to convert existing tag version (%s) to integer: %v", tag, err)
|
|
}
|
|
|
|
version++
|
|
common.LogVerboseQuiet(fmt.Sprintf("Bumping tag to %d", version))
|
|
if err = common.PropertyWrite("registry", appName, "tag-version", strconv.Itoa(version)); err != nil {
|
|
return 0, err
|
|
}
|
|
|
|
return version, nil
|
|
}
|
|
|
|
func getRegistryPushExtraTagsForApp(appName string) string {
|
|
value := common.PropertyGet("registry", appName, "push-extra-tags")
|
|
if value == "" {
|
|
value = common.PropertyGet("registry", "--global", "push-extra-tags")
|
|
}
|
|
return value
|
|
}
|
|
|
|
func pushToRegistry(appName string, tag int, imageID string, imageRepo string) error {
|
|
common.LogVerboseQuiet("Retrieving image info for app")
|
|
|
|
registryServer := getRegistryServerForApp(appName)
|
|
imageTag, _ := common.GetRunningImageTag(appName, "")
|
|
|
|
fullImage := fmt.Sprintf("%s%s:%d", registryServer, imageRepo, tag)
|
|
|
|
common.LogVerboseQuiet(fmt.Sprintf("Tagging %s:%d in registry format", imageRepo, tag))
|
|
if err := dockerTag(imageID, fullImage); err != nil {
|
|
return fmt.Errorf("unable to tag image %s as %s: %w", imageID, fullImage, err)
|
|
}
|
|
|
|
if err := dockerTag(imageID, fmt.Sprintf("%s:%d", imageRepo, tag)); err != nil {
|
|
return fmt.Errorf("unable to tag image %s as %s:%d: %w", imageID, imageRepo, tag, err)
|
|
}
|
|
|
|
extraTags := getRegistryPushExtraTagsForApp(appName)
|
|
if extraTags != "" {
|
|
extraTagsArray := strings.Split(extraTags, ",")
|
|
for _, extraTag := range extraTagsArray {
|
|
extraTagImage := fmt.Sprintf("%s%s:%s", registryServer, imageRepo, extraTag)
|
|
common.LogVerboseQuiet(fmt.Sprintf("Tagging %s as %s in registry format", imageRepo, extraTag))
|
|
if err := dockerTag(imageID, extraTagImage); err != nil {
|
|
return fmt.Errorf("unable to tag image %s as %s: %w", imageID, extraTagImage, err)
|
|
}
|
|
defer func() {
|
|
common.LogVerboseQuiet(fmt.Sprintf("Untagging extra tag %s", extraTag))
|
|
if err := common.RemoveImages([]string{extraTagImage}); err != nil {
|
|
common.LogWarn(fmt.Sprintf("Unable to untag extra tag %s: %s", extraTag, err.Error()))
|
|
}
|
|
}()
|
|
common.LogVerboseQuiet(fmt.Sprintf("Pushing %s", extraTagImage))
|
|
if err := dockerPush(extraTagImage); err != nil {
|
|
return fmt.Errorf("unable to push image with %s tag: %w", extraTag, err)
|
|
}
|
|
}
|
|
}
|
|
|
|
common.LogVerboseQuiet(fmt.Sprintf("Pushing %s", fullImage))
|
|
if err := dockerPush(fullImage); err != nil {
|
|
return fmt.Errorf("unable to push image %s: %w", fullImage, err)
|
|
}
|
|
|
|
// Only clean up when the scheduler is not docker-local
|
|
// other schedulers do not retire local images
|
|
if common.GetAppScheduler(appName) != "docker-local" {
|
|
common.LogVerboseQuiet("Cleaning up")
|
|
imageCleanup(appName, fmt.Sprintf("%s%s", registryServer, imageRepo), imageTag, tag)
|
|
if fmt.Sprintf("%s%s", registryServer, imageRepo) != imageRepo {
|
|
imageCleanup(appName, imageRepo, imageTag, tag)
|
|
}
|
|
}
|
|
|
|
common.LogVerboseQuiet(fmt.Sprintf("Image %s pushed", fullImage))
|
|
return nil
|
|
}
|
|
|
|
func dockerTag(imageID string, imageTag string) error {
|
|
result, err := common.CallExecCommand(common.ExecCommandInput{
|
|
Command: common.DockerBin(),
|
|
Args: []string{"image", "tag", imageID, imageTag},
|
|
StreamStdio: true,
|
|
})
|
|
if err != nil {
|
|
return fmt.Errorf("docker tag command failed: %w", err)
|
|
}
|
|
if result.ExitCode != 0 {
|
|
return fmt.Errorf("docker tag command exited with code %d: %s", result.ExitCode, result.Stderr)
|
|
}
|
|
return nil
|
|
}
|
|
|
|
func dockerPush(imageTag string) error {
|
|
result, err := common.CallExecCommand(common.ExecCommandInput{
|
|
Command: common.DockerBin(),
|
|
Args: []string{"image", "push", imageTag},
|
|
StreamStdio: true,
|
|
})
|
|
if err != nil {
|
|
return fmt.Errorf("docker push command failed: %w", err)
|
|
}
|
|
if result.ExitCode != 0 {
|
|
return fmt.Errorf("docker push command exited with code %d: %s", result.ExitCode, result.Stderr)
|
|
}
|
|
return nil
|
|
}
|
|
|
|
func imageCleanup(appName string, imageRepo string, imageTag string, tag int) {
|
|
// # keep last two images in place
|
|
oldTag := tag - 2
|
|
tenImagesAgoTag := tag - 12
|
|
|
|
imagesToRemove := []string{}
|
|
for oldTag > 0 {
|
|
imagesToRemove = append(imagesToRemove, fmt.Sprintf("%s:%d", imageRepo, oldTag))
|
|
oldTag = oldTag - 1
|
|
if tenImagesAgoTag == oldTag {
|
|
break
|
|
}
|
|
}
|
|
|
|
imageIDs, _ := common.ListDanglingImages(appName)
|
|
imagesToRemove = append(imagesToRemove, imageIDs...)
|
|
common.RemoveImages(imagesToRemove)
|
|
}
|