Jose Diaz-Gonzalez
a756786f93
fix: ensure we respect quotes and dollar signs in config vars
...
Due to various changes in how containers are started, these keys were set incorrectly for apps. Since we can use the short-hand --env=ENV format for setting env vars on docker containers, lets do so.
Closes #4895
Closes #4896
2021-11-03 12:13:52 -04:00
Jose Diaz-Gonzalez
30a15aaa7a
fix: respect pre-deploy task image manipulation
...
This requires a bc-incompatible break in terms of what triggers the pre-deploy hook (dokku internals vs schedulers).
2021-08-05 04:17:21 -04:00
Jose Diaz-Gonzalez
1568fc7827
refactor: only special case cnb for now
2021-02-11 04:21:08 -05:00
Jose Diaz-Gonzalez
812e34c6f5
feat: properly export env vars for cnb apps
...
They are not baked into the image like they are for herokuish, so we need to manually set them via --env. Additionally, due to newline constraints in docker, we need to use `--env=key` format to correctly pull the values into place.
2021-02-11 03:52:02 -05:00
Jose Diaz-Gonzalez
08fdfd1e38
feat: drop internal calls to verify_app_name
2020-12-27 15:14:11 -05:00
Jose Diaz-Gonzalez
7357579af2
refactor: standardize trigger code
2020-02-10 02:40:59 -05:00
Michael Hobbs
972830a5f3
fix: respect DOKKU_APP_USER in is_image_herokuish_based
2019-11-19 15:07:29 -07:00
Jose Diaz-Gonzalez
86795ddacc
tests: run mvdan/shfmt on test runs
...
While I do not agree with _every_ style change, this will force Dokku to have consistent formatting across all shell scripts, which is arguably a Good Thing™.
The command used to reprocess everything is:
```shell
shfmt -l -bn -ci -i 2 -w .
```
2019-01-07 01:25:55 -05:00
Jose Diaz-Gonzalez
a137ed64dc
fix: Declare and assign separately to avoid masking return values.
2017-09-27 23:56:42 -04:00
Alex Quick
eeb6e78fa4
[config] move to godotenv
2017-09-27 23:56:41 -04:00
Alex Quick
e7e01ee838
[config] fix shellcheck
2017-09-27 23:56:40 -04:00
Alex Quick
fd27d90303
[config] config:export --merge, --prefix, & --suffix
2017-09-27 23:56:40 -04:00
Alex Quick
73e85b7df5
[config] preliminary Dockerfile support
2017-09-27 23:56:40 -04:00
Jose Diaz-Gonzalez
2474c87bbd
Pull the deploying app image name where necessary
...
All of these commands should execute against the image that is in use versus the "latest" that dokku provides the system with.
2016-07-29 12:49:29 -04:00
Michael Hobbs
0f4ff8b724
no need for newlines in docker args
2016-03-21 18:57:14 -07:00
Michael Hobbs
987c5cfb9c
use declare for description variable
2016-03-08 15:30:34 -05:00
Michael Hobbs
aa2415eeb8
more style/function tweaks
2016-03-03 22:11:35 -08:00
Michael Hobbs
d1b87bd7b7
cleanup shellcheck SC2086
2016-02-23 07:50:06 -08:00
Jose Diaz-Gonzalez
c929edfbe5
Source plugins from $PLUGIN_AVAILABLE_PATH when not using common plugin
...
This will allow us to override any core plugin
2015-09-15 02:22:08 -07:00
Michael Hobbs
8095df79f6
implement core plugin mgmt using plugn. add tests.
2015-09-15 02:17:28 -07:00
Jose Diaz-Gonzalez
ad72a137e1
Fix sourcing of functions
2015-09-15 02:16:40 -07:00
Michael Hobbs
495b1d2ba0
refactor to explicitly set IMAGE via get_app_image_name()
2015-09-03 16:12:36 -07:00
Michael Hobbs
04a4da7fc5
allow tagging and deployment of tagged app images
2015-09-02 11:18:01 -07:00
Jose Diaz-Gonzalez
e7c035e207
Use config_export function instead of calling dokku as a subcommand
2015-08-30 01:55:14 -04:00
Jose Diaz-Gonzalez
cc66905c6e
Use dokku config to export config for dockerfile builds
2015-08-30 01:23:56 -04:00
Jim Myhrberg
d5df6a4190
Use $PLUGIN_PATH instead of $(dirname $0)/..
...
As briefly discussed in #1425 , source the `common/functions` file via an
absolute path, rather than determining the relative path by using
`dirname`. 3rd-party plugins should follow suit and use the new
`$PLUGIN_PATH` convention too.
2015-08-28 14:14:28 +01:00
Michael Hobbs
0840d8fd1f
initial pass at switching to herokuish. closes #1091
2015-07-06 12:41:54 -07:00
Michael Hobbs
fb8f08d280
remove quoting from dockerfile env. closes #1002
2015-02-24 11:56:54 -08:00
Michael Hobbs
7357df7c9d
first pass at dockerfile support
2015-02-07 17:56:01 -08:00
