Jose Diaz-Gonzalez
106b2c20f1
feat: add support for git remotes with port specified inline
...
Closes #8093
2025-11-20 02:20:35 -05:00
Jose Diaz-Gonzalez
7a93b11bdd
feat: add tests for remote parsing
2025-11-20 02:20:35 -05:00
Jose Diaz-Gonzalez
78f0c53871
feat: add ability to specify an app path via environment variable
...
This can be used for testing as well as in real usage.
2025-11-20 02:20:35 -05:00
Jose Diaz-Gonzalez
ff18061987
fix: correctly prepend argument to passed ssh args
2024-03-13 22:43:49 -04:00
Jose Diaz-Gonzalez
e43927a69e
tests: add a test for argument handling
2024-03-13 22:21:05 -04:00
Jose Diaz-Gonzalez
ef25a9b0d8
refactor: standardize on shorthand for redirecting all output to /dev/null
...
The shorthand is more prevalent in this codebase, and is something that bash supports, so we should just use the same thing everywhere.
Note that we do not use shorthand redirect in Makefile as shell parsing is a bit different in Make and the shorthand redirect doesn't seem to be properly supported, causing CI errors.
2023-08-05 10:58:57 -04:00
Jose Diaz-Gonzalez
dac566e75e
refactor: move all shellcheck disable definitions to .shellcheckrc file
...
This makes standard use of shellcheck work without needing to provide extra configuration anywhere.
Also remove use of inline 'shellcheck disable' calls that are already defined in the .shellcheckrc and don't need to be set inline.
2023-08-05 10:58:57 -04:00
Jose Diaz-Gonzalez
a4136f4719
fix: correct tests and handle a few edge cases in remote command usage
2023-01-14 19:49:14 -05:00
Jose Diaz-Gonzalez
0653a2b0bf
feat: add support for customizing the remote in use for all commands sent via the official client
...
Closes #5564
2023-01-14 17:53:33 -05:00
Jose Diaz-Gonzalez
ba98055940
fix: drop the app argument when calling storage:ensure-directory from remote client
...
Closes #5464
2022-11-15 22:53:57 -05:00
Jose Diaz-Gonzalez
6c709f2386
fix: drop which in favor of command -v
2021-10-28 18:22:20 -04:00
Jose Diaz-Gonzalez
396ba7b1ab
fix: output remote client help when there is no remote host
...
Closes #4793
2021-10-09 16:16:45 -04:00
Jose Diaz-Gonzalez
b7c7155852
fix: choose the correct app when a named remote is specified in the remote ssh client
...
Closes #4838
2021-10-05 13:18:19 -04:00
Jose Diaz-Gonzalez
540e066acf
fix: return the failed exit code
2021-01-05 00:10:54 -05:00
Jose Diaz-Gonzalez
83d8c8448b
feat: remind users to check their ssh config in cases of ssh error
...
Closes #4278
2021-01-04 22:41:04 -05:00
Jose Diaz-Gonzalez
8eccd50ecb
chore: standardize logging output
...
- send errors to stderr
- use proper prefixes on errors
- use correct prefixes on stdout
2021-01-04 22:38:28 -05:00
Jose Diaz-Gonzalez
2e4c886ab2
fix: correct app arg parsing and new test
2020-12-21 13:36:04 -05:00
Jose Diaz-Gonzalez
a19efc1cfa
chore: drop all references to all commands where possible.
2020-11-21 20:57:33 -05:00
Jose Diaz-Gonzalez
86795ddacc
tests: run mvdan/shfmt on test runs
...
While I do not agree with _every_ style change, this will force Dokku to have consistent formatting across all shell scripts, which is arguably a Good Thing™.
The command used to reprocess everything is:
```shell
shfmt -l -bn -ci -i 2 -w .
```
2019-01-07 01:25:55 -05:00
Jose Diaz-Gonzalez
792b36d5cc
feat: add ps:startall command
2018-04-26 17:34:06 -04:00
Jose Diaz-Gonzalez
ed7d5623ad
fix: attempt to pass shellcheck on os x
2017-03-26 04:38:35 -06:00
Pedro Valentim
85e5bd7c86
Fix remote name when using --remote option with apps:create
2017-03-20 13:11:14 +00:00
Kazuhiro NISHIYAMA
fec2f8e38e
Remove unused variable
2017-01-20 00:26:51 +09:00
Jose Diaz-Gonzalez
67f05b8eed
fix: show error message when there is no DOKKU_REMOTE_HOST available
2017-01-14 14:02:14 -07:00
Jose Diaz-Gonzalez
0f5dec1797
refactor: rename variable usage to DOKKU_REMOTE_HOST
...
This allows us to make it a local variable
2017-01-14 14:00:21 -07:00
Jose Diaz-Gonzalez
24c4f25dd0
fix: set DOKKU_GIT_REMOTE to a default of dokku
2017-01-14 13:58:45 -07:00
Jose Diaz-Gonzalez
6e00064cb3
fix: Properly parse flags in the dokku client
...
- Respect the --app flag
- Respect the --trace flag
- Skip the second argument after both --app and --remote flags
- The `--global` flag should be set as is when specified after a “valid” command
- Fix issues when checking if the --app flag should be passed via ssh
- Use APP as the variable name for the current app
2017-01-09 02:33:45 -07:00
Jose Diaz-Gonzalez
e107c19dbf
chore: remove extra local declarations
2017-01-09 01:31:10 -07:00
Justin Clark
13c78e8e9a
Add exceptions back to dokku_client.sh for plugins that should not be passed an app name implicitly
2017-01-09 01:30:49 -07:00
Jose Diaz-Gonzalez
5ddcf06ce9
feat: add the ability to specify a remote via the --remote flag
...
Closes #2523
2017-01-09 01:15:22 -07:00
Jose Diaz-Gonzalez
70f3e3407f
chore: prefix functions with fn-
2017-01-09 00:44:13 -07:00
Jose Diaz-Gonzalez
332c429e31
refactor: make variables local and move them into correct functions
2017-01-09 00:37:54 -07:00
Jose Diaz-Gonzalez
b23c602079
chore: remove extra whitespace in client
...
[ci skip]
2017-01-09 00:36:35 -07:00
Guillaume Wuip
8d14d15acc
Fix obvious missing "git"
2016-06-26 21:09:31 +02:00
Guillaume Wuip
3cc1b42160
Fix has_dokku_remote
...
`git remote show <remote>` seems to really check if the remote is a git repo
whereas we just want to know if a remote named "dokku" is present
2016-06-26 21:06:42 +02:00
Guillaume Wuip
2a76f7c3b3
Allow apps:destroy when not in a project
2016-06-26 14:33:20 +02:00
Michael Hobbs
8bbb210a10
remove git push from client. closes #2210
2016-05-26 15:32:41 -07:00
Michael Hobbs
4204d210c1
port --app syntax to dokku_client. closes #1638
2016-03-04 12:38:23 -08:00
Jose Diaz-Gonzalez
a765789c4d
Allow customizing ssh port for the default client
...
Closes #1942
2016-03-02 22:01:52 -05:00
Justin Clark
86b4987588
Depreciate and remove dokku backup plugin, replace with documentation
2016-03-02 15:56:33 -08:00
Paul McLanahan
1b6973665a
(client) Add dokku git remote when specifying app name
...
Previously the client would only add the git remote
for you if it was generating a random name for you.
2016-02-24 12:17:23 -05:00
Dan Callahan
344d48e01b
Resolve SC2029: 'this expands on client side'
...
https://github.com/koalaman/shellcheck/wiki/SC2029
This patch addes inline directives where this is the desired behavior,
instead of globaly excluding the check.
2015-11-03 21:40:31 -06:00
Jose Diaz-Gonzalez
4ce9f210b3
Quiet output from ssh command to remove Connection closed messages
2015-10-16 03:03:24 -04:00
Jose Diaz-Gonzalez
5d08b56e3f
Minor lint fixes
2015-10-16 03:03:05 -04:00
Jose Diaz-Gonzalez
27a2478a33
Follow bashstyle where possible
2015-09-16 16:06:31 -07:00
Alan Justino
b4b4e266b2
Hoping Travis to like it this time...
2015-09-10 00:18:34 -03:00
Alan Justino
ad9d331257
Fix: appname was not correctly detected
2015-09-08 11:24:03 -03:00
Jose Diaz-Gonzalez
2a469df5e4
Merge pull request #1207 from rockymadden/client-appname-as-arg-bug
...
Fixed bug with client commands taking verb, appname, and also arguments.
2015-06-25 10:06:02 -04:00
Rocky Madden
587de65441
When parsing args when handling verbs, appname can be included as an argument causing bugs with commands that accept a verb, appname, and also arguments.
2015-05-22 18:21:54 -06:00
Rocky Madden
7a6450f0f0
Fixed lint issue.
2015-05-22 17:07:54 -06:00
