Jose Diaz-Gonzalez
318c21996a
fix: use correct variable name
2025-11-20 00:59:49 -05:00
Jose Diaz-Gonzalez
56566d1c05
chore: make the postdeploy task name more clear
2025-11-20 00:42:49 -05:00
Jose Diaz-Gonzalez
c3a573229d
refactor: execute one-off commands with DOKKU_APP_SHELL as the initial command
...
This commit changes the launched pod to use the configured DOKKU_APP_SHELL - default /bin/bash - to launch processes. Without this, if a non-interactive process was executed and did not immediately exit, it was possible for that process to launch twice - once when the pod started, and once when entering the pod. Ideally we know whether the process is interactive or not, but this isn't always possible when running under a tty (non-tty == non-interactive). As such, this also removes the ability to launch one-off containers that do not have a configured shell in the container, but this is better than attempting to run commands twice.
2024-11-04 14:29:34 -05:00
Jose Diaz-Gonzalez
a1bf046771
feat: update message for deployment tasks that execute in ephemeral containers
...
Closes #6761
2024-04-04 22:49:34 -04:00
guoguangwu
dbd4ebac86
fix: typo
...
Signed-off-by: guoguangwu <guoguangwug@gmail.com >
2024-03-20 14:32:22 +08:00
Jose Diaz-Gonzalez
bb5ab0a777
refactor: use CallPlugnTrigger instead of PlugnTrigger
...
Refs #6422
2024-03-14 03:11:37 -04:00
Jose Diaz-Gonzalez
c277f529a0
refactor: use CallPlugnTrigger instead of PlugnTriggerSetup
...
Refs #6422
2024-03-14 02:26:01 -04:00
Jose Diaz-Gonzalez
cdff4ae867
refactor: use CallPlugnTrigger instead of PlugnTriggerOutput
...
Refs #6422
2024-03-14 01:18:28 -04:00
Jose Diaz-Gonzalez
b7788ab862
fix: correctly use cache volume for herokuish builds
...
Rather than try to mount a directory into the container and use a symlink, directly mount the volume in.
Note that this requires deleting the task container prior to continuing in order to ensure the volume isn't still mounted prior to other tasks being executed.
2024-02-25 15:52:34 -05:00
Jose Diaz-Gonzalez
d8401a4d86
refactor: remove all calls to common.NewShellCmdWithArgs
2024-02-12 20:58:51 -05:00
Jose Diaz-Gonzalez
4294694be3
feat: add support for exposing healthchecks in the AppJson struct
2024-01-18 19:05:14 -05:00
Eng Zer Jun
1d186a5a81
refactor(plugins): replace deprecated io/ioutil functions
...
The io/ioutil package has been deprecated as of Go 1.16 [1]. This commit
replaces the existing io/ioutil functions with their new definitions in
io and os packages.
[1]: https://golang.org/doc/go1.16#ioutil
Signed-off-by: Eng Zer Jun <engzerjun@gmail.com >
2023-12-22 01:59:22 +08:00
Jose Diaz-Gonzalez
09eb0b2c8f
refactor: move app.json extraction up to core-post-extract
2023-02-14 03:08:02 -05:00
Jose Diaz-Gonzalez
5dcc1cb13c
refactor: remove support for DOKKU_SCALE file
...
It has been replaced by the 'formations' key within the 'app.json' file format.
2023-01-15 23:53:03 -05:00
Jose Diaz-Gonzalez
6cbe93c245
refactor: move all golang code for managing data directories to common plugin
...
Additionally, ensure the golang plugins handle setup/teardown of plugin and app-specific data directories during install, rename, and clone phases.
2023-01-08 23:36:12 -05:00
Jose Diaz-Gonzalez
fe4d80a82b
refactor: cleanup zero'd out processes when a Procfile omitting those process types is set
...
This change also moves the referenced Procfile out to a host path once on deploy vs potentially several times, which should speed up deploys a small amount and simplify reasoning about the file.
Closes #5112
2022-11-25 14:50:35 -05:00
Jose Diaz-Gonzalez
dded26625b
fix: always respect app.json formations in scale settings
...
Without this change, it was possible would end up in a state where we might still try to scale processes up that no longer exists.
Closes #5205
2022-06-26 14:33:19 -04:00
Jose Diaz-Gonzalez
55554ce9bd
feat: add ability to increase the max parallelism when deploying a given process type
2021-10-09 22:44:03 -04:00
Jose Diaz-Gonzalez
a8a43812a0
chore: make deprecation notice more readable
2021-08-01 23:15:01 -04:00
Jose Diaz-Gonzalez
0decb386d5
fix: correct issues in parsing and writing an updated app.json
2021-08-01 21:52:05 -04:00
Jose Diaz-Gonzalez
eb55ba5dd0
fix: correct guard
2021-08-01 18:46:41 -04:00
Jose Diaz-Gonzalez
a7593db0c3
refactor: allow specifying clearExisting when calling ps-set-scale
2021-08-01 17:54:12 -04:00
Jose Diaz-Gonzalez
70eb751868
fix: correct ps-can-scale guard
2021-08-01 16:26:29 -04:00
Jose Diaz-Gonzalez
46d333df4b
feat: implement ps-set-scale trigger
2021-08-01 16:13:03 -04:00
Jose Diaz-Gonzalez
bc49a2e124
fix: ignore DOKKU_SCALE file if app.json has formations key
2021-08-01 00:30:31 -04:00
Jose Diaz-Gonzalez
3fe10efd09
fix: correct issue with assignment to nil map
2021-07-31 23:00:37 -04:00
Jose Diaz-Gonzalez
772e4286f2
fix: variable reference
2021-07-31 22:44:05 -04:00
Jose Diaz-Gonzalez
b9e30e7e19
fix: remove redundant if check
2021-07-31 22:23:19 -04:00
Jose Diaz-Gonzalez
67317f88df
fix: do not force fetching of the DOKKU_SCALE file
2021-07-31 20:54:14 -04:00
Jose Diaz-Gonzalez
c6d99722eb
fix: correct stickler errors
2021-07-31 20:54:14 -04:00
Jose Diaz-Gonzalez
bd2aa1bd43
feat: migrate the DOKKU_SCALE property during pre-deploy to app.json
2021-07-31 20:54:14 -04:00
Jose Diaz-Gonzalez
6d9520e599
feat: add support for formation key in app.json file
...
Still needs triggers for ps-can-scale and ps-scale-set.
Refs #4500
2021-07-31 20:54:14 -04:00
Jose Diaz-Gonzalez
f9247a9c42
fix: strip published port flags when triggering deploy tasks
...
Closes #4664
2021-07-11 20:55:12 -04:00
Jose Diaz-Gonzalez
a6113f88e7
featfeat: add ability to specify a custom app.json path
2021-07-10 14:57:56 -04:00
Jose Diaz-Gonzalez
8766820974
fix: always retire deployment task containers
...
Without this, the normal cleanup routine would not remove the containers, and removal would require a manual call to 'dokku cleanup'.
2021-05-22 15:37:21 -04:00
Jose Diaz-Gonzalez
578f6e7ba5
fix: ensure deployment task containers get associated to internal networks
...
Closes #4543
2021-04-13 19:47:45 -04:00
Jose Diaz-Gonzalez
356ed6f9eb
feat: modify the deployment task if the detected entrypoint is tini
...
Closes #4522
2021-03-25 20:17:16 -04:00
Jose Diaz-Gonzalez
376d7bdac6
fix: ignore set pipefail errors when DOKKU_SHELL is set to sh
2021-03-25 20:10:41 -04:00
Jose Diaz-Gonzalez
1ec71cd509
refactor: switch detected builder so first one wins
...
Also rename internal cnb references to pack (where possible).
2021-02-28 16:19:41 -05:00
Jose Diaz-Gonzalez
d09a7506df
refactor: bubble up error handling so that standard exit codes can be set at the top-level
...
LogFail shouldn't be called internally if at all possible.
2021-02-28 15:20:46 -05:00
Jose Diaz-Gonzalez
f98e7702fb
feat: implement heroku's postdeploy deployment task
...
This occurs during the postdeploy on the first deploy of an app, mimicking heroku. It currently happens _after_ the `postdeploy` and `release` deploy tasks.
2021-02-28 04:51:42 -05:00
Jose Diaz-Gonzalez
0673fdff2d
fix: handle new herokuish image detection in deployment tasks
2021-02-11 07:16:43 -05:00
Jose Diaz-Gonzalez
da1ddee0ba
fix: override the launcher for cnb apps since the default launcher is the process launcher...
2021-02-11 06:51:01 -05:00
Jose Diaz-Gonzalez
34807028db
feat: ensure we inject environment variables into the docker container create call in app-json
...
This fixes an issue where the values are empty for CNB applications.
2021-02-11 06:43:15 -05:00
Jose Diaz-Gonzalez
7c923a0fa1
fix: swap order of arguments on config-get call
2021-02-10 05:23:42 -05:00
Jose Diaz-Gonzalez
b7ff627368
fix: correct app-specific shell handling
2021-01-23 12:44:07 -05:00
Jose Diaz-Gonzalez
f7ef14d737
feat: add initial scheduled task implementation
...
This functionality enables users to manage a global crontab for the Dokku user that contains all scheduled tasks across all apps. Alternative schedulers can implement cron tasks as desired.
2021-01-20 14:49:48 -05:00
