From c09dfb8ec89d8e8ea0db33674f37fc7190c14b02 Mon Sep 17 00:00:00 2001 From: Jose Diaz-Gonzalez Date: Sun, 7 Feb 2021 21:03:04 -0500 Subject: [PATCH] feat: only warn if the vector container is stopped when fetching logs Closes #4385 --- plugins/logs/subcommands.go | 2 +- tests/unit/logs.bats | 12 ++++++++++++ 2 files changed, 13 insertions(+), 1 deletion(-) diff --git a/plugins/logs/subcommands.go b/plugins/logs/subcommands.go index cdfe4ed62..365a67892 100644 --- a/plugins/logs/subcommands.go +++ b/plugins/logs/subcommands.go @@ -88,7 +88,7 @@ func CommandVectorLogs(lines int, tail bool) error { } if !common.ContainerIsRunning(vectorContainerName) { - return errors.New("Vector container is not running") + common.LogWarn("Vector container is not running") } common.LogInfo1Quiet("Vector container logs") diff --git a/tests/unit/logs.bats b/tests/unit/logs.bats index d0d3ea7e5..08e2e41c7 100644 --- a/tests/unit/logs.bats +++ b/tests/unit/logs.bats @@ -404,6 +404,18 @@ teardown() { assert_output_contains "vector:" 5 assert_line_count 6 + run /bin/bash -c "docker stop vector" + echo "output: $output" + echo "status: $status" + assert_success + + run /bin/bash -c "dokku logs:vector-logs 2>&1" + echo "output: $output" + echo "status: $status" + assert_success + assert_output_contains "Vector container logs" + assert_output_contains "Vector container is not running" + run /bin/bash -c "dokku logs:vector-stop 2>&1" echo "output: $output" echo "status: $status"